starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #153] [MERGED] Support TLS 1.3 #88

New Issue
Closed
opened 2025-12-29 07:19:16 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:16 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/153
Author: @gschier
Created: 1/9/2025
Status: ✅ Merged
Merged: 1/11/2025
Merged by: @gschier

Base: master ← Head: tls13

📝 Commits (6)

  • 6c35636 Support TLS 1.3 via rustls-tls-native-roots
  • 1a3d3fe Upgrade reqwest
  • 7484b71 Merge branch 'master' into tls13
  • 70f2345 Use rust-platform-verifier
  • 6ccae01 Update dep
  • efdef9b Merge branch 'master' into tls13

📊 Changes

3 files changed (+158 additions, -46 deletions)

View changed files

📝 src-tauri/Cargo.lock (+130 -36)
📝 src-tauri/Cargo.toml (+4 -2)
📝 src-tauri/src/http_request.rs (+24 -8)

📄 Description

Closes #85

As mentioned in #85, I didn't want to transition to the Reqwest rustls-tls feature (over native-tls) because I think it's valuable for Yaak to inherit the OS-native root certificates.

However, I discovered that Reqwest has a rustls-tls-native-certs feature, which uses rustls AND pulls certs from the OS. Perfect!

Here's a test of it working with https://tls13.1d.pw.

CleanShot 2025-01-08 at 22 01 27@2x

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/153 **Author:** [@gschier](https://github.com/gschier) **Created:** 1/9/2025 **Status:** ✅ Merged **Merged:** 1/11/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `tls13` --- ### 📝 Commits (6) - [`6c35636`](https://github.com/mountain-loop/yaak/commit/6c3563646167e8921f0e0bf6fe2bf1ea42762a97) Support TLS 1.3 via rustls-tls-native-roots - [`1a3d3fe`](https://github.com/mountain-loop/yaak/commit/1a3d3fe60c83e8ca0ef293738bed65d171c020ed) Upgrade reqwest - [`7484b71`](https://github.com/mountain-loop/yaak/commit/7484b71236dd5014615cd481d6dd36456b9377b2) Merge branch 'master' into tls13 - [`70f2345`](https://github.com/mountain-loop/yaak/commit/70f2345e0b7d2361696e1f6d446394672b971678) Use rust-platform-verifier - [`6ccae01`](https://github.com/mountain-loop/yaak/commit/6ccae010cd4596dd7873a2e0ded22558de6300ad) Update dep - [`efdef9b`](https://github.com/mountain-loop/yaak/commit/efdef9bd3d0822af1507f75df5028ffe7ddf3e4d) Merge branch 'master' into tls13 ### 📊 Changes **3 files changed** (+158 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/Cargo.lock` (+130 -36) 📝 `src-tauri/Cargo.toml` (+4 -2) 📝 `src-tauri/src/http_request.rs` (+24 -8) </details> ### 📄 Description Closes #85 As mentioned in #85, I didn't want to transition to the Reqwest `rustls-tls` feature (over `native-tls`) because I think it's valuable for Yaak to inherit the OS-native root certificates. However, I discovered that Reqwest has a `rustls-tls-native-certs` feature, which uses `rustls` AND pulls certs from the OS. Perfect! Here's a test of it working with https://tls13.1d.pw. ![CleanShot 2025-01-08 at 22 01 27@2x](https://github.com/user-attachments/assets/e24091b5-3f61-4098-86dc-973708ba07b5) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:16 +01:00
adam closed this issue 2025-12-29 07:19:16 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#88
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?