[PR #141] [CLOSED] Hide dropdown when no valid recent requests exist #76

Closed
opened 2025-12-29 07:19:13 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/141
Author: @peimn
Created: 12/13/2024
Status: Closed

Base: masterHead: ghost-dropdown


📝 Commits (4)

  • aba1865 hide dropdown when no valid recent requests exist
  • 084ab27 Merge branch 'master' into ghost-dropdown
  • db8bc16 chore: optimize dropdown handling for empty requests
  • 595228e Merge branch 'master' into ghost-dropdown

📊 Changes

1 file changed (+18 additions, -15 deletions)

View changed files

📝 src-web/components/RecentRequestsDropdown.tsx (+18 -15)

📄 Description

Fixes an issue where the dropdown would display even when no valid recent requests were available. Ensures the dropdown only appears when there are meaningful items to show.

Screenshot 2024-12-13 at 3 17 01 PM Screenshot 2024-12-13 at 3 16 32 PM

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/141 **Author:** [@peimn](https://github.com/peimn) **Created:** 12/13/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `ghost-dropdown` --- ### 📝 Commits (4) - [`aba1865`](https://github.com/mountain-loop/yaak/commit/aba18659745393b175afb3eaeab9ac53fc391d07) hide dropdown when no valid recent requests exist - [`084ab27`](https://github.com/mountain-loop/yaak/commit/084ab2754f15e3158570136ce30ae777f2413352) Merge branch 'master' into ghost-dropdown - [`db8bc16`](https://github.com/mountain-loop/yaak/commit/db8bc169b4e18ebd8844e8537f7d5e549fb9a661) chore: optimize dropdown handling for empty requests - [`595228e`](https://github.com/mountain-loop/yaak/commit/595228e9adb928de7b0c0f3bcc09f50a25c7404f) Merge branch 'master' into ghost-dropdown ### 📊 Changes **1 file changed** (+18 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/RecentRequestsDropdown.tsx` (+18 -15) </details> ### 📄 Description Fixes an issue where the dropdown would display even when no valid recent requests were available. Ensures the dropdown only appears when there are meaningful items to show. <img width="334" alt="Screenshot 2024-12-13 at 3 17 01 PM" src="https://github.com/user-attachments/assets/302e8a24-da0d-4c84-a6ea-9f0ecc3dccb2" /> <img width="334" alt="Screenshot 2024-12-13 at 3 16 32 PM" src="https://github.com/user-attachments/assets/45a696ac-352f-4472-9296-4e5d203e4c40" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:13 +01:00
adam closed this issue 2025-12-29 07:19:13 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#76