starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #139] [MERGED] Fix: Settings Window Title Bar Draggable Region Deadzone #74

New Issue
Closed
opened 2025-12-29 07:19:12 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:12 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/139
Author: @JeffreyDMitchell
Created: 12/5/2024
Status: ✅ Merged
Merged: 12/10/2024
Merged by: @gschier

Base: master ← Head: draggable-window-control-region

📝 Commits (1)

  • ff71f79 window control area draggable

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 src-web/components/WindowControls.tsx (+1 -0)

📄 Description

Issue:
Settings window is not draggable in this region:
image

Solution:
This can be corrected by adding the data-tauri-drag-region prop to the WindowControls component.

Alternatively, users of WINDOW_CONTROLS_WIDTH could compute the true width of the windows controls based on which controls are available.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/139 **Author:** [@JeffreyDMitchell](https://github.com/JeffreyDMitchell) **Created:** 12/5/2024 **Status:** ✅ Merged **Merged:** 12/10/2024 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `draggable-window-control-region` --- ### 📝 Commits (1) - [`ff71f79`](https://github.com/mountain-loop/yaak/commit/ff71f79cf5953ca06d6accc1dd3b8e4209a5bd2e) window control area draggable ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/WindowControls.tsx` (+1 -0) </details> ### 📄 Description **Issue:** Settings window is not draggable in this region: ![image](https://github.com/user-attachments/assets/5b5c33c1-bd26-4295-902c-836559ef14c2) **Solution:** This can be corrected by adding the `data-tauri-drag-region` prop to the `WindowControls` component. Alternatively, users of `WINDOW_CONTROLS_WIDTH` could compute the true width of the windows controls based on which controls are available. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:12 +01:00
adam closed this issue 2025-12-29 07:19:12 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#74
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?