starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #133] [MERGED] fix: Add Missing Themes Moonlight & Dracula #68

New Issue
Closed
opened 2025-12-29 07:19:11 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:11 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/133
Author: @Bad3r
Created: 11/18/2024
Status: ✅ Merged
Merged: 12/3/2024
Merged by: @gschier

Base: master ← Head: fix/missing-themes

📝 Commits (2)

  • b0bd8ff fix: Add missing themes moonlight & Dracula
  • fb51ab7 Merge branch 'master' into fix/missing-themes

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 src-web/lib/theme/themes.ts (+4 -0)

📄 Description

While working on #132, I discovered that the Moonlight and Dracula themes, although present in the themes/ folder, were not registered in themes.ts resulting in these themes being unavailable in the app.

Changes Introduced:

  1. Registered the Moonlight and Dracula themes in themes.ts to make them accessible in the application.

Testing:

  1. Verify that both Moonlight and Dracula themes are now available in the theme selection menu.

This small fix restores the availability of these themes, ensuring users can enjoy them as intended.

Thank you for reviewing this PR!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/133 **Author:** [@Bad3r](https://github.com/Bad3r) **Created:** 11/18/2024 **Status:** ✅ Merged **Merged:** 12/3/2024 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `fix/missing-themes` --- ### 📝 Commits (2) - [`b0bd8ff`](https://github.com/mountain-loop/yaak/commit/b0bd8ffdae35786a338d4502e980d8d616540fe3) fix: Add missing themes moonlight & Dracula - [`fb51ab7`](https://github.com/mountain-loop/yaak/commit/fb51ab7ec8f9027111ce1166a802b1f4ef96b62f) Merge branch 'master' into fix/missing-themes ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src-web/lib/theme/themes.ts` (+4 -0) </details> ### 📄 Description While working on #132, I discovered that the **Moonlight** and **Dracula** themes, although present in the `themes/` folder, were not registered in `themes.ts` resulting in these themes being unavailable in the app. #### Changes Introduced: 1. Registered the **Moonlight** and **Dracula** themes in `themes.ts` to make them accessible in the application. #### Testing: 1. Verify that both **Moonlight** and **Dracula** themes are now available in the theme selection menu. This small fix restores the availability of these themes, ensuring users can enjoy them as intended. Thank you for reviewing this PR! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:11 +01:00
adam closed this issue 2025-12-29 07:19:11 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#68
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?