starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #115] [MERGED] Prevent theme flashing on initial window load #51

New Issue
Closed
opened 2025-12-29 07:19:05 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:05 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/115
Author: @gschier
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @gschier

Base: master ← Head: fix-theme-flashing

📝 Commits (1)

📊 Changes

4 files changed (+15 additions, -8 deletions)

View changed files

📝 src-tauri/capabilities/capabilities.json (+1 -0)
📝 src-tauri/gen/schemas/capabilities.json (+1 -1)
📝 src-tauri/src/lib.rs (+1 -0)
📝 src-web/theme.ts (+12 -7)

📄 Description

Since the current theme is not yet available when a new window is shown for the first time, there may be a flash of the background color going from light to dark. This is particularly the case on Windows, where the default background is white, even in dark mode).

This PR sets all new windows to hidden by default and leaves it up to the frontend code to show its window after the theme is initially loaded.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/115 **Author:** [@gschier](https://github.com/gschier) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `fix-theme-flashing` --- ### 📝 Commits (1) - [`155ce62`](https://github.com/mountain-loop/yaak/commit/155ce62bfebe6618ebca7c2178c91e178dda0bac) Fix theme flashing ### 📊 Changes **4 files changed** (+15 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/capabilities/capabilities.json` (+1 -0) 📝 `src-tauri/gen/schemas/capabilities.json` (+1 -1) 📝 `src-tauri/src/lib.rs` (+1 -0) 📝 `src-web/theme.ts` (+12 -7) </details> ### 📄 Description Since the current theme is not yet available when a new window is shown for the first time, there may be a flash of the background color going from light to dark. This is particularly the case on Windows, where the default background is white, even in dark mode). This PR sets all new windows to hidden by default and leaves it up to the frontend code to show its window after the theme is initially loaded. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:05 +01:00
adam closed this issue 2025-12-29 07:19:05 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#51
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?