starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #112] [MERGED] Simpler Tauri resource paths #49

New Issue
Closed
opened 2025-12-29 07:19:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/112
Author: @gschier
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @gschier

Base: master ← Head: fix-tauri-resources

📝 Commits (1)

  • d358760 Simpler Tauri resource paths

📊 Changes

8 files changed (+18 additions, -16 deletions)

View changed files

📝 plugin-runtime/package.json (+2 -2)
➕ scripts/.gitignore (+1 -0)
📝 scripts/vendor-node.cjs (+4 -3)
📝 scripts/vendor-protoc.cjs (+2 -2)
📝 src-tauri/tauri.conf.json (+6 -6)
📝 src-tauri/yaak_grpc/src/proto.rs (+1 -1)
📝 src-tauri/yaak_plugin_runtime/src/manager.rs (+1 -1)
📝 src-tauri/yaak_plugin_runtime/src/nodejs.rs (+1 -1)

📄 Description

There was some weirdness around using ../ in Tauri resource paths. This PR moves the build output of the plugin runtime to eliminate the need for ../. This should fix the RPM package putting things in the wrong place.

Fixes #72 (hopefully)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/112 **Author:** [@gschier](https://github.com/gschier) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `fix-tauri-resources` --- ### 📝 Commits (1) - [`d358760`](https://github.com/mountain-loop/yaak/commit/d358760bc024d6e9b6676441dd4461c7f0ed47ca) Simpler Tauri resource paths ### 📊 Changes **8 files changed** (+18 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `plugin-runtime/package.json` (+2 -2) ➕ `scripts/.gitignore` (+1 -0) 📝 `scripts/vendor-node.cjs` (+4 -3) 📝 `scripts/vendor-protoc.cjs` (+2 -2) 📝 `src-tauri/tauri.conf.json` (+6 -6) 📝 `src-tauri/yaak_grpc/src/proto.rs` (+1 -1) 📝 `src-tauri/yaak_plugin_runtime/src/manager.rs` (+1 -1) 📝 `src-tauri/yaak_plugin_runtime/src/nodejs.rs` (+1 -1) </details> ### 📄 Description There was some weirdness around using `../` in Tauri resource paths. This PR moves the build output of the plugin runtime to eliminate the need for `../`. This should fix the RPM package putting things in the wrong place. Fixes #72 (hopefully) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:04 +01:00
adam closed this issue 2025-12-29 07:19:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#49
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?