starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #109] [MERGED] Faster time-to-theme #47

New Issue
Closed
opened 2025-12-29 07:19:04 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:04 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/109
Author: @gschier
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @gschier

Base: master ← Head: theme-refactor

📝 Commits (3)

📊 Changes

14 files changed (+132 additions, -93 deletions)

View changed files

📝 src-web/components/DefaultLayout.tsx (+2 -6)
📝 src-web/components/GlobalHooks.tsx (+5 -7)
📝 src-web/components/ResponsePane.tsx (+4 -2)
📝 src-web/components/Settings/SettingsAppearance.tsx (+6 -4)
📝 src-web/components/Settings/SettingsDesign.tsx (+3 -3)
📝 src-web/hooks/usePreferredAppearance.ts (+2 -11)
📝 src-web/hooks/useResolvedAppearance.ts (+2 -7)
📝 src-web/hooks/useResolvedTheme.ts (+9 -15)
➖ src-web/hooks/useSyncThemeToDocument.ts (+0 -23)
➖ src-web/hooks/useThemes.ts (+0 -13)
📝 src-web/index.html (+1 -0)
📝 src-web/lib/theme/appearance.ts (+17 -1)
📝 src-web/lib/theme/themes.ts (+36 -1)
➕ src-web/theme.ts (+45 -0)

📄 Description

This PR moves the theme handling logic into a separate JS entrypoint so it can load as fast as possible.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/109 **Author:** [@gschier](https://github.com/gschier) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `theme-refactor` --- ### 📝 Commits (3) - [`e021ce3`](https://github.com/mountain-loop/yaak/commit/e021ce3c806822bbabf8507d7df7fe957eecdeb7) Refactor how themes work - [`534e5c7`](https://github.com/mountain-loop/yaak/commit/534e5c796ee0e559ebe03e03592fd0708af5814f) Add back decorations hack - [`bbe340c`](https://github.com/mountain-loop/yaak/commit/bbe340c13f319f93c3c59ebd1ba0d325115c86ee) Move some stuff around ### 📊 Changes **14 files changed** (+132 additions, -93 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/DefaultLayout.tsx` (+2 -6) 📝 `src-web/components/GlobalHooks.tsx` (+5 -7) 📝 `src-web/components/ResponsePane.tsx` (+4 -2) 📝 `src-web/components/Settings/SettingsAppearance.tsx` (+6 -4) 📝 `src-web/components/Settings/SettingsDesign.tsx` (+3 -3) 📝 `src-web/hooks/usePreferredAppearance.ts` (+2 -11) 📝 `src-web/hooks/useResolvedAppearance.ts` (+2 -7) 📝 `src-web/hooks/useResolvedTheme.ts` (+9 -15) ➖ `src-web/hooks/useSyncThemeToDocument.ts` (+0 -23) ➖ `src-web/hooks/useThemes.ts` (+0 -13) 📝 `src-web/index.html` (+1 -0) 📝 `src-web/lib/theme/appearance.ts` (+17 -1) 📝 `src-web/lib/theme/themes.ts` (+36 -1) ➕ `src-web/theme.ts` (+45 -0) </details> ### 📄 Description This PR moves the theme handling logic into a separate JS entrypoint so it can load as fast as possible. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:04 +01:00
adam closed this issue 2025-12-29 07:19:04 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#47
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?