starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #77] [MERGED] Use padding for Basic auth #36

New Issue
Closed
opened 2025-12-29 07:19:01 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:01 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/77
Author: @mpk
Created: 9/11/2024
Status: ✅ Merged
Merged: 9/12/2024
Merged by: @gschier

Base: master ← Head: master

📝 Commits (1)

  • 5b2f623 Use padding for Basic auth

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src-tauri/src/http_request.rs (+1 -1)

📄 Description

Hi,

while trying Yaak, I have noticed that some requests using Basic auth does not work with the API I'm using. After debugging, I have found out that Yaak currently sends base64-encoded Authorization header without padding, which some APIs strictly require.

This change enables the padding for Basic auth, which aligns it with Insomnia (and Node.js "base64" encoding).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/77 **Author:** [@mpk](https://github.com/mpk) **Created:** 9/11/2024 **Status:** ✅ Merged **Merged:** 9/12/2024 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (1) - [`5b2f623`](https://github.com/mountain-loop/yaak/commit/5b2f623a80952ea1dbeed9dc17e5b7b763151564) Use padding for Basic auth ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/src/http_request.rs` (+1 -1) </details> ### 📄 Description Hi, while trying Yaak, I have noticed that some requests using `Basic` auth does not work with the API I'm using. After debugging, I have found out that Yaak currently sends base64-encoded `Authorization` header without padding, which some APIs strictly require. This change enables the padding for `Basic` auth, which aligns it with Insomnia (and Node.js "base64" encoding). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:01 +01:00
adam closed this issue 2025-12-29 07:19:01 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#36
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?