starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 11:50:31 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #325] [CLOSED] fix Couldn't use the "Copy Body" option when request to some website #247

New Issue
Closed
opened 2025-12-29 07:20:03 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:20:03 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/325
Author: @hxzhao527
Created: 12/16/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (1)

  • 4bee665 fix Couldn't use the "Copy Body" option when request to some website

📊 Changes

1 file changed (+7 additions, -3 deletions)

View changed files

📝 src-tauri/src/lib.rs (+7 -3)

📄 Description

fix https://feedback.yaak.app/p/couldnt-use-the-copy-body-option-when-request-to-some

I couldn't find out why the response's bodyPath is empty here.
So I try to fix it on the Rust side.

I tried to add debug log at cfbfd66eef/src-web/components/HttpResponsePane.tsx (L50-L60)

const contentType = getContentTypeFromHeaders(activeResponse?.headers ?? null);
const mimeType = contentType == null ? null : getMimeTypeFromContentType(contentType).essence;
console.log("Rendering HttpResponsePane for request", activeRequestId, "with response", activeResponse, "and viewMode", viewMode);
const tabs = useMemo<TabItem[]>(

It seems that the response was rendered when the request was sent and not updated then.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/325 **Author:** [@hxzhao527](https://github.com/hxzhao527) **Created:** 12/16/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (1) - [`4bee665`](https://github.com/mountain-loop/yaak/commit/4bee6659d2234a496f34b223adab07b2d37dce9d) fix Couldn't use the "Copy Body" option when request to some website ### 📊 Changes **1 file changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/src/lib.rs` (+7 -3) </details> ### 📄 Description fix https://feedback.yaak.app/p/couldnt-use-the-copy-body-option-when-request-to-some I couldn't find out why the response's bodyPath is empty here. So I try to fix it on the Rust side. I tried to add debug log at https://github.com/mountain-loop/yaak/blob/cfbfd66eef0a04583af29bd635d99d0278b6c4da/src-web/components/HttpResponsePane.tsx#L50-L60 ```typescript const contentType = getContentTypeFromHeaders(activeResponse?.headers ?? null); const mimeType = contentType == null ? null : getMimeTypeFromContentType(contentType).essence; console.log("Rendering HttpResponsePane for request", activeRequestId, "with response", activeResponse, "and viewMode", viewMode); const tabs = useMemo<TabItem[]>( ``` It seems that the response was rendered when the request was sent and not updated then. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:20:03 +01:00
adam closed this issue 2025-12-29 07:20:03 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#247
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?