[PR #320] [MERGED] Split up HTTP sending logic #242

Closed
opened 2025-12-29 07:20:01 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/320
Author: @gschier
Created: 12/12/2025
Status: Merged
Merged: 12/20/2025
Merged by: @gschier

Base: mainHead: sendable-http-request


📝 Commits (10+)

  • e277ab1 Start working on SendableHttpRequest and convertion to that type
  • e43a1e6 Support graphql body
  • f9e3eb0 Support multipart and text bodies
  • 3c9b3a9 Fix imports
  • e695b57 Build URL
  • f55d056 Enhance body and headers handling in SendableHttpRequest, adding content-type management and multipart support adjustments.
  • c6f6534 Refactor http_request to utilize SendableHttpRequest, simplifying URL, headers, and body handling.
  • f329d04 Add default User-Agent and Accept headers if missing in HTTP requests
  • 822464e Add boundary extraction from existing header
  • c577537 Get ready for streaming bodies

📊 Changes

41 files changed (+2699 additions, -723 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 src-tauri/Cargo.lock (+40 -4)
📝 src-tauri/Cargo.toml (+1 -0)
📝 src-tauri/src/error.rs (+1 -1)
📝 src-tauri/src/http_request.rs (+271 -594)
📝 src-tauri/src/render.rs (+1 -1)
📝 src-tauri/yaak-common/Cargo.toml (+1 -0)
📝 src-tauri/yaak-common/src/lib.rs (+1 -0)
src-tauri/yaak-common/src/serde.rs (+23 -0)
📝 src-tauri/yaak-http/Cargo.toml (+13 -2)
src-tauri/yaak-http/src/chained_reader.rs (+78 -0)
📝 src-tauri/yaak-http/src/client.rs (+6 -19)
src-tauri/yaak-http/src/decompress.rs (+188 -0)
📝 src-tauri/yaak-http/src/error.rs (+15 -0)
📝 src-tauri/yaak-http/src/lib.rs (+6 -0)
📝 src-tauri/yaak-http/src/path_placeholders.rs (+3 -3)
src-tauri/yaak-http/src/proto.rs (+29 -0)
src-tauri/yaak-http/src/sender.rs (+409 -0)
src-tauri/yaak-http/src/transaction.rs (+385 -0)
src-tauri/yaak-http/src/types.rs (+975 -0)

...and 21 more files

📄 Description

This is part 1 of https://feedback.yaak.app/p/view-entire-request-response-flow


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/320 **Author:** [@gschier](https://github.com/gschier) **Created:** 12/12/2025 **Status:** ✅ Merged **Merged:** 12/20/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `sendable-http-request` --- ### 📝 Commits (10+) - [`e277ab1`](https://github.com/mountain-loop/yaak/commit/e277ab16646f55d751d3589e2c75856a51f5e7de) Start working on SendableHttpRequest and convertion to that type - [`e43a1e6`](https://github.com/mountain-loop/yaak/commit/e43a1e650cba3eee85c6c8098b984c8a3f3c2e4b) Support graphql body - [`f9e3eb0`](https://github.com/mountain-loop/yaak/commit/f9e3eb01e6b0eefe0ee13ce44a066c675a208780) Support multipart and text bodies - [`3c9b3a9`](https://github.com/mountain-loop/yaak/commit/3c9b3a9ca9688027052dce47736dbccfddd9dfc2) Fix imports - [`e695b57`](https://github.com/mountain-loop/yaak/commit/e695b5710178335515c4f08b297b056c0011a3c0) Build URL - [`f55d056`](https://github.com/mountain-loop/yaak/commit/f55d0569812bc98ba26758087605951807d24c1a) Enhance body and headers handling in `SendableHttpRequest`, adding content-type management and multipart support adjustments. - [`c6f6534`](https://github.com/mountain-loop/yaak/commit/c6f6534c61e97a471f6e4a3a793d9cbaee87a19c) Refactor `http_request` to utilize `SendableHttpRequest`, simplifying URL, headers, and body handling. - [`f329d04`](https://github.com/mountain-loop/yaak/commit/f329d04f1d37563415501c204b407283dc1f2898) Add default `User-Agent` and `Accept` headers if missing in HTTP requests - [`822464e`](https://github.com/mountain-loop/yaak/commit/822464ea4f721849145b1dba04ee98f66b10ca8e) Add boundary extraction from existing header - [`c577537`](https://github.com/mountain-loop/yaak/commit/c577537271958decbaad3db4293506f101f5f7b7) Get ready for streaming bodies ### 📊 Changes **41 files changed** (+2699 additions, -723 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `src-tauri/Cargo.lock` (+40 -4) 📝 `src-tauri/Cargo.toml` (+1 -0) 📝 `src-tauri/src/error.rs` (+1 -1) 📝 `src-tauri/src/http_request.rs` (+271 -594) 📝 `src-tauri/src/render.rs` (+1 -1) 📝 `src-tauri/yaak-common/Cargo.toml` (+1 -0) 📝 `src-tauri/yaak-common/src/lib.rs` (+1 -0) ➕ `src-tauri/yaak-common/src/serde.rs` (+23 -0) 📝 `src-tauri/yaak-http/Cargo.toml` (+13 -2) ➕ `src-tauri/yaak-http/src/chained_reader.rs` (+78 -0) 📝 `src-tauri/yaak-http/src/client.rs` (+6 -19) ➕ `src-tauri/yaak-http/src/decompress.rs` (+188 -0) 📝 `src-tauri/yaak-http/src/error.rs` (+15 -0) 📝 `src-tauri/yaak-http/src/lib.rs` (+6 -0) 📝 `src-tauri/yaak-http/src/path_placeholders.rs` (+3 -3) ➕ `src-tauri/yaak-http/src/proto.rs` (+29 -0) ➕ `src-tauri/yaak-http/src/sender.rs` (+409 -0) ➕ `src-tauri/yaak-http/src/transaction.rs` (+385 -0) ➕ `src-tauri/yaak-http/src/types.rs` (+975 -0) _...and 21 more files_ </details> ### 📄 Description This is part 1 of https://feedback.yaak.app/p/view-entire-request-response-flow --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:20:01 +01:00
adam closed this issue 2025-12-29 07:20:01 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#242