starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #316] [MERGED] Update 1Password template to support the new Desktop authentication method #238

New Issue
Closed
opened 2025-12-29 07:20:00 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:20:00 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/316
Author: @skos-ninja
Created: 12/9/2025
Status: ✅ Merged
Merged: 12/9/2025
Merged by: @gschier

Base: main ← Head: main

📝 Commits (4)

  • 4852fd9 Modify the 1Password template to support the new Desktop authentication
  • 47559bd Update label to be clearer
  • a4d93f7 Update 1Password plugin: rename fields, improve validation, and adjust UI layout
  • d9aec06 Merge branch 'main' into main

📊 Changes

1 file changed (+147 additions, -48 deletions)

View changed files

📝 plugins/template-function-1password/src/index.ts (+147 -48)

📄 Description

Problem

The new 1Password template function only supported authenticating via service account tokens which in some organisations isn't allowed as access needs to be controlled on a per user basis with no static tokens.

Solution

1Password has recently added beta support for authenticating via the Desktop App (see here). This allows you to securely access items whilst having no long lived tokens in the users environments.

I've modified the existing 1Password template function to support switching between service tokens and desktop auth whilst retaining the existing functionality for any existing users that use the current service token setup today.

Additionally I've added extra error handling so that if a 1Password item, field or vault gets removed the UI will now return an error state rather than becoming blank and you having to remove the template function and re-add

Desktop Auth Preview

image

Please note the application in the prompt shows as iTerm due to local running. On production build this should show as Yaak

image

Service Token Auth Preview

image

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/316 **Author:** [@skos-ninja](https://github.com/skos-ninja) **Created:** 12/9/2025 **Status:** ✅ Merged **Merged:** 12/9/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`4852fd9`](https://github.com/mountain-loop/yaak/commit/4852fd9b8cfef8635e80706b7a73a06508af0953) Modify the 1Password template to support the new Desktop authentication - [`47559bd`](https://github.com/mountain-loop/yaak/commit/47559bd8735dd6d0467b90030e67eb8a56a62784) Update label to be clearer - [`a4d93f7`](https://github.com/mountain-loop/yaak/commit/a4d93f75cad0e37ca923c40f6a21e381cb472cc4) Update 1Password plugin: rename fields, improve validation, and adjust UI layout - [`d9aec06`](https://github.com/mountain-loop/yaak/commit/d9aec06eec726b09594a1df82dd07e2d07c3de12) Merge branch 'main' into main ### 📊 Changes **1 file changed** (+147 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `plugins/template-function-1password/src/index.ts` (+147 -48) </details> ### 📄 Description ## Problem The new 1Password template function only supported authenticating via service account tokens which in some organisations isn't allowed as access needs to be controlled on a per user basis with no static tokens. ## Solution 1Password has recently added beta support for authenticating via the Desktop App (see [here](https://developer.1password.com/docs/sdks/desktop-app-integrations)). This allows you to securely access items whilst having no long lived tokens in the users environments. I've modified the existing 1Password template function to support switching between service tokens and desktop auth whilst retaining the existing functionality for any existing users that use the current service token setup today. Additionally I've added extra error handling so that if a 1Password item, field or vault gets removed the UI will now return an error state rather than becoming blank and you having to remove the template function and re-add ## Desktop Auth Preview <img width="1104" height="743" alt="image" src="https://github.com/user-attachments/assets/c1b4f846-a3a7-4ffc-be64-4254ec93e325" /> *Please note the application in the prompt shows as iTerm due to local running. On production build this should show as Yaak* <img width="1213" height="851" alt="image" src="https://github.com/user-attachments/assets/82b0deb1-15eb-4801-b638-db2eca6ce51a" /> ## Service Token Auth Preview <img width="1213" height="851" alt="image" src="https://github.com/user-attachments/assets/5bbb35cb-948b-4a92-95f5-08086987596f" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:20:00 +01:00
adam closed this issue 2025-12-29 07:20:00 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#238
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?