starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #55] [CLOSED] Manage NodeJS binary at runtime #23

New Issue
Closed
opened 2025-12-29 07:18:56 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:18:56 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/55
Author: @gschier
Created: 7/24/2024
Status: ❌ Closed

Base: master ← Head: fetch-nodejs

📝 Commits (1)

  • 828c88b Add NodeJS fetching (not lazy yet)

📊 Changes

6 files changed (+406 additions, -16 deletions)

View changed files

📝 src-tauri/Cargo.lock (+192 -1)
📝 src-tauri/tauri-plugin-plugin-runtime/Cargo.toml (+7 -0)
➕ src-tauri/tauri-plugin-plugin-runtime/src/archive.rs (+110 -0)
📝 src-tauri/tauri-plugin-plugin-runtime/src/lib.rs (+3 -1)
📝 src-tauri/tauri-plugin-plugin-runtime/src/nodejs.rs (+93 -12)
📝 src-tauri/tauri.conf.json (+1 -2)

📄 Description

This PR changes the NodeJS dependency from a Tauri Sidecar to self-managed binary. There is some Rust code to download and extract the Node binary into the correct place.

The management of this download is tricky because I haven't been able to figure out a way to lazily set a mutable global within Tauri state.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/55 **Author:** [@gschier](https://github.com/gschier) **Created:** 7/24/2024 **Status:** ❌ Closed **Base:** `master` ← **Head:** `fetch-nodejs` --- ### 📝 Commits (1) - [`828c88b`](https://github.com/mountain-loop/yaak/commit/828c88b745eedba25e08fb6d23f840dbbfa2e4c7) Add NodeJS fetching (not lazy yet) ### 📊 Changes **6 files changed** (+406 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/Cargo.lock` (+192 -1) 📝 `src-tauri/tauri-plugin-plugin-runtime/Cargo.toml` (+7 -0) ➕ `src-tauri/tauri-plugin-plugin-runtime/src/archive.rs` (+110 -0) 📝 `src-tauri/tauri-plugin-plugin-runtime/src/lib.rs` (+3 -1) 📝 `src-tauri/tauri-plugin-plugin-runtime/src/nodejs.rs` (+93 -12) 📝 `src-tauri/tauri.conf.json` (+1 -2) </details> ### 📄 Description This PR changes the NodeJS dependency from a Tauri Sidecar to self-managed binary. There is some Rust code to download and extract the Node binary into the correct place. The management of this download is tricky because I haven't been able to figure out a way to lazily set a mutable global within Tauri state. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:18:56 +01:00
adam closed this issue 2025-12-29 07:18:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#23
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?