starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-03-02 19:30:05 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #273] [MERGED] Fix dismissable banner action button title #196

New Issue
Closed
opened 2025-12-29 07:19:49 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:49 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/273
Author: @bkis
Created: 10/22/2025
Status: ✅ Merged
Merged: 10/29/2025
Merged by: @gschier

Base: main ← Head: patch-1

📝 Commits (1)

  • 0e50665 Fix dismissable banner action button title

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src-web/components/core/DismissibleBanner.tsx (+1 -1)

📄 Description

Reusing the action label as the button title is redundant and not ideal (an extended description would be nice), but it's far better than "Dismiss message", which is the button title of the "Dismiss" button. This might have been a copy & paste error.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/273 **Author:** [@bkis](https://github.com/bkis) **Created:** 10/22/2025 **Status:** ✅ Merged **Merged:** 10/29/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`0e50665`](https://github.com/mountain-loop/yaak/commit/0e50665097c9f02f24106d32d7145a19a5083f19) Fix dismissable banner action button title ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/core/DismissibleBanner.tsx` (+1 -1) </details> ### 📄 Description Reusing the action label as the button title is redundant and not ideal (an extended description would be nice), but it's far better than "Dismiss message", which is the button title of the "Dismiss" button. This might have been a copy & paste error. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:49 +01:00
adam closed this issue 2025-12-29 07:19:49 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#196
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?