starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #260] [MERGED] Add back environment.base #185

New Issue
Closed
opened 2025-12-29 07:19:42 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:42 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/260
Author: @gschier
Created: 10/2/2025
Status: ✅ Merged
Merged: 10/2/2025
Merged by: @gschier

Base: main ← Head: environment-base-legacy

📝 Commits (3)

  • 49b8f88 Add back Environment > Base attribute for compatibility with older versions
  • fc49405 Set base during environment creation/upsert
  • aa34abc Revert unnecessary change

📊 Changes

2 files changed (+16 additions, -4 deletions)

View changed files

📝 src-tauri/yaak-models/bindings/gen_util.ts (+1 -1)
📝 src-tauri/yaak-models/src/models.rs (+15 -3)

📄 Description

Environment.base was changed to Environment.parentModel in the latest beta, but this breaks environments for sync and export with older versions of the app. This PR adds the property back to the struct (not the DB) so compatibility holds until we come up with a solution to manage schema version changes with exports.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/260 **Author:** [@gschier](https://github.com/gschier) **Created:** 10/2/2025 **Status:** ✅ Merged **Merged:** 10/2/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `environment-base-legacy` --- ### 📝 Commits (3) - [`49b8f88`](https://github.com/mountain-loop/yaak/commit/49b8f88ee6e54253ed876d768fca25f52acac5e2) Add back Environment > Base attribute for compatibility with older versions - [`fc49405`](https://github.com/mountain-loop/yaak/commit/fc4940558f50028088257f5ef8325ec2b9305502) Set base during environment creation/upsert - [`aa34abc`](https://github.com/mountain-loop/yaak/commit/aa34abc05ce4a553ec6c52ca7e5b0a37fcc37564) Revert unnecessary change ### 📊 Changes **2 files changed** (+16 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/yaak-models/bindings/gen_util.ts` (+1 -1) 📝 `src-tauri/yaak-models/src/models.rs` (+15 -3) </details> ### 📄 Description `Environment.base` was changed to `Environment.parentModel` in the latest beta, but this breaks environments for sync and export with older versions of the app. This PR adds the property back to the struct (not the DB) so compatibility holds until we come up with a solution to manage schema version changes with exports. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:42 +01:00
adam closed this issue 2025-12-29 07:19:42 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#185
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?