starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #245] [MERGED] Attach cookies to WS Upgrade #169

New Issue
Closed
opened 2025-12-29 07:19:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/245
Author: @carterjc
Created: 7/22/2025
Status: ✅ Merged
Merged: 7/23/2025
Merged by: @gschier

Base: main ← Head: main

📝 Commits (3)

  • b82ad57 Attach cookies to WS Upgrade
  • ba9f74c Merge branch 'main' into main
  • 78a54b3 Move reqwest_cookie_store to workspace dep

📊 Changes

4 files changed (+64 additions, -7 deletions)

View changed files

📝 src-tauri/Cargo.lock (+1 -0)
📝 src-tauri/Cargo.toml (+2 -1)
📝 src-tauri/yaak-ws/Cargo.toml (+1 -0)
📝 src-tauri/yaak-ws/src/commands.rs (+60 -6)

📄 Description

WS requests currently don't interact with cookie jars (first reported here). Because the first leg of a WS connection is an HTTP Upgrade, this PR grabs the cookie jar, finds cookies that match the HTTP-variant of the WS URL, and inserts them into the request headers.

I also noticed that WS connection errors were being formatted in debug mode, so I modified that as well.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/245 **Author:** [@carterjc](https://github.com/carterjc) **Created:** 7/22/2025 **Status:** ✅ Merged **Merged:** 7/23/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (3) - [`b82ad57`](https://github.com/mountain-loop/yaak/commit/b82ad5757e9b8574023f9f472f2aa0e0553f2561) Attach cookies to WS Upgrade - [`ba9f74c`](https://github.com/mountain-loop/yaak/commit/ba9f74c002917bfef04282afade3f5431ba0e37c) Merge branch 'main' into main - [`78a54b3`](https://github.com/mountain-loop/yaak/commit/78a54b3ad9b0d040030860ca763052fef82080b4) Move reqwest_cookie_store to workspace dep ### 📊 Changes **4 files changed** (+64 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/Cargo.lock` (+1 -0) 📝 `src-tauri/Cargo.toml` (+2 -1) 📝 `src-tauri/yaak-ws/Cargo.toml` (+1 -0) 📝 `src-tauri/yaak-ws/src/commands.rs` (+60 -6) </details> ### 📄 Description WS requests currently don't interact with cookie jars (first reported [here](https://feedback.yaak.app/p/no-cookiesproxy-for-websocket-requests)). Because the first leg of a WS connection is an HTTP Upgrade, this PR grabs the cookie jar, finds cookies that match the HTTP-variant of the WS URL, and inserts them into the request headers. I also noticed that WS connection errors were being formatted in debug mode, so I modified that as well. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:38 +01:00
adam closed this issue 2025-12-29 07:19:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#169
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?