starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-14 05:03:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #243] [MERGED] fix padding and hover highlight in tabs #168

New Issue
Closed
opened 2025-12-29 07:19:38 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:38 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/243
Author: @subframe7536
Created: 7/19/2025
Status: ✅ Merged
Merged: 7/19/2025
Merged by: @gschier

Base: main ← Head: fix-vertical-tab-padding

📝 Commits (2)

  • b651bb2 fix padding and hover highlight in tabs
  • cb47814 Fix workspace settings max height

📊 Changes

3 files changed (+12 additions, -12 deletions)

View changed files

📝 src-web/commands/openWorkspaceSettings.tsx (+1 -1)
📝 src-web/components/Settings/Settings.tsx (+6 -6)
📝 src-web/components/core/Tabs/Tabs.tsx (+5 -5)

📄 Description

Fix this issue by increasing top padding in vertial tab header to prevent border ring be overlaped.

image

Also, add hocus:bg-surface-highlight class to tab which has addBorders to make the hover style same as dropdown menu.

https://github.com/user-attachments/assets/3aed6ec1-345f-4478-87f8-61a49e76b677

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/243 **Author:** [@subframe7536](https://github.com/subframe7536) **Created:** 7/19/2025 **Status:** ✅ Merged **Merged:** 7/19/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `fix-vertical-tab-padding` --- ### 📝 Commits (2) - [`b651bb2`](https://github.com/mountain-loop/yaak/commit/b651bb2320f62a507911cb6601431eb84d7d7337) fix padding and hover highlight in tabs - [`cb47814`](https://github.com/mountain-loop/yaak/commit/cb47814c0eb3934529d96a9df13135f056f36f9c) Fix workspace settings max height ### 📊 Changes **3 files changed** (+12 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src-web/commands/openWorkspaceSettings.tsx` (+1 -1) 📝 `src-web/components/Settings/Settings.tsx` (+6 -6) 📝 `src-web/components/core/Tabs/Tabs.tsx` (+5 -5) </details> ### 📄 Description Fix this issue by increasing top padding in vertial tab header to prevent border ring be overlaped. <img width="616" height="476" alt="image" src="https://github.com/user-attachments/assets/a381e799-ae3d-416e-9ae5-f29e37cb4d3b" /> Also, add `hocus:bg-surface-highlight` class to tab which has `addBorders` to make the hover style same as dropdown menu. https://github.com/user-attachments/assets/3aed6ec1-345f-4478-87f8-61a49e76b677 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:38 +01:00
adam closed this issue 2025-12-29 07:19:38 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#168
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?