starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #224] [MERGED] Remove sqlx for migrations #149

New Issue
Closed
opened 2025-12-29 07:19:33 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/224
Author: @gschier
Created: 6/3/2025
Status: ✅ Merged
Merged: 6/3/2025
Merged by: @gschier

Base: master ← Head: remove-sqlx-migrate

📝 Commits (5)

📊 Changes

8 files changed (+186 additions, -538 deletions)

View changed files

📝 DEVELOPMENT.md (+1 -2)
📝 package.json (+1 -0)
➕ scripts/create-migration.cjs (+46 -0)
📝 src-tauri/Cargo.lock (+7 -500)
📝 src-tauri/migrations/20250424152740_remove-fks.sql (+0 -2)
📝 src-tauri/yaak-models/Cargo.toml (+2 -1)
📝 src-tauri/yaak-models/src/lib.rs (+5 -33)
➕ src-tauri/yaak-models/src/migrate.rs (+124 -0)

📄 Description

sqlx is no longer used for Yaak, except to run migrations. This caused an issue because it doesn't allow ignoring migration file checksums and there was an older migration that was causing issues.

This PR creates a custom migration runner that doesn't look at checksums, but is compatible with the sqlx migration table format.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/224 **Author:** [@gschier](https://github.com/gschier) **Created:** 6/3/2025 **Status:** ✅ Merged **Merged:** 6/3/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `remove-sqlx-migrate` --- ### 📝 Commits (5) - [`b008c06`](https://github.com/mountain-loop/yaak/commit/b008c060c406191b92e93b0363552445c215f675) Replace sqlx for migrations with custom - [`a5c0f3b`](https://github.com/mountain-loop/yaak/commit/a5c0f3bda1694f0a21b85182f1f8de51454a0df7) Fix old migration - [`b4a37b8`](https://github.com/mountain-loop/yaak/commit/b4a37b8c2a52756135dadc332b89fcb69169e845) Add migration script to create migration - [`1fac56e`](https://github.com/mountain-loop/yaak/commit/1fac56eb26ec39f931c72b830f4328297f4a7a14) Address PR feedback - [`098a460`](https://github.com/mountain-loop/yaak/commit/098a460fcdef1980a7fda9dcacd0b433afbc5f36) Add comment ### 📊 Changes **8 files changed** (+186 additions, -538 deletions) <details> <summary>View changed files</summary> 📝 `DEVELOPMENT.md` (+1 -2) 📝 `package.json` (+1 -0) ➕ `scripts/create-migration.cjs` (+46 -0) 📝 `src-tauri/Cargo.lock` (+7 -500) 📝 `src-tauri/migrations/20250424152740_remove-fks.sql` (+0 -2) 📝 `src-tauri/yaak-models/Cargo.toml` (+2 -1) 📝 `src-tauri/yaak-models/src/lib.rs` (+5 -33) ➕ `src-tauri/yaak-models/src/migrate.rs` (+124 -0) </details> ### 📄 Description `sqlx` is no longer used for Yaak, except to run migrations. This caused an issue because it doesn't allow ignoring migration file checksums and there was an older migration that was causing issues. This PR creates a custom migration runner that doesn't look at checksums, but is compatible with the sqlx migration table format. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:33 +01:00
adam closed this issue 2025-12-29 07:19:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#149
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?