starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-13 20:53:30 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #223] [MERGED] fix: send id_token in OAuth2 requests #148

New Issue
Closed
opened 2025-12-29 07:19:33 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:33 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/223
Author: @jpts
Created: 6/2/2025
Status: ✅ Merged
Merged: 6/3/2025
Merged by: @gschier

Base: master ← Head: fix-oauth2-id-token

📝 Commits (1)

  • 9ca3494 fix: send id_token in OAuth2 requests

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 plugins/auth-oauth2/src/index.ts (+4 -3)

📄 Description

The recent commit to support id_tokens via OAuth2 Authorization code flow has a bug where the access_token is still being sent.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/223 **Author:** [@jpts](https://github.com/jpts) **Created:** 6/2/2025 **Status:** ✅ Merged **Merged:** 6/3/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `fix-oauth2-id-token` --- ### 📝 Commits (1) - [`9ca3494`](https://github.com/mountain-loop/yaak/commit/9ca34944fa7afcc84d7ae91b5028dad22917a478) fix: send id_token in OAuth2 requests ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `plugins/auth-oauth2/src/index.ts` (+4 -3) </details> ### 📄 Description The [recent commit](https://github.com/mountain-loop/yaak/commit/b52570bf584c7b48c249aa80f8c3f4dd20260b4f) to support id_tokens via OAuth2 Authorization code flow has a bug where the `access_token` is still being sent. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:33 +01:00
adam closed this issue 2025-12-29 07:19:33 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#148
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?