[PR #218] [MERGED] Fix "Validate TLS Certificates" option for WS and GRPC #144

New Issue

adam · 2025-12-29T07:19:32+01:00

adam commented

2025-12-29 07:19:32 +01:00

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/218
Author: @null-dev
Created: 5/29/2025
Status: ✅ Merged
Merged: 5/29/2025
Merged by: @gschier

Base: master ← Head: nd/cert-validation-fix

📝 Commits (1)

5f93adc Fix "Validate TLS Certificates" option for WS and GRPC

📊 Changes

17 files changed (+124 additions, -66 deletions)

View changed files

📝 package-lock.json (+1 -1)
📝 src-tauri/Cargo.lock (+3 -6)
📝 src-tauri/Cargo.toml (+2 -2)
📝 src-tauri/src/http_request.rs (+2 -19)
📝 src-tauri/src/lib.rs (+6 -2)
📝 src-tauri/yaak-grpc/Cargo.toml (+1 -2)
📝 src-tauri/yaak-grpc/src/client.rs (+3 -3)
📝 src-tauri/yaak-grpc/src/manager.rs (+7 -4)
📝 src-tauri/yaak-grpc/src/reflection.rs (+2 -1)
📝 src-tauri/yaak-grpc/src/transport.rs (+3 -12)
📝 src-tauri/yaak-http/Cargo.toml (+2 -0)
📝 src-tauri/yaak-http/src/lib.rs (+2 -0)
➕ src-tauri/yaak-http/src/tls.rs (+77 -0)
📝 src-tauri/yaak-ws/Cargo.toml (+0 -2)
📝 src-tauri/yaak-ws/src/commands.rs (+8 -1)
📝 src-tauri/yaak-ws/src/connect.rs (+3 -10)
📝 src-tauri/yaak-ws/src/manager.rs (+2 -1)

📄 Description

fix: GRPC requests enforce TLS certificate validation even when "Validate TLS Certificates" is unchecked [bug report]
fix: Websocket connections enforce TLS certificate validation even when "Validate TLS Certificates" is unchecked [bug report]
unify HTTPS, GRPC, and Websocket TLS setup logic

Feel to close this PR if you'd rather fix/architect this a different way.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/218 **Author:** [@null-dev](https://github.com/null-dev) **Created:** 5/29/2025 **Status:** ✅ Merged **Merged:** 5/29/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `nd/cert-validation-fix` --- ### 📝 Commits (1) - [`5f93adc`](https://github.com/mountain-loop/yaak/commit/5f93adcaaa34bddeac7443ddc3ef9e173460a599) Fix "Validate TLS Certificates" option for WS and GRPC ### 📊 Changes **17 files changed** (+124 additions, -66 deletions) <details> <summary>View changed files</summary> 📝 `package-lock.json` (+1 -1) 📝 `src-tauri/Cargo.lock` (+3 -6) 📝 `src-tauri/Cargo.toml` (+2 -2) 📝 `src-tauri/src/http_request.rs` (+2 -19) 📝 `src-tauri/src/lib.rs` (+6 -2) 📝 `src-tauri/yaak-grpc/Cargo.toml` (+1 -2) 📝 `src-tauri/yaak-grpc/src/client.rs` (+3 -3) 📝 `src-tauri/yaak-grpc/src/manager.rs` (+7 -4) 📝 `src-tauri/yaak-grpc/src/reflection.rs` (+2 -1) 📝 `src-tauri/yaak-grpc/src/transport.rs` (+3 -12) 📝 `src-tauri/yaak-http/Cargo.toml` (+2 -0) 📝 `src-tauri/yaak-http/src/lib.rs` (+2 -0) ➕ `src-tauri/yaak-http/src/tls.rs` (+77 -0) 📝 `src-tauri/yaak-ws/Cargo.toml` (+0 -2) 📝 `src-tauri/yaak-ws/src/commands.rs` (+8 -1) 📝 `src-tauri/yaak-ws/src/connect.rs` (+3 -10) 📝 `src-tauri/yaak-ws/src/manager.rs` (+2 -1) </details> ### 📄 Description - fix: GRPC requests enforce TLS certificate validation even when "Validate TLS Certificates" is unchecked [[bug report](https://feedback.yaak.app/p/disabling-tls-validation-in-settings-does-not-affect-grpc)] - fix: Websocket connections enforce TLS certificate validation even when "Validate TLS Certificates" is unchecked [[bug report](https://feedback.yaak.app/p/validate-tls-certificates-setting-not-respected-for-websocket-connections)] - unify HTTPS, GRPC, and Websocket TLS setup logic Feel to close this PR if you'd rather fix/architect this a different way. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 07:19:32 +01:00

adam closed this issue

2025-12-29 07:19:32 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/yaak#144