starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #194] [MERGED] fix proto to json-schema #119

New Issue
Closed
opened 2025-12-29 07:19:25 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:25 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/194
Author: @hxzhao527
Created: 3/27/2025
Status: ✅ Merged
Merged: 5/16/2025
Merged by: @gschier

Base: master ← Head: fix/grpc_cycle_def

📝 Commits (1)

📊 Changes

1 file changed (+351 additions, -124 deletions)

View changed files

📝 src-tauri/yaak-grpc/src/json_schema.rs (+351 -124)

📄 Description

for Crash when parsing gRPC schemas

I think it should work. I have test the schema generated with demo provided by codemirror-json-schema.

but the autocomplete doesn't work in yaak. (it works in codemirror-json-schema demo).

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/194 **Author:** [@hxzhao527](https://github.com/hxzhao527) **Created:** 3/27/2025 **Status:** ✅ Merged **Merged:** 5/16/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `fix/grpc_cycle_def` --- ### 📝 Commits (1) - [`a27e3ee`](https://github.com/mountain-loop/yaak/commit/a27e3ee0a8ff52b232fd690a01c2780eb3989190) fix proto to json-schema ### 📊 Changes **1 file changed** (+351 additions, -124 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/yaak-grpc/src/json_schema.rs` (+351 -124) </details> ### 📄 Description for [Crash when parsing gRPC schemas](https://feedback.yaak.app/p/crash-when-parsing-grpc-schemas) I think it should work. I have test the schema generated with demo provided by [codemirror-json-schema](https://github.com/jsonnext/codemirror-json-schema). but the autocomplete doesn't work in yaak. (it works in codemirror-json-schema demo). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:25 +01:00
adam closed this issue 2025-12-29 07:19:25 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#119
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?