starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #188] [MERGED] Fix labels in GRPC service/method selector dropdown #113

New Issue
Closed
opened 2025-12-29 07:19:23 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:23 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/188
Author: @null-dev
Created: 3/20/2025
Status: ✅ Merged
Merged: 3/20/2025
Merged by: @gschier

Base: master ← Head: patch-1

📝 Commits (1)

  • 7b7a297 Fix labels in GRPC service/method selector dropdown

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src-web/components/GrpcConnectionSetupPane.tsx (+1 -1)

📄 Description

Comparison using the connectrpc.eliza.v1.ElizaService service @ https://demo.connectrpc.com:443:

Before:

before

After:

after

Note that other places in the code already use the correct logic, for example: 6aea343d4f/src-web/lib/resolvedModelName.ts (L29-L30)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/188 **Author:** [@null-dev](https://github.com/null-dev) **Created:** 3/20/2025 **Status:** ✅ Merged **Merged:** 3/20/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`7b7a297`](https://github.com/mountain-loop/yaak/commit/7b7a297b89ed16b4f4c0f4ec6d92906e6792f298) Fix labels in GRPC service/method selector dropdown ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/GrpcConnectionSetupPane.tsx` (+1 -1) </details> ### 📄 Description Comparison using the `connectrpc.eliza.v1.ElizaService` service @ https://demo.connectrpc.com:443: Before: <img width="877" alt="before" src="https://github.com/user-attachments/assets/da037871-0306-4136-adcf-0638100519b6" /> After: <img width="877" alt="after" src="https://github.com/user-attachments/assets/a26f6f05-7d6b-432f-8949-54d2d3da80ab" /> Note that other places in the code already use the correct logic, for example: https://github.com/mountain-loop/yaak/blob/6aea343d4f5985de912b94220e6bc2cfcd4c5152/src-web/lib/resolvedModelName.ts#L29-L30 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:23 +01:00
adam closed this issue 2025-12-29 07:19:23 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#113
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?