starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-13 20:53:30 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #179] [MERGED] Fix wrong protoc includes path #103

New Issue
Closed
opened 2025-12-29 07:19:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/179
Author: @null-dev
Created: 3/5/2025
Status: ✅ Merged
Merged: 3/6/2025
Merged by: @gschier

Base: master ← Head: patch-1

📝 Commits (2)

  • a4c1bad Fix wrong protoc includes path
  • 1c75eaa Whoops, typoed the correct path...

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src-tauri/yaak-grpc/src/reflection.rs (+1 -1)

📄 Description

The path specified in the build script is different than the path referenced in the code: 7a1a0689b0/scripts/vendor-protoc.cjs (L36)

Loving your work on yaak BTW!

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/179 **Author:** [@null-dev](https://github.com/null-dev) **Created:** 3/5/2025 **Status:** ✅ Merged **Merged:** 3/6/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`a4c1bad`](https://github.com/mountain-loop/yaak/commit/a4c1bada09758e6b3d51fe509b968b7aa7293b58) Fix wrong protoc includes path - [`1c75eaa`](https://github.com/mountain-loop/yaak/commit/1c75eaadb03357cac1642c0307b49b84a1ff0b8d) Whoops, typoed the correct path... ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/yaak-grpc/src/reflection.rs` (+1 -1) </details> ### 📄 Description The path specified in the build script is different than the path referenced in the code: https://github.com/mountain-loop/yaak/blob/7a1a0689b03d127dc36bc5cd4694d8a2fcfac5bc/scripts/vendor-protoc.cjs#L36 Loving your work on yaak BTW! --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:21 +01:00
adam closed this issue 2025-12-29 07:19:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#103
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?