starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 20:00:29 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #176] [MERGED] Allow disabling window decorations/controls #101

New Issue
Closed
opened 2025-12-29 07:19:21 +01:00 by adam · 0 comments
adam commented 2025-12-29 07:19:21 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/176
Author: @AlphaNecron
Created: 3/2/2025
Status: ✅ Merged
Merged: 5/16/2025
Merged by: @gschier

Base: master ← Head: master

📝 Commits (7)

  • a8c1951 Allow disabling window decorations/controls
  • 1d8016a Adjust headerbar padding when not using window controls
  • 9817f8a Set padding-left of headerbar to 2px
  • 2a21087 Merge branch 'master' into master
  • 8a45408 Merge branch 'master' into fork/AlphaNecron/master
  • f88f623 Cleanup for merge
  • 18d10a2 Only show setting for non-mac OS

📊 Changes

17 files changed (+75 additions, -58 deletions)

View changed files

➕ src-tauri/migrations/20250302041707_hide-window-controls.sql (+2 -0)
📝 src-tauri/yaak-models/bindings/gen_models.ts (+1 -1)
📝 src-tauri/yaak-models/bindings/gen_util.ts (+6 -6)
📝 src-tauri/yaak-models/src/models.rs (+4 -0)
📝 src-tauri/yaak-models/src/queries/settings.rs (+1 -0)
📝 src-web/components/HeaderSize.tsx (+30 -16)
📝 src-web/components/Settings/Settings.tsx (+2 -5)
📝 src-web/components/Settings/SettingsAppearance.tsx (+10 -0)
📝 src-web/components/WindowControls.tsx (+7 -6)
📝 src-web/components/core/Checkbox.tsx (+2 -2)
📝 src-web/components/core/HotKey.tsx (+1 -3)
📝 src-web/components/core/Select.tsx (+2 -3)
📝 src-web/hooks/useHotKey.ts (+2 -4)
➖ src-web/hooks/useOsInfo.ts (+0 -5)
📝 src-web/hooks/useStoplightsVisible.ts (+2 -3)
📝 src-web/lib/constants.ts (+1 -1)
📝 src-web/routes/__root.tsx (+2 -3)

📄 Description

This PR allows disabling window controls, mainly for WMs like Hyprland, which don't need these controls.

With controls

image
image

Without controls

image

This option shouldn't be used in conjunction with MacOS.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/176 **Author:** [@AlphaNecron](https://github.com/AlphaNecron) **Created:** 3/2/2025 **Status:** ✅ Merged **Merged:** 5/16/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (7) - [`a8c1951`](https://github.com/mountain-loop/yaak/commit/a8c195147dd32d25283ec05914f792753fc4cc64) Allow disabling window decorations/controls - [`1d8016a`](https://github.com/mountain-loop/yaak/commit/1d8016add68f0fa37e7bbb8e94ec08db0197a852) Adjust headerbar padding when not using window controls - [`9817f8a`](https://github.com/mountain-loop/yaak/commit/9817f8a090794b5f5db4033763d75b82a4f65143) Set padding-left of headerbar to 2px - [`2a21087`](https://github.com/mountain-loop/yaak/commit/2a2108763d9db67196f23eee3e4d5f534ad82742) Merge branch 'master' into master - [`8a45408`](https://github.com/mountain-loop/yaak/commit/8a45408fc91de0986045d9465650581591d17b01) Merge branch 'master' into fork/AlphaNecron/master - [`f88f623`](https://github.com/mountain-loop/yaak/commit/f88f6237bb97c4fc3bf0066769a2d6e5535f093a) Cleanup for merge - [`18d10a2`](https://github.com/mountain-loop/yaak/commit/18d10a2d912007373c65c35d1a4ca6b737537a92) Only show setting for non-mac OS ### 📊 Changes **17 files changed** (+75 additions, -58 deletions) <details> <summary>View changed files</summary> ➕ `src-tauri/migrations/20250302041707_hide-window-controls.sql` (+2 -0) 📝 `src-tauri/yaak-models/bindings/gen_models.ts` (+1 -1) 📝 `src-tauri/yaak-models/bindings/gen_util.ts` (+6 -6) 📝 `src-tauri/yaak-models/src/models.rs` (+4 -0) 📝 `src-tauri/yaak-models/src/queries/settings.rs` (+1 -0) 📝 `src-web/components/HeaderSize.tsx` (+30 -16) 📝 `src-web/components/Settings/Settings.tsx` (+2 -5) 📝 `src-web/components/Settings/SettingsAppearance.tsx` (+10 -0) 📝 `src-web/components/WindowControls.tsx` (+7 -6) 📝 `src-web/components/core/Checkbox.tsx` (+2 -2) 📝 `src-web/components/core/HotKey.tsx` (+1 -3) 📝 `src-web/components/core/Select.tsx` (+2 -3) 📝 `src-web/hooks/useHotKey.ts` (+2 -4) ➖ `src-web/hooks/useOsInfo.ts` (+0 -5) 📝 `src-web/hooks/useStoplightsVisible.ts` (+2 -3) 📝 `src-web/lib/constants.ts` (+1 -1) 📝 `src-web/routes/__root.tsx` (+2 -3) </details> ### 📄 Description This PR allows disabling window controls, mainly for WMs like Hyprland, which don't need these controls. ### With controls ![image](https://github.com/user-attachments/assets/50a4f318-439c-4488-8978-504ce26b64a0) ![image](https://github.com/user-attachments/assets/9860828e-053e-4326-87d8-945849271cf0) ### Without controls ![image](https://github.com/user-attachments/assets/35b2955e-ecd0-4e95-8bda-0920080b63df) > This option shouldn't be used in conjunction with MacOS. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 07:19:21 +01:00
adam closed this issue 2025-12-29 07:19:21 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak#101
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?