[PR #175] [MERGED] fix ws connection state #100

New Issue

adam · 2025-12-29T07:19:20+01:00

adam commented

2025-12-29 07:19:20 +01:00

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/175
Author: @hxzhao527
Created: 2/28/2025
Status: ✅ Merged
Merged: 3/8/2025
Merged by: @gschier

Base: master ← Head: fix/ws_state

📝 Commits (4)

8fab22e fix ws connection state
dba715c Merge branch 'master' into fork/hxzhao527/fix/ws_state
dde1367 Get PR ready to merge
9cd7102 Preserve HTTP status for errors

📊 Changes

17 files changed (+260 additions, -184 deletions)

View changed files

📝 src-tauri/src/lib.rs (+19 -16)
📝 src-tauri/yaak-models/bindings/gen_models.ts (+2 -2)
📝 src-tauri/yaak-models/src/models.rs (+2 -0)
📝 src-tauri/yaak-models/src/queries.rs (+19 -4)
📝 src-tauri/yaak-plugins/src/manager.rs (+2 -1)
📝 src-tauri/yaak-ws/src/commands.rs (+92 -66)
📝 src-tauri/yaak-ws/src/connect.rs (+1 -37)
📝 src-tauri/yaak-ws/src/lib.rs (+1 -2)
📝 src-tauri/yaak-ws/src/manager.rs (+27 -8)
📝 src-web/components/GrpcConnectionMessagesPane.tsx (+1 -1)
📝 src-web/components/HttpResponsePane.tsx (+2 -2)
📝 src-web/components/RecentHttpResponsesDropdown.tsx (+2 -2)
📝 src-web/components/WebsocketResponsePane.tsx (+17 -7)
➕ src-web/components/core/HttpStatusTag.tsx (+40 -0)
➖ src-web/components/core/StatusTag.tsx (+0 -34)
➕ src-web/components/core/WebsocketStatusTag.tsx (+31 -0)
📝 src-web/components/sidebar/SidebarItem.tsx (+2 -2)

📄 Description

for Websocket close message doesn't close client side

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/175 **Author:** [@hxzhao527](https://github.com/hxzhao527) **Created:** 2/28/2025 **Status:** ✅ Merged **Merged:** 3/8/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `fix/ws_state` --- ### 📝 Commits (4) - [`8fab22e`](https://github.com/mountain-loop/yaak/commit/8fab22e225ed632ea8917e1dad083159beb55140) fix ws connection state - [`dba715c`](https://github.com/mountain-loop/yaak/commit/dba715c257a88d935dcfd3ce72aefab866f0d398) Merge branch 'master' into fork/hxzhao527/fix/ws_state - [`dde1367`](https://github.com/mountain-loop/yaak/commit/dde1367a76e98491453c09a8fc2fb28ee0e51869) Get PR ready to merge - [`9cd7102`](https://github.com/mountain-loop/yaak/commit/9cd71022198fa8fe58ed3d4129da9bbcf4f63cd9) Preserve HTTP status for errors ### 📊 Changes **17 files changed** (+260 additions, -184 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/src/lib.rs` (+19 -16) 📝 `src-tauri/yaak-models/bindings/gen_models.ts` (+2 -2) 📝 `src-tauri/yaak-models/src/models.rs` (+2 -0) 📝 `src-tauri/yaak-models/src/queries.rs` (+19 -4) 📝 `src-tauri/yaak-plugins/src/manager.rs` (+2 -1) 📝 `src-tauri/yaak-ws/src/commands.rs` (+92 -66) 📝 `src-tauri/yaak-ws/src/connect.rs` (+1 -37) 📝 `src-tauri/yaak-ws/src/lib.rs` (+1 -2) 📝 `src-tauri/yaak-ws/src/manager.rs` (+27 -8) 📝 `src-web/components/GrpcConnectionMessagesPane.tsx` (+1 -1) 📝 `src-web/components/HttpResponsePane.tsx` (+2 -2) 📝 `src-web/components/RecentHttpResponsesDropdown.tsx` (+2 -2) 📝 `src-web/components/WebsocketResponsePane.tsx` (+17 -7) ➕ `src-web/components/core/HttpStatusTag.tsx` (+40 -0) ➖ `src-web/components/core/StatusTag.tsx` (+0 -34) ➕ `src-web/components/core/WebsocketStatusTag.tsx` (+31 -0) 📝 `src-web/components/sidebar/SidebarItem.tsx` (+2 -2) </details> ### 📄 Description for [Websocket close message doesn't close client side](https://feedback.yaak.app/p/websocket-close-message-doesnt-close-client-side) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-29 07:19:20 +01:00

adam closed this issue

2025-12-29 07:19:20 +01:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/yaak#100