From 65b7db873ea9fa950015980d11f811918e075c2b Mon Sep 17 00:00:00 2001 From: Michal Polko Date: Thu, 12 Sep 2024 07:26:03 +0200 Subject: [PATCH 01/13] Use padding for Basic auth (#77) --- src-tauri/src/http_request.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src-tauri/src/http_request.rs b/src-tauri/src/http_request.rs index 0d3635ef..dd1d53d3 100644 --- a/src-tauri/src/http_request.rs +++ b/src-tauri/src/http_request.rs @@ -204,7 +204,7 @@ pub async fn send_http_request( .unwrap_or_default(); let auth = format!("{username}:{password}"); - let encoded = base64::engine::general_purpose::STANDARD_NO_PAD.encode(auth); + let encoded = base64::engine::general_purpose::STANDARD.encode(auth); headers.insert( "Authorization", HeaderValue::from_str(&format!("Basic {}", encoded)).unwrap(), From a805e39da9ed23cb1f332f873ea4ebf7a1dd7a49 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 06:51:46 -0700 Subject: [PATCH 02/13] Update issue templates --- .../ISSUE_TEMPLATE/question--feature-request--etc-.md | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/question--feature-request--etc-.md diff --git a/.github/ISSUE_TEMPLATE/question--feature-request--etc-.md b/.github/ISSUE_TEMPLATE/question--feature-request--etc-.md new file mode 100644 index 00000000..712e6558 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/question--feature-request--etc-.md @@ -0,0 +1,10 @@ +--- +name: Question, Feature Request, Etc. +about: Please report all other issues to the Feedback Board +title: '' +labels: '' +assignees: '' + +--- + +https://feedback.yaak.app From a0c7090fda73fa9fcf30433f058d7ee2a9e22de9 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 06:53:41 -0700 Subject: [PATCH 03/13] Create config.yaml --- .github/ISSUE_TEMPLATE/config.yaml | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/config.yaml diff --git a/.github/ISSUE_TEMPLATE/config.yaml b/.github/ISSUE_TEMPLATE/config.yaml new file mode 100644 index 00000000..34beaf42 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/config.yaml @@ -0,0 +1,5 @@ +blank_issues_enabled: false +contact_links: + - name: Public Feedback Board + url: https://feedback.yaak.app + about: Suggest features, ask questions, etc. From b08750a72bd6568c7e0ec1a0283e22eb88edc620 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 06:54:19 -0700 Subject: [PATCH 04/13] Rename config.yaml to config.yml --- .github/ISSUE_TEMPLATE/{config.yaml => config.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/ISSUE_TEMPLATE/{config.yaml => config.yml} (100%) diff --git a/.github/ISSUE_TEMPLATE/config.yaml b/.github/ISSUE_TEMPLATE/config.yml similarity index 100% rename from .github/ISSUE_TEMPLATE/config.yaml rename to .github/ISSUE_TEMPLATE/config.yml From aeecac7ded81f24dfd6153f0cf971df36b6ba728 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 06:58:52 -0700 Subject: [PATCH 05/13] Issue Template --- .github/ISSUE_TEMPLATE/bug-report.md | 21 +++++++++++++++++++ .../question--feature-request--etc-.md | 10 --------- 2 files changed, 21 insertions(+), 10 deletions(-) create mode 100644 .github/ISSUE_TEMPLATE/bug-report.md delete mode 100644 .github/ISSUE_TEMPLATE/question--feature-request--etc-.md diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md new file mode 100644 index 00000000..be9cf40a --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-report.md @@ -0,0 +1,21 @@ +## Describe the bug +A clear and concise description of what the bug is. + +## To Reproduce +1. I did a thing +2. I did another thing +3. Then the thing happened + +## Expected behavior +A description of what you expected to happen. + +## Screenshots/Video +If applicable, add screenshots/video to help explain your problem. +Remember to mark the area in the application thats impacted. + +## App Info + - OS: [e.g. iOS] + - Version [e.g. 2024.8.0] + +## Additional context +Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/question--feature-request--etc-.md b/.github/ISSUE_TEMPLATE/question--feature-request--etc-.md deleted file mode 100644 index 712e6558..00000000 --- a/.github/ISSUE_TEMPLATE/question--feature-request--etc-.md +++ /dev/null @@ -1,10 +0,0 @@ ---- -name: Question, Feature Request, Etc. -about: Please report all other issues to the Feedback Board -title: '' -labels: '' -assignees: '' - ---- - -https://feedback.yaak.app From 77153525fb46683ef8c8db79dbe495f8067b7fa3 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 07:04:40 -0700 Subject: [PATCH 06/13] Update and rename bug-report.md to bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.md | 21 ------------- .github/ISSUE_TEMPLATE/bug-report.yml | 43 +++++++++++++++++++++++++++ 2 files changed, 43 insertions(+), 21 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/bug-report.md create mode 100644 .github/ISSUE_TEMPLATE/bug-report.yml diff --git a/.github/ISSUE_TEMPLATE/bug-report.md b/.github/ISSUE_TEMPLATE/bug-report.md deleted file mode 100644 index be9cf40a..00000000 --- a/.github/ISSUE_TEMPLATE/bug-report.md +++ /dev/null @@ -1,21 +0,0 @@ -## Describe the bug -A clear and concise description of what the bug is. - -## To Reproduce -1. I did a thing -2. I did another thing -3. Then the thing happened - -## Expected behavior -A description of what you expected to happen. - -## Screenshots/Video -If applicable, add screenshots/video to help explain your problem. -Remember to mark the area in the application thats impacted. - -## App Info - - OS: [e.g. iOS] - - Version [e.g. 2024.8.0] - -## Additional context -Add any other context about the problem here. diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml new file mode 100644 index 00000000..57367a12 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -0,0 +1,43 @@ +name: Bug Report +description: File a bug report. +title: "[Bug]: " +labels: ["bug", "triage"] +assignees: + - gschier +body: + - type: markdown + attributes: + value: | + Thanks for taking the time to fill out this bug report! + - type: textarea + id: what-happened + attributes: + label: What happened? + description: Also tell us, what did you expect to happen? + placeholder: Tell us what you see! + value: "A bug happened!" + validations: + required: true + - type: input + id: version + attributes: + label: Version + description: What version of our software are you running? + placeholder: 2024.8.0 + validations: + required: true + - type: dropdown + id: os + attributes: + label: What operating system are you on? + multiple: false + options: + - macOS + - Windows + - Linux + - type: textarea + id: logs + attributes: + label: Relevant log output + description: Please copy and paste any relevant log output. This will be automatically formatted into code, so no need for backticks. + render: shell From aab0386565e1d7a36c1126240ddded37f1aae1e3 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 07:06:03 -0700 Subject: [PATCH 07/13] Require OS in bug report --- .github/ISSUE_TEMPLATE/bug-report.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 57367a12..cb17426a 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -35,6 +35,8 @@ body: - macOS - Windows - Linux + validations: + required: true - type: textarea id: logs attributes: From 31dc76727ac8245dacf519a47475b6bba022ef96 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 07:08:29 -0700 Subject: [PATCH 08/13] Update config.yml --- .github/ISSUE_TEMPLATE/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 34beaf42..9ebe6ef4 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,5 +1,5 @@ blank_issues_enabled: false contact_links: - - name: Public Feedback Board + - name: Feature Requests, Questions, etc. url: https://feedback.yaak.app - about: Suggest features, ask questions, etc. + about: Please report everything else to the public feedback board From 9900b0979322b1232c8352fe4e9c558bb8baa02f Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 07:09:47 -0700 Subject: [PATCH 09/13] Update config.yml --- .github/ISSUE_TEMPLATE/config.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 9ebe6ef4..52ebf67f 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -2,4 +2,4 @@ blank_issues_enabled: false contact_links: - name: Feature Requests, Questions, etc. url: https://feedback.yaak.app - about: Please report everything else to the public feedback board + about: Report everything else to the feedback board 👉🏼 From b8fdf7ec941523f323503af73c04476c2def4430 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 07:11:02 -0700 Subject: [PATCH 10/13] Update bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index cb17426a..6e7d915b 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -1,5 +1,5 @@ name: Bug Report -description: File a bug report. +description: "Something isn't working properly in Yaak" title: "[Bug]: " labels: ["bug", "triage"] assignees: @@ -8,7 +8,7 @@ body: - type: markdown attributes: value: | - Thanks for taking the time to fill out this bug report! + Thanks for taking the time to fill out this bug report 🤗 - type: textarea id: what-happened attributes: From aeb550034d43ee3459a936f0f7dac09fdb40f711 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 07:11:28 -0700 Subject: [PATCH 11/13] Update config.yml --- .github/ISSUE_TEMPLATE/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml index 52ebf67f..951592e3 100644 --- a/.github/ISSUE_TEMPLATE/config.yml +++ b/.github/ISSUE_TEMPLATE/config.yml @@ -1,5 +1,5 @@ blank_issues_enabled: false contact_links: - - name: Feature Requests, Questions, etc. + - name: Feature Request, Question, etc. url: https://feedback.yaak.app - about: Report everything else to the feedback board 👉🏼 + about: Report all non-bugs to the feedback board 👉🏼 From 3d74d29775ecd5b5c138cb0fef30083165fab78b Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 07:16:50 -0700 Subject: [PATCH 12/13] Update bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 6e7d915b..080a7fba 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -1,7 +1,7 @@ name: Bug Report description: "Something isn't working properly in Yaak" title: "[Bug]: " -labels: ["bug", "triage"] +labels: ["bug", "needs triage"] assignees: - gschier body: From f0f629f26fec673742b20ebabb96c32e1dca8754 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Thu, 12 Sep 2024 07:17:45 -0700 Subject: [PATCH 13/13] Update bug-report.yml --- .github/ISSUE_TEMPLATE/bug-report.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/bug-report.yml b/.github/ISSUE_TEMPLATE/bug-report.yml index 080a7fba..77c70da7 100644 --- a/.github/ISSUE_TEMPLATE/bug-report.yml +++ b/.github/ISSUE_TEMPLATE/bug-report.yml @@ -1,6 +1,6 @@ name: Bug Report description: "Something isn't working properly in Yaak" -title: "[Bug]: " +title: "" labels: ["bug", "needs triage"] assignees: - gschier