Prevent auth from adding lone ? to URL

https://feedback.yaak.app/p/using-inherited-api-key-causes-a-question-mark-to-be
This commit is contained in:
Gregory Schier
2025-07-23 17:20:17 -07:00
parent 1b90842d30
commit a258a80fbd
2 changed files with 10 additions and 7 deletions
+3 -2
View File
@@ -488,13 +488,14 @@ pub async fn send_http_request<R: Runtime>(
}; };
} }
if let Some(params) = plugin_result.set_query_parameters {
let mut query_pairs = sendable_req.url_mut().query_pairs_mut(); let mut query_pairs = sendable_req.url_mut().query_pairs_mut();
for p in plugin_result.set_query_parameters.unwrap_or_default() { for p in params {
println!("Adding query parameter: {:?}", p);
query_pairs.append_pair(&p.name, &p.value); query_pairs.append_pair(&p.name, &p.value);
} }
} }
} }
}
let (resp_tx, resp_rx) = oneshot::channel::<std::result::Result<Response, reqwest::Error>>(); let (resp_tx, resp_rx) = oneshot::channel::<std::result::Result<Response, reqwest::Error>>();
let (done_tx, done_rx) = oneshot::channel::<HttpResponse>(); let (done_tx, done_rx) = oneshot::channel::<HttpResponse>();
+3 -1
View File
@@ -294,12 +294,14 @@ pub(crate) async fn connect<R: Runtime>(
_ => continue, _ => continue,
}; };
} }
if let Some(params) = plugin_result.set_query_parameters {
let mut query_pairs = url.query_pairs_mut(); let mut query_pairs = url.query_pairs_mut();
for p in plugin_result.set_query_parameters.unwrap_or_default() { for p in params {
query_pairs.append_pair(&p.name, &p.value); query_pairs.append_pair(&p.name, &p.value);
} }
} }
} }
}
// Add cookies to WS HTTP Upgrade // Add cookies to WS HTTP Upgrade
if let Some(id) = cookie_jar_id { if let Some(id) = cookie_jar_id {