starred/yaak
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-03-23 18:01:21 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

Fix editor stale callbacks and recent item deletion

Browse Source
This commit is contained in:
Gregory Schier
2023-10-30 07:06:21 -07:00
parent 51949f4fbf
commit 8b5d7ae3ed
9 changed files with 45 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src-web/components/core/Dialog.tsx
View File

@@ -57,9 +57,10 @@ export function Dialog({
'relative bg-gray-50 pointer-events-auto',
'p-5 rounded-lg overflow-auto',
'dark:border border-highlight shadow shadow-black/10',
'max-w-[90vw] max-h-[calc(100vh-8em)]',
size === 'sm' && 'w-[25rem] max-h-[80vh]',
size === 'md' && 'w-[45rem] max-h-[80vh]',
size === 'full' && 'w-[95vw] h-[calc(100vh-6em)]',
size === 'full' && 'w-[100vw] h-[100vh]',
size === 'dynamic' && 'min-w-[30vw] max-w-[80vw]',
)}
>

7
src-web/components/core/Editor/Editor.tsx
View File

@@ -267,10 +267,11 @@ function getExtensions({
: []),
// Handle onFocus
// NOTE: These *must* be anonymous functions so the references update properly
EditorView.domEventHandlers({
focus: onFocus.current,
blur: onBlur.current,
keydown: onKeyDown.current,
focus: () => onFocus.current?.(),
blur: () => onBlur.current?.(),
keydown: e => onKeyDown.current?.(e),
}),
// Handle onChange

15
src-web/components/core/Input.tsx
View File

@@ -102,14 +102,17 @@ export const Input = forwardRef<EditorView | undefined, InputProps>(function Inp
const wrapperRef = useRef<HTMLDivElement>(null);
// Submit nearest form on Enter key press
const handleKeyDown = useCallback((e: KeyboardEvent) => {
if (e.key !== 'Enter') return;
const handleKeyDown = useCallback(
(e: KeyboardEvent) => {
if (e.key !== 'Enter') return;
const form = wrapperRef.current?.closest('form');
if (!isValid || form == null) return;
const form = wrapperRef.current?.closest('form');
if (!isValid || form == null) return;
form?.dispatchEvent(new Event('submit', { cancelable: true, bubbles: true }));
}, [isValid]);
form?.dispatchEvent(new Event('submit', { cancelable: true, bubbles: true }));
},
[isValid],
);
return (
<VStack ref={wrapperRef} className="w-full">