diff --git a/.claude/commands/release/check-out-pr.md b/.claude/commands/release/check-out-pr.md index 90a6b2d8..23e95e3e 100644 --- a/.claude/commands/release/check-out-pr.md +++ b/.claude/commands/release/check-out-pr.md @@ -1,35 +1,46 @@ --- description: Review a PR in a new worktree -allowed-tools: Bash(git worktree:*), Bash(gh pr:*) +allowed-tools: Bash(git worktree:*), Bash(gh pr:*), Bash(git branch:*) --- -Review a GitHub pull request in a new git worktree. +Check out a GitHub pull request for review. ## Usage ``` -/review-pr +/check-out-pr ``` ## What to do -1. List all open pull requests and ask the user to select one +1. If no PR number is provided, list all open pull requests and ask the user to select one 2. Get PR information using `gh pr view --json number,headRefName` -3. Extract the branch name from the PR -4. Create a new worktree at `../yaak-worktrees/pr-` using `git worktree add` with a timeout of at least 300000ms (5 minutes) since the post-checkout hook runs a bootstrap script -5. Checkout the PR branch in the new worktree using `gh pr checkout ` -6. The post-checkout hook will automatically: +3. **Ask the user** whether they want to: + - **A) Check out in current directory** — simple `gh pr checkout ` + - **B) Create a new worktree** — isolated copy at `../yaak-worktrees/pr-` +4. Follow the appropriate path below + +## Option A: Check out in current directory + +1. Run `gh pr checkout ` +2. Inform the user which branch they're now on + +## Option B: Create a new worktree + +1. Create a new worktree at `../yaak-worktrees/pr-` using `git worktree add` with a timeout of at least 300000ms (5 minutes) since the post-checkout hook runs a bootstrap script +2. Checkout the PR branch in the new worktree using `gh pr checkout ` +3. The post-checkout hook will automatically: - Create `.env.local` with unique ports - Copy editor config folders - Run `npm install && npm run bootstrap` -7. Inform the user: +4. Inform the user: - Where the worktree was created - What ports were assigned - How to access it (cd command) - How to run the dev server - How to remove the worktree when done -## Example Output +### Example worktree output ``` Created worktree for PR #123 at ../yaak-worktrees/pr-123 diff --git a/.claude/commands/release/generate-release-notes.md b/.claude/commands/release/generate-release-notes.md index 2ca790b5..6a42ea32 100644 --- a/.claude/commands/release/generate-release-notes.md +++ b/.claude/commands/release/generate-release-notes.md @@ -43,5 +43,7 @@ The skill generates markdown-formatted release notes following this structure: After outputting the release notes, ask the user if they would like to create a draft GitHub release with these notes. If they confirm, create the release using: ```bash -gh release create --draft --prerelease --title "" --notes '' +gh release create --draft --prerelease --title "Release " --notes '' ``` + +**IMPORTANT**: The release title format is "Release XXXX" where XXXX is the version WITHOUT the `v` prefix. For example, tag `v2026.2.1-beta.1` gets title "Release 2026.2.1-beta.1". diff --git a/.github/workflows/flathub.yml b/.github/workflows/flathub.yml new file mode 100644 index 00000000..c8c33f66 --- /dev/null +++ b/.github/workflows/flathub.yml @@ -0,0 +1,52 @@ +name: Update Flathub +on: + release: + types: [published] + +permissions: + contents: read + +jobs: + update-flathub: + name: Update Flathub manifest + runs-on: ubuntu-latest + # Only run for stable releases (skip betas/pre-releases) + if: ${{ !github.event.release.prerelease }} + steps: + - name: Checkout app repo + uses: actions/checkout@v4 + + - name: Checkout Flathub repo + uses: actions/checkout@v4 + with: + repository: flathub/app.yaak.Yaak + token: ${{ secrets.FLATHUB_TOKEN }} + path: flathub-repo + + - name: Set up Python + uses: actions/setup-python@v5 + with: + python-version: "3.12" + + - name: Set up Node.js + uses: actions/setup-node@v4 + with: + node-version: "22" + + - name: Install source generators + run: | + pip install flatpak-node-generator tomlkit aiohttp + git clone --depth 1 https://github.com/flatpak/flatpak-builder-tools flatpak/flatpak-builder-tools + + - name: Run update-manifest.sh + run: bash flatpak/update-manifest.sh "${{ github.event.release.tag_name }}" flathub-repo + + - name: Commit and push to Flathub + working-directory: flathub-repo + run: | + git config user.name "github-actions[bot]" + git config user.email "github-actions[bot]@users.noreply.github.com" + git add -A + git diff --cached --quiet && echo "No changes to commit" && exit 0 + git commit -m "Update to ${{ github.event.release.tag_name }}" + git push diff --git a/.gitignore b/.gitignore index e8922cf5..40c48bd8 100644 --- a/.gitignore +++ b/.gitignore @@ -44,3 +44,10 @@ crates-tauri/yaak-app/tauri.worktree.conf.json # Tauri auto-generated permission files **/permissions/autogenerated **/permissions/schemas + +# Flatpak build artifacts +flatpak-repo/ +.flatpak-builder/ +flatpak/flatpak-builder-tools/ +flatpak/cargo-sources.json +flatpak/node-sources.json diff --git a/Cargo.lock b/Cargo.lock index 6e0c8695..2666ac6f 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -52,6 +52,15 @@ dependencies = [ "zerocopy", ] +[[package]] +name = "aho-corasick" +version = "0.6.10" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "81ce3d38065e618af2d7b77e10c5ad9a069859b4be3c2250f674af3840d9c8a5" +dependencies = [ + "memchr", +] + [[package]] name = "aho-corasick" version = "1.1.3" @@ -90,7 +99,7 @@ checksum = "f6f39be698127218cca460cb624878c9aa4e2b47dba3b277963d2bf00bad263b" dependencies = [ "android_log-sys", "env_filter", - "log", + "log 0.4.29", ] [[package]] @@ -175,7 +184,7 @@ checksum = "c1df21f715862ede32a0c525ce2ca4d52626bb0007f8c18b87a384503ac33e70" dependencies = [ "clipboard-win", "image", - "log", + "log 0.4.29", "objc2 0.6.1", "objc2-app-kit", "objc2-core-foundation", @@ -1025,7 +1034,7 @@ version = "2.2.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "117725a109d387c937a1533ce01b450cbde6b88abceea8473c4d7a85853cda3c" dependencies = [ - "lazy_static", + "lazy_static 1.5.0", "windows-sys 0.59.0", ] @@ -1551,7 +1560,7 @@ dependencies = [ "rustc_version", "toml 0.8.23", "vswhom", - "winreg", + "winreg 0.55.0", ] [[package]] @@ -1602,8 +1611,8 @@ version = "0.1.3" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "186e05a59d4c50738528153b83b0b0194d3a29507dfec16eccd4b342903397d0" dependencies = [ - "log", - "regex", + "log 0.4.29", + "regex 1.11.1", ] [[package]] @@ -1616,7 +1625,7 @@ dependencies = [ "anstyle", "env_filter", "jiff", - "log", + "log 0.4.29", ] [[package]] @@ -1677,7 +1686,7 @@ name = "eventsource-client" version = "0.14.0" source = "git+https://github.com/yaakapp/rust-eventsource-client#60e0e3ac5038149c4778dc4979b09b152214f9a8" dependencies = [ - "log", + "log 0.4.29", "pin-project", ] @@ -1725,7 +1734,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "4316185f709b23713e41e3195f90edef7fb00c3ed4adc79769cf09cc762a3b29" dependencies = [ "colored", - "log", + "log 0.4.29", ] [[package]] @@ -1734,7 +1743,7 @@ version = "0.3.6" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "38e2275cc4e4fc009b0669731a1e5ab7ebf11f469eaede2bab9309a5b4d6057f" dependencies = [ - "memoffset", + "memoffset 0.9.1", "rustc_version", ] @@ -2184,7 +2193,7 @@ dependencies = [ "bitflags 2.9.1", "libc", "libgit2-sys", - "log", + "log 0.4.29", "openssl-probe", "openssl-sys", "url", @@ -2325,6 +2334,21 @@ dependencies = [ "tracing", ] +[[package]] +name = "handlebars" +version = "0.29.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "fb04af2006ea09d985fef82b81e0eb25337e51b691c76403332378a53d521edc" +dependencies = [ + "lazy_static 0.2.11", + "log 0.3.9", + "pest", + "quick-error", + "regex 0.2.11", + "serde", + "serde_json", +] + [[package]] name = "hashbrown" version = "0.12.3" @@ -2397,7 +2421,7 @@ version = "0.29.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "3b7410cae13cbc75623c98ac4cbfd1f0bedddf3227afc24f370cf0f50a44a11c" dependencies = [ - "log", + "log 0.4.29", "mac", "markup5ever", "match_token", @@ -2558,7 +2582,7 @@ dependencies = [ "core-foundation-sys", "iana-time-zone-haiku", "js-sys", - "log", + "log 0.4.29", "wasm-bindgen", "windows-core", ] @@ -2799,6 +2823,22 @@ dependencies = [ "generic-array", ] +[[package]] +name = "interfaces" +version = "0.0.8" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "4ec8f50a973916cac3da5057c986db05cd3346f38c78e9bc24f64cc9f6a3978f" +dependencies = [ + "bitflags 1.3.2", + "cc", + "handlebars", + "lazy_static 1.5.0", + "libc", + "nix 0.23.2", + "serde", + "serde_derive", +] + [[package]] name = "ipnet" version = "2.11.0" @@ -2885,7 +2925,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "e67e8da4c49d6d9909fe03361f9b620f58898859f5c7aded68351e85e71ecf50" dependencies = [ "jiff-static", - "log", + "log 0.4.29", "portable-atomic", "portable-atomic-util", "serde_core", @@ -2912,7 +2952,7 @@ dependencies = [ "cfg-if", "combine", "jni-sys", - "log", + "log 0.4.29", "thiserror 1.0.69", "walkdir", "windows-sys 0.45.0", @@ -2991,7 +3031,7 @@ checksum = "eebcc3aff044e5944a8fbaf69eb277d11986064cba30c468730e8b9909fb551c" dependencies = [ "byteorder", "dbus-secret-service", - "log", + "log 0.4.29", "security-framework 2.11.1", "security-framework 3.5.1", "windows-sys 0.60.2", @@ -3030,6 +3070,12 @@ dependencies = [ "selectors", ] +[[package]] +name = "lazy_static" +version = "0.2.11" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "76f033c7ad61445c5b347c7382dd1237847eb1bce590fe50365dcb33d546be73" + [[package]] name = "lazy_static" version = "1.5.0" @@ -3046,7 +3092,7 @@ dependencies = [ "gtk", "gtk-sys", "libappindicator-sys", - "log", + "log 0.4.29", ] [[package]] @@ -3204,6 +3250,15 @@ dependencies = [ "scopeguard", ] +[[package]] +name = "log" +version = "0.3.9" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "e19e8d5c34a3e0e2223db8e060f9e8264aeeb5c5fc64a4ee9965c062211c024b" +dependencies = [ + "log 0.4.29", +] + [[package]] name = "log" version = "0.4.29" @@ -3240,7 +3295,7 @@ version = "0.14.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "c7a7213d12e1864c0f002f52c2923d4556935a43dec5e71355c2760e0f6e7a18" dependencies = [ - "log", + "log 0.4.29", "phf 0.11.3", "phf_codegen 0.11.3", "string_cache", @@ -3289,6 +3344,15 @@ version = "2.7.4" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "78ca9ab1a0babb1e7d5695e3530886289c18cf2f87ec19a575a0abdce112e3a3" +[[package]] +name = "memoffset" +version = "0.6.5" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "5aa361d4faea93603064a027415f07bd8e1d5c88c9fbf68bf56a285428fd79ce" +dependencies = [ + "autocfg", +] + [[package]] name = "memoffset" version = "0.9.1" @@ -3343,7 +3407,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "78bed444cc8a2160f01cbcf811ef18cac863ad68ae8ca62092e8db51d51c761c" dependencies = [ "libc", - "log", + "log 0.4.29", "wasi 0.11.0+wasi-snapshot-preview1", "windows-sys 0.59.0", ] @@ -3385,7 +3449,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "87de3442987e9dbec73158d5c715e7ad9072fda936bb03d19d7fa10e00520f0e" dependencies = [ "libc", - "log", + "log 0.4.29", "openssl", "openssl-probe", "openssl-sys", @@ -3403,7 +3467,7 @@ checksum = "c3f42e7bbe13d351b6bead8286a43aac9534b82bd3cc43e47037f012ebfd62d4" dependencies = [ "bitflags 2.9.1", "jni-sys", - "log", + "log 0.4.29", "ndk-sys", "num_enum", "raw-window-handle", @@ -3431,6 +3495,19 @@ version = "1.0.6" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "650eef8c711430f1a879fdd01d4745a7deea475becfb90269c06775983bbf086" +[[package]] +name = "nix" +version = "0.23.2" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "8f3790c00a0150112de0f4cd161e3d7fc4b2d8a5542ffc35f099a2562aecb35c" +dependencies = [ + "bitflags 1.3.2", + "cc", + "cfg-if", + "libc", + "memoffset 0.6.5", +] + [[package]] name = "nix" version = "0.30.1" @@ -3441,7 +3518,7 @@ dependencies = [ "cfg-if", "cfg_aliases", "libc", - "memoffset", + "memoffset 0.9.1", ] [[package]] @@ -3478,7 +3555,7 @@ dependencies = [ "inotify", "kqueue", "libc", - "log", + "log 0.4.29", "mio", "notify-types", "walkdir", @@ -3919,7 +3996,7 @@ version = "3.11.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "41fc863e2ca13dc2d5c34fb22ea4a588248ac14db929616ba65c45f21744b1e9" dependencies = [ - "log", + "log 0.4.29", "serde", "windows-sys 0.52.0", ] @@ -3959,7 +4036,7 @@ dependencies = [ "des", "getrandom 0.2.16", "hmac", - "lazy_static", + "lazy_static 1.5.0", "rc2", "sha1", "yasna", @@ -4047,6 +4124,12 @@ version = "2.3.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "e3148f5046208a5d56bcfc03053e3ca6334e51da8dfb19b6cdc8b306fae3283e" +[[package]] +name = "pest" +version = "0.3.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "0a6dda33d67c26f0aac90d324ab2eb7239c819fc7b2552fe9faa4fe88441edc8" + [[package]] name = "petgraph" version = "0.6.5" @@ -4348,7 +4431,7 @@ dependencies = [ "float-cmp", "normalize-line-endings", "predicates-core", - "regex", + "regex 1.11.1", ] [[package]] @@ -4512,6 +4595,12 @@ dependencies = [ "syn 1.0.109", ] +[[package]] +name = "quick-error" +version = "1.2.3" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "a1d01941d82fa2ab50be1e79e6714289dd7cde78eba4c074bc5a4374f650dfe0" + [[package]] name = "quick-xml" version = "0.32.0" @@ -4606,7 +4695,7 @@ version = "0.8.10" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "51de85fb3fb6524929c8a2eb85e6b6d363de4e8c48f9e2c2eac4944abc181c93" dependencies = [ - "log", + "log 0.4.29", "parking_lot", "scheduled-thread-pool", ] @@ -4773,16 +4862,29 @@ dependencies = [ "thiserror 2.0.17", ] +[[package]] +name = "regex" +version = "0.2.11" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "9329abc99e39129fcceabd24cf5d85b4671ef7c29c50e972bc5afe32438ec384" +dependencies = [ + "aho-corasick 0.6.10", + "memchr", + "regex-syntax 0.5.6", + "thread_local", + "utf8-ranges", +] + [[package]] name = "regex" version = "1.11.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "b544ef1b4eac5dc2db33ea63606ae9ffcfac26c1416a2806ae0bf5f56b201191" dependencies = [ - "aho-corasick", + "aho-corasick 1.1.3", "memchr", "regex-automata", - "regex-syntax", + "regex-syntax 0.8.5", ] [[package]] @@ -4791,9 +4893,18 @@ version = "0.4.9" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "809e8dc61f6de73b46c85f4c96486310fe304c434cfa43669d7b40f711150908" dependencies = [ - "aho-corasick", + "aho-corasick 1.1.3", "memchr", - "regex-syntax", + "regex-syntax 0.8.5", +] + +[[package]] +name = "regex-syntax" +version = "0.5.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "7d707a4fa2637f2dca2ef9fd02225ec7661fe01a53623c1e6515b6916511f7a7" +dependencies = [ + "ucd-util", ] [[package]] @@ -4832,7 +4943,7 @@ dependencies = [ "hyper-tls", "hyper-util", "js-sys", - "log", + "log 0.4.29", "mime", "mime_guess", "native-tls", @@ -4873,7 +4984,7 @@ dependencies = [ "gobject-sys", "gtk-sys", "js-sys", - "log", + "log 0.4.29", "objc2 0.6.1", "objc2-app-kit", "objc2-core-foundation", @@ -5065,7 +5176,7 @@ dependencies = [ "core-foundation 0.10.1", "core-foundation-sys", "jni", - "log", + "log 0.4.29", "once_cell", "rustls", "rustls-native-certs", @@ -5253,7 +5364,7 @@ dependencies = [ "cssparser", "derive_more", "fxhash", - "log", + "log 0.4.29", "phf 0.8.0", "phf_codegen 0.8.0", "precomputed-hash", @@ -5621,7 +5732,7 @@ dependencies = [ "core-graphics 0.24.0", "foreign-types 0.5.0", "js-sys", - "log", + "log 0.4.29", "objc2 0.5.2", "objc2-foundation 0.2.2", "objc2-quartz-core 0.2.2", @@ -5769,6 +5880,18 @@ dependencies = [ "libc", ] +[[package]] +name = "sysproxy" +version = "0.3.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "9707a79d3b95683aa5a9521e698ffd878b8fb289727c25a69157fb85d529ffff" +dependencies = [ + "interfaces", + "thiserror 1.0.69", + "winapi", + "winreg 0.10.1", +] + [[package]] name = "system-configuration" version = "0.6.1" @@ -5821,9 +5944,9 @@ dependencies = [ "gdkx11-sys", "gtk", "jni", - "lazy_static", + "lazy_static 1.5.0", "libc", - "log", + "log 0.4.29", "ndk", "ndk-context", "ndk-sys", @@ -5897,7 +6020,7 @@ dependencies = [ "http-range", "jni", "libc", - "log", + "log 0.4.29", "mime", "muda", "objc2 0.6.1", @@ -6016,7 +6139,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "206dc20af4ed210748ba945c2774e60fd0acd52b9a73a028402caf809e9b6ecf" dependencies = [ "arboard", - "log", + "log 0.4.29", "serde", "serde_json", "tauri", @@ -6051,7 +6174,7 @@ version = "2.4.2" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "313f8138692ddc4a2127c4c9607d616a46f5c042e77b3722450866da0aad2f19" dependencies = [ - "log", + "log 0.4.29", "raw-window-handle", "rfd", "serde", @@ -6094,7 +6217,7 @@ dependencies = [ "android_logger", "byte-unit", "fern", - "log", + "log 0.4.29", "objc2 0.6.1", "objc2-foundation 0.3.1", "serde", @@ -6136,7 +6259,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "d8f08346c8deb39e96f86973da0e2d76cbb933d7ac9b750f6dc4daf955a6f997" dependencies = [ "gethostname 1.0.2", - "log", + "log 0.4.29", "os_info", "serde", "serde_json", @@ -6154,10 +6277,10 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "c374b6db45f2a8a304f0273a15080d98c70cde86178855fc24653ba657a1144c" dependencies = [ "encoding_rs", - "log", + "log 0.4.29", "open", "os_pipe", - "regex", + "regex 1.11.1", "schemars", "serde", "serde_json", @@ -6196,7 +6319,7 @@ dependencies = [ "futures-util", "http", "infer", - "log", + "log 0.4.29", "minisign-verify", "osakit", "percent-encoding", @@ -6223,7 +6346,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "73736611e14142408d15353e21e3cca2f12a3cfb523ad0ce85999b6d2ef1a704" dependencies = [ "bitflags 2.9.1", - "log", + "log 0.4.29", "serde", "serde_json", "tauri", @@ -6265,7 +6388,7 @@ dependencies = [ "gtk", "http", "jni", - "log", + "log 0.4.29", "objc2 0.6.1", "objc2-app-kit", "objc2-foundation 0.3.1", @@ -6300,12 +6423,12 @@ dependencies = [ "infer", "json-patch", "kuchikiki", - "log", + "log 0.4.29", "memchr", "phf 0.11.3", "proc-macro2", "quote", - "regex", + "regex 1.11.1", "schemars", "semver", "serde", @@ -6411,6 +6534,15 @@ dependencies = [ "syn 2.0.101", ] +[[package]] +name = "thread_local" +version = "0.3.6" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "c6b53e329000edc2b34dbe8545fd20e55a333362d0a321909685a19bd28c3f1b" +dependencies = [ + "lazy_static 1.5.0", +] + [[package]] name = "tiff" version = "0.9.1" @@ -6555,7 +6687,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "7a9daff607c6d2bf6c16fd681ccb7eecc83e4e2cdc1ca067ffaadfca5de7f084" dependencies = [ "futures-util", - "log", + "log 0.4.29", "rustls", "rustls-native-certs", "rustls-pki-types", @@ -6899,7 +7031,7 @@ dependencies = [ "data-encoding", "http", "httparse", - "log", + "log 0.4.29", "rand 0.9.1", "rustls", "rustls-pki-types", @@ -6920,13 +7052,19 @@ version = "1.18.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "1dccffe3ce07af9386bfd29e80c0ab1a8205a2fc34e4bcd40364df902cfa8f3f" +[[package]] +name = "ucd-util" +version = "0.1.10" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "abd2fc5d32b590614af8b0a20d837f32eca055edd0bbead59a9cfe80858be003" + [[package]] name = "uds_windows" version = "1.1.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "89daebc3e6fd160ac4aa9fc8b3bf71e1f74fbf92367ae71fb83a037e8bf164b9" dependencies = [ - "memoffset", + "memoffset 0.9.1", "tempfile", "winapi", ] @@ -7036,7 +7174,7 @@ version = "0.3.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "70acd30e3aa1450bc2eece896ce2ad0d178e9c079493819301573dae3c37ba6d" dependencies = [ - "regex", + "regex 1.11.1", "serde", "unic-ucd-ident", "url", @@ -7048,6 +7186,12 @@ version = "0.7.6" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "09cc8ee72d2a9becf2f2febe0205bbed8fc6615b7cb429ad062dc7b7ddd036a9" +[[package]] +name = "utf8-ranges" +version = "1.0.5" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "7fcfc827f90e53a02eaef5e535ee14266c1d569214c6aa70133a624d8a3164ba" + [[package]] name = "utf8-width" version = "0.1.7" @@ -7193,7 +7337,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "2f0a0651a5c2bc21487bde11ee802ccaf4c51935d0d3d42a6101f98161700bc6" dependencies = [ "bumpalo", - "log", + "log 0.4.29", "proc-macro2", "quote", "syn 2.0.101", @@ -7940,6 +8084,15 @@ dependencies = [ "memchr", ] +[[package]] +name = "winreg" +version = "0.10.1" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "80d0f4e272c85def139476380b12f9ac60926689dd2e01d4923222f40580869d" +dependencies = [ + "winapi", +] + [[package]] name = "winreg" version = "0.55.0" @@ -7966,7 +8119,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "8e5ff8d0e60065f549fafd9d6cb626203ea64a798186c80d8e7df4f8af56baeb" dependencies = [ "libc", - "log", + "log 0.4.29", "os_pipe", "rustix 0.38.44", "tempfile", @@ -8086,6 +8239,17 @@ dependencies = [ "rustix 1.0.7", ] +[[package]] +name = "yaak-api" +version = "0.1.0" +dependencies = [ + "log 0.4.29", + "reqwest", + "sysproxy", + "thiserror 2.0.17", + "yaak-common", +] + [[package]] name = "yaak-app" version = "0.0.0" @@ -8095,7 +8259,7 @@ dependencies = [ "cookie", "eventsource-client", "http", - "log", + "log 0.4.29", "md5 0.8.0", "mime_guess", "openssl-sys", @@ -8126,6 +8290,7 @@ dependencies = [ "ts-rs", "url", "uuid", + "yaak-api", "yaak-common", "yaak-core", "yaak-crypto", @@ -8153,7 +8318,7 @@ dependencies = [ "clap", "dirs", "env_logger", - "log", + "log 0.4.29", "predicates", "serde_json", "tempfile", @@ -8188,7 +8353,7 @@ dependencies = [ "base64 0.22.1", "chacha20poly1305", "keyring", - "log", + "log 0.4.29", "serde", "thiserror 2.0.17", "yaak-models", @@ -8212,7 +8377,7 @@ version = "0.1.0" dependencies = [ "chrono", "git2", - "log", + "log 0.4.29", "serde", "serde_json", "serde_yaml", @@ -8234,7 +8399,7 @@ dependencies = [ "dunce", "hyper-rustls", "hyper-util", - "log", + "log 0.4.29", "md5 0.7.0", "prost", "prost-reflect", @@ -8262,10 +8427,11 @@ dependencies = [ "cookie", "flate2", "futures-util", + "http-body", "hyper-util", - "log", + "log 0.4.29", "mime_guess", - "regex", + "regex 1.11.1", "reqwest", "serde", "serde_json", @@ -8286,7 +8452,7 @@ name = "yaak-license" version = "0.1.0" dependencies = [ "chrono", - "log", + "log 0.4.29", "reqwest", "serde", "serde_json", @@ -8294,9 +8460,9 @@ dependencies = [ "tauri-plugin", "thiserror 2.0.17", "ts-rs", + "yaak-api", "yaak-common", "yaak-models", - "yaak-tauri-utils", ] [[package]] @@ -8305,7 +8471,7 @@ version = "0.1.0" dependencies = [ "cocoa", "csscolorparser", - "log", + "log 0.4.29", "objc", "rand 0.9.1", "tauri", @@ -8319,7 +8485,7 @@ dependencies = [ "chrono", "hex", "include_dir", - "log", + "log 0.4.29", "nanoid", "r2d2", "r2d2_sqlite", @@ -8344,11 +8510,11 @@ dependencies = [ "futures-util", "hex", "keyring", - "log", + "log 0.4.29", "md5 0.7.0", "path-slash", "rand 0.9.1", - "regex", + "regex 1.11.1", "reqwest", "serde", "serde_json", @@ -8378,7 +8544,7 @@ version = "0.1.0" dependencies = [ "chrono", "hex", - "log", + "log 0.4.29", "notify", "serde", "serde_json", @@ -8395,12 +8561,8 @@ dependencies = [ name = "yaak-tauri-utils" version = "0.1.0" dependencies = [ - "regex", - "reqwest", - "serde", + "regex 1.11.1", "tauri", - "thiserror 2.0.17", - "yaak-common", ] [[package]] @@ -8408,7 +8570,7 @@ name = "yaak-templates" version = "0.1.0" dependencies = [ "base64 0.22.1", - "log", + "log 0.4.29", "serde", "serde-wasm-bindgen", "serde_json", @@ -8422,7 +8584,7 @@ dependencies = [ name = "yaak-tls" version = "0.1.0" dependencies = [ - "log", + "log 0.4.29", "p12", "rustls", "rustls-pemfile", @@ -8439,7 +8601,7 @@ version = "0.1.0" dependencies = [ "futures-util", "http", - "log", + "log 0.4.29", "md5 0.8.0", "serde", "serde_json", @@ -8503,7 +8665,7 @@ dependencies = [ "futures-core", "futures-lite", "hex", - "nix", + "nix 0.30.1", "ordered-stream", "serde", "serde_repr", @@ -8670,7 +8832,7 @@ version = "0.4.0" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "aed5f10c571472911e37d8f7601a8dfba52b4f7f73a344015291b82ab292faf6" dependencies = [ - "log", + "log 0.4.29", "thiserror 2.0.17", "zip", ] @@ -8689,7 +8851,7 @@ checksum = "edfc5ee405f504cd4984ecc6f14d02d55cfda60fa4b689434ef4102aae150cd7" dependencies = [ "bumpalo", "crc32fast", - "log", + "log 0.4.29", "simd-adler32", ] diff --git a/Cargo.toml b/Cargo.toml index 18a45a58..34cb3ee7 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -15,6 +15,7 @@ members = [ "crates/yaak-templates", "crates/yaak-tls", "crates/yaak-ws", + "crates/yaak-api", # CLI crates "crates-cli/yaak-cli", # Tauri-specific crates @@ -58,6 +59,7 @@ yaak-sync = { path = "crates/yaak-sync" } yaak-templates = { path = "crates/yaak-templates" } yaak-tls = { path = "crates/yaak-tls" } yaak-ws = { path = "crates/yaak-ws" } +yaak-api = { path = "crates/yaak-api" } # Internal crates - Tauri-specific yaak-fonts = { path = "crates-tauri/yaak-fonts" } diff --git a/biome.json b/biome.json index 13111ead..2a9cd936 100644 --- a/biome.json +++ b/biome.json @@ -47,7 +47,8 @@ "!src-web/vite.config.ts", "!src-web/routeTree.gen.ts", "!packages/plugin-runtime-types/lib", - "!**/bindings" + "!**/bindings", + "!flatpak" ] } } diff --git a/crates-tauri/yaak-app/Cargo.toml b/crates-tauri/yaak-app/Cargo.toml index 7213ea93..96f05ba0 100644 --- a/crates-tauri/yaak-app/Cargo.toml +++ b/crates-tauri/yaak-app/Cargo.toml @@ -57,6 +57,7 @@ url = "2" tokio-util = { version = "0.7", features = ["codec"] } ts-rs = { workspace = true } uuid = "1.12.1" +yaak-api = { workspace = true } yaak-common = { workspace = true } yaak-tauri-utils = { workspace = true } yaak-core = { workspace = true } diff --git a/crates-tauri/yaak-app/src/error.rs b/crates-tauri/yaak-app/src/error.rs index 9af1ce16..10659d53 100644 --- a/crates-tauri/yaak-app/src/error.rs +++ b/crates-tauri/yaak-app/src/error.rs @@ -36,7 +36,7 @@ pub enum Error { PluginError(#[from] yaak_plugins::error::Error), #[error(transparent)] - TauriUtilsError(#[from] yaak_tauri_utils::error::Error), + ApiError(#[from] yaak_api::Error), #[error(transparent)] ClipboardError(#[from] tauri_plugin_clipboard_manager::Error), diff --git a/crates-tauri/yaak-app/src/http_request.rs b/crates-tauri/yaak-app/src/http_request.rs index d2e060aa..4618bc87 100644 --- a/crates-tauri/yaak-app/src/http_request.rs +++ b/crates-tauri/yaak-app/src/http_request.rs @@ -414,7 +414,7 @@ async fn execute_transaction( sendable_request.body = Some(SendableBody::Bytes(bytes)); None } - Some(SendableBody::Stream(stream)) => { + Some(SendableBody::Stream { data: stream, content_length }) => { // Wrap stream with TeeReader to capture data as it's read // Use unbounded channel to ensure all data is captured without blocking the HTTP request let (body_chunk_tx, body_chunk_rx) = tokio::sync::mpsc::unbounded_channel::>(); @@ -448,7 +448,7 @@ async fn execute_transaction( None }; - sendable_request.body = Some(SendableBody::Stream(pinned)); + sendable_request.body = Some(SendableBody::Stream { data: pinned, content_length }); handle } None => { diff --git a/crates-tauri/yaak-app/src/lib.rs b/crates-tauri/yaak-app/src/lib.rs index 2b1710cf..ceb6c309 100644 --- a/crates-tauri/yaak-app/src/lib.rs +++ b/crates-tauri/yaak-app/src/lib.rs @@ -1095,8 +1095,13 @@ async fn cmd_get_http_authentication_config( // Convert HashMap to serde_json::Value for rendering let values_json: serde_json::Value = serde_json::to_value(&values)?; - let rendered_json = - render_json_value(values_json, environment_chain, &cb, &RenderOptions::throw()).await?; + let rendered_json = render_json_value( + values_json, + environment_chain, + &cb, + &RenderOptions::return_empty(), + ) + .await?; // Convert back to HashMap let rendered_values: HashMap = serde_json::from_value(rendered_json)?; diff --git a/crates-tauri/yaak-app/src/notifications.rs b/crates-tauri/yaak-app/src/notifications.rs index 9354e5f3..53a5c253 100644 --- a/crates-tauri/yaak-app/src/notifications.rs +++ b/crates-tauri/yaak-app/src/notifications.rs @@ -10,7 +10,7 @@ use tauri::{AppHandle, Emitter, Manager, Runtime, WebviewWindow}; use ts_rs::TS; use yaak_common::platform::get_os_str; use yaak_models::util::UpdateSource; -use yaak_tauri_utils::api_client::yaak_api_client; +use yaak_api::yaak_api_client; // Check for updates every hour const MAX_UPDATE_CHECK_SECONDS: u64 = 60 * 60; @@ -101,7 +101,8 @@ impl YaakNotifier { let license_check = "disabled".to_string(); let launch_info = get_or_upsert_launch_info(app_handle); - let req = yaak_api_client(app_handle)? + let app_version = app_handle.package_info().version.to_string(); + let req = yaak_api_client(&app_version)? .request(Method::GET, "https://notify.yaak.app/notifications") .query(&[ ("version", &launch_info.current_version), diff --git a/crates-tauri/yaak-app/src/plugins_ext.rs b/crates-tauri/yaak-app/src/plugins_ext.rs index 8807840d..f3a0af5a 100644 --- a/crates-tauri/yaak-app/src/plugins_ext.rs +++ b/crates-tauri/yaak-app/src/plugins_ext.rs @@ -31,7 +31,7 @@ use yaak_plugins::events::{Color, Icon, PluginContext, ShowToastRequest}; use yaak_plugins::install::{delete_and_uninstall, download_and_install}; use yaak_plugins::manager::PluginManager; use yaak_plugins::plugin_meta::get_plugin_meta; -use yaak_tauri_utils::api_client::yaak_api_client; +use yaak_api::yaak_api_client; static EXITING: AtomicBool = AtomicBool::new(false); @@ -72,7 +72,8 @@ impl PluginUpdater { info!("Checking for plugin updates"); - let http_client = yaak_api_client(window.app_handle())?; + let app_version = window.app_handle().package_info().version.to_string(); + let http_client = yaak_api_client(&app_version)?; let plugins = window.app_handle().db().list_plugins()?; let updates = check_plugin_updates(&http_client, plugins.clone()).await?; @@ -136,7 +137,8 @@ pub async fn cmd_plugins_search( app_handle: AppHandle, query: &str, ) -> Result { - let http_client = yaak_api_client(&app_handle)?; + let app_version = app_handle.package_info().version.to_string(); + let http_client = yaak_api_client(&app_version)?; Ok(search_plugins(&http_client, query).await?) } @@ -147,7 +149,8 @@ pub async fn cmd_plugins_install( version: Option, ) -> Result<()> { let plugin_manager = Arc::new((*window.state::()).clone()); - let http_client = yaak_api_client(window.app_handle())?; + let app_version = window.app_handle().package_info().version.to_string(); + let http_client = yaak_api_client(&app_version)?; let query_manager = window.state::(); let plugin_context = window.plugin_context(); download_and_install( @@ -177,7 +180,8 @@ pub async fn cmd_plugins_uninstall( pub async fn cmd_plugins_updates( app_handle: AppHandle, ) -> Result { - let http_client = yaak_api_client(&app_handle)?; + let app_version = app_handle.package_info().version.to_string(); + let http_client = yaak_api_client(&app_version)?; let plugins = app_handle.db().list_plugins()?; Ok(check_plugin_updates(&http_client, plugins).await?) } @@ -186,7 +190,8 @@ pub async fn cmd_plugins_updates( pub async fn cmd_plugins_update_all( window: WebviewWindow, ) -> Result> { - let http_client = yaak_api_client(window.app_handle())?; + let app_version = window.app_handle().package_info().version.to_string(); + let http_client = yaak_api_client(&app_version)?; let plugins = window.db().list_plugins()?; // Get list of available updates (already filtered to only registry plugins) diff --git a/crates-tauri/yaak-app/src/render.rs b/crates-tauri/yaak-app/src/render.rs index f5ad8fad..e63f525f 100644 --- a/crates-tauri/yaak-app/src/render.rs +++ b/crates-tauri/yaak-app/src/render.rs @@ -38,6 +38,9 @@ pub async fn render_grpc_request( let mut metadata = Vec::new(); for p in r.metadata.clone() { + if !p.enabled { + continue; + } metadata.push(HttpRequestHeader { enabled: p.enabled, name: parse_and_render(p.name.as_str(), vars, cb, &opt).await?, @@ -119,6 +122,7 @@ pub async fn render_http_request( let mut body = BTreeMap::new(); for (k, v) in r.body.clone() { + let v = if k == "form" { strip_disabled_form_entries(v) } else { v }; body.insert(k, render_json_value_raw(v, vars, cb, &opt).await?); } @@ -161,3 +165,71 @@ pub async fn render_http_request( Ok(HttpRequest { url, url_parameters, headers, body, authentication, ..r.to_owned() }) } + +/// Strip disabled entries from a JSON array of form objects. +fn strip_disabled_form_entries(v: Value) -> Value { + match v { + Value::Array(items) => Value::Array( + items + .into_iter() + .filter(|item| item.get("enabled").and_then(|e| e.as_bool()).unwrap_or(true)) + .collect(), + ), + v => v, + } +} + +#[cfg(test)] +mod tests { + use super::*; + use serde_json::json; + + #[test] + fn test_strip_disabled_form_entries() { + let input = json!([ + {"enabled": true, "name": "foo", "value": "bar"}, + {"enabled": false, "name": "disabled", "value": "gone"}, + {"enabled": true, "name": "baz", "value": "qux"}, + ]); + let result = strip_disabled_form_entries(input); + assert_eq!( + result, + json!([ + {"enabled": true, "name": "foo", "value": "bar"}, + {"enabled": true, "name": "baz", "value": "qux"}, + ]) + ); + } + + #[test] + fn test_strip_disabled_form_entries_all_disabled() { + let input = json!([ + {"enabled": false, "name": "a", "value": "b"}, + {"enabled": false, "name": "c", "value": "d"}, + ]); + let result = strip_disabled_form_entries(input); + assert_eq!(result, json!([])); + } + + #[test] + fn test_strip_disabled_form_entries_missing_enabled_defaults_to_kept() { + let input = json!([ + {"name": "no_enabled_field", "value": "kept"}, + {"enabled": false, "name": "disabled", "value": "gone"}, + ]); + let result = strip_disabled_form_entries(input); + assert_eq!( + result, + json!([ + {"name": "no_enabled_field", "value": "kept"}, + ]) + ); + } + + #[test] + fn test_strip_disabled_form_entries_non_array_passthrough() { + let input = json!("just a string"); + let result = strip_disabled_form_entries(input.clone()); + assert_eq!(result, input); + } +} diff --git a/crates-tauri/yaak-app/src/updates.rs b/crates-tauri/yaak-app/src/updates.rs index b8f64a5a..c068a813 100644 --- a/crates-tauri/yaak-app/src/updates.rs +++ b/crates-tauri/yaak-app/src/updates.rs @@ -15,6 +15,9 @@ use ts_rs::TS; use yaak_models::util::generate_id; use yaak_plugins::manager::PluginManager; +use url::Url; +use yaak_api::get_system_proxy_url; + use crate::error::Error::GenericError; use crate::is_dev; @@ -87,8 +90,13 @@ impl YaakUpdater { info!("Checking for updates mode={} autodl={}", mode, auto_download); let w = window.clone(); - let update_check_result = w - .updater_builder() + let mut updater_builder = w.updater_builder(); + if let Some(proxy_url) = get_system_proxy_url() { + if let Ok(url) = Url::parse(&proxy_url) { + updater_builder = updater_builder.proxy(url); + } + } + let update_check_result = updater_builder .on_before_exit(move || { // Kill plugin manager before exit or NSIS installer will fail to replace sidecar // while it's running. diff --git a/crates-tauri/yaak-app/src/uri_scheme.rs b/crates-tauri/yaak-app/src/uri_scheme.rs index 52119241..d186bbfc 100644 --- a/crates-tauri/yaak-app/src/uri_scheme.rs +++ b/crates-tauri/yaak-app/src/uri_scheme.rs @@ -12,7 +12,7 @@ use yaak_models::util::generate_id; use yaak_plugins::events::{Color, ShowToastRequest}; use yaak_plugins::install::download_and_install; use yaak_plugins::manager::PluginManager; -use yaak_tauri_utils::api_client::yaak_api_client; +use yaak_api::yaak_api_client; pub(crate) async fn handle_deep_link( app_handle: &AppHandle, @@ -46,7 +46,8 @@ pub(crate) async fn handle_deep_link( let plugin_manager = Arc::new((*window.state::()).clone()); let query_manager = app_handle.db_manager(); - let http_client = yaak_api_client(app_handle)?; + let app_version = app_handle.package_info().version.to_string(); + let http_client = yaak_api_client(&app_version)?; let plugin_context = window.plugin_context(); let pv = download_and_install( plugin_manager, @@ -86,7 +87,8 @@ pub(crate) async fn handle_deep_link( return Ok(()); } - let resp = yaak_api_client(app_handle)?.get(file_url).send().await?; + let app_version = app_handle.package_info().version.to_string(); + let resp = yaak_api_client(&app_version)?.get(file_url).send().await?; let json = resp.bytes().await?; let p = app_handle .path() diff --git a/crates-tauri/yaak-app/tauri.release.conf.json b/crates-tauri/yaak-app/tauri.release.conf.json index 20ad2868..0f6151a0 100644 --- a/crates-tauri/yaak-app/tauri.release.conf.json +++ b/crates-tauri/yaak-app/tauri.release.conf.json @@ -1,9 +1,6 @@ { "build": { - "features": [ - "updater", - "license" - ] + "features": ["updater", "license"] }, "app": { "security": { @@ -11,12 +8,8 @@ "default", { "identifier": "release", - "windows": [ - "*" - ], - "permissions": [ - "yaak-license:default" - ] + "windows": ["*"], + "permissions": ["yaak-license:default"] } ] } @@ -39,14 +32,7 @@ "createUpdaterArtifacts": true, "longDescription": "A cross-platform desktop app for interacting with REST, GraphQL, and gRPC", "shortDescription": "Play with APIs, intuitively", - "targets": [ - "app", - "appimage", - "deb", - "dmg", - "nsis", - "rpm" - ], + "targets": ["app", "appimage", "deb", "dmg", "nsis", "rpm"], "macOS": { "minimumSystemVersion": "13.0", "exceptionDomain": "", @@ -58,10 +44,16 @@ }, "linux": { "deb": { - "desktopTemplate": "./template.desktop" + "desktopTemplate": "./template.desktop", + "files": { + "/usr/share/metainfo/app.yaak.Yaak.metainfo.xml": "../../flatpak/app.yaak.Yaak.metainfo.xml" + } }, "rpm": { - "desktopTemplate": "./template.desktop" + "desktopTemplate": "./template.desktop", + "files": { + "/usr/share/metainfo/app.yaak.Yaak.metainfo.xml": "../../flatpak/app.yaak.Yaak.metainfo.xml" + } } } } diff --git a/crates-tauri/yaak-license/Cargo.toml b/crates-tauri/yaak-license/Cargo.toml index 3560040a..4eb04489 100644 --- a/crates-tauri/yaak-license/Cargo.toml +++ b/crates-tauri/yaak-license/Cargo.toml @@ -16,7 +16,7 @@ thiserror = { workspace = true } ts-rs = { workspace = true } yaak-common = { workspace = true } yaak-models = { workspace = true } -yaak-tauri-utils = { workspace = true } +yaak-api = { workspace = true } [build-dependencies] tauri-plugin = { workspace = true, features = ["build"] } diff --git a/crates-tauri/yaak-license/src/error.rs b/crates-tauri/yaak-license/src/error.rs index 823260fe..99e1292d 100644 --- a/crates-tauri/yaak-license/src/error.rs +++ b/crates-tauri/yaak-license/src/error.rs @@ -16,7 +16,7 @@ pub enum Error { ModelError(#[from] yaak_models::error::Error), #[error(transparent)] - TauriUtilsError(#[from] yaak_tauri_utils::error::Error), + ApiError(#[from] yaak_api::Error), #[error("Internal server error")] ServerError, diff --git a/crates-tauri/yaak-license/src/license.rs b/crates-tauri/yaak-license/src/license.rs index dc6c185e..3f2c4aa3 100644 --- a/crates-tauri/yaak-license/src/license.rs +++ b/crates-tauri/yaak-license/src/license.rs @@ -11,7 +11,7 @@ use yaak_common::platform::get_os_str; use yaak_models::db_context::DbContext; use yaak_models::query_manager::QueryManager; use yaak_models::util::UpdateSource; -use yaak_tauri_utils::api_client::yaak_api_client; +use yaak_api::yaak_api_client; /// Extension trait for accessing the QueryManager from Tauri Manager types. /// This is needed temporarily until all crates are refactored to not use Tauri. @@ -118,11 +118,12 @@ pub async fn activate_license( license_key: &str, ) -> Result<()> { info!("Activating license {}", license_key); - let client = reqwest::Client::new(); + let app_version = window.app_handle().package_info().version.to_string(); + let client = yaak_api_client(&app_version)?; let payload = ActivateLicenseRequestPayload { license_key: license_key.to_string(), app_platform: get_os_str().to_string(), - app_version: window.app_handle().package_info().version.to_string(), + app_version, }; let response = client.post(build_url("/licenses/activate")).json(&payload).send().await?; @@ -155,11 +156,12 @@ pub async fn deactivate_license(window: &WebviewWindow) -> Result let app_handle = window.app_handle(); let activation_id = get_activation_id(app_handle).await; - let client = reqwest::Client::new(); + let app_version = window.app_handle().package_info().version.to_string(); + let client = yaak_api_client(&app_version)?; let path = format!("/licenses/activations/{}/deactivate", activation_id); let payload = DeactivateLicenseRequestPayload { app_platform: get_os_str().to_string(), - app_version: window.app_handle().package_info().version.to_string(), + app_version, }; let response = client.post(build_url(&path)).json(&payload).send().await?; @@ -186,9 +188,10 @@ pub async fn deactivate_license(window: &WebviewWindow) -> Result } pub async fn check_license(window: &WebviewWindow) -> Result { + let app_version = window.app_handle().package_info().version.to_string(); let payload = CheckActivationRequestPayload { app_platform: get_os_str().to_string(), - app_version: window.package_info().version.to_string(), + app_version, }; let activation_id = get_activation_id(window.app_handle()).await; @@ -204,7 +207,7 @@ pub async fn check_license(window: &WebviewWindow) -> Result { info!("Checking license activation"); // A license has been activated, so let's check the license server - let client = yaak_api_client(window.app_handle())?; + let client = yaak_api_client(&payload.app_version)?; let path = format!("/licenses/activations/{activation_id}/check-v2"); let response = client.post(build_url(&path)).json(&payload).send().await?; diff --git a/crates-tauri/yaak-tauri-utils/Cargo.toml b/crates-tauri/yaak-tauri-utils/Cargo.toml index 11652f1a..74272621 100644 --- a/crates-tauri/yaak-tauri-utils/Cargo.toml +++ b/crates-tauri/yaak-tauri-utils/Cargo.toml @@ -6,8 +6,4 @@ publish = false [dependencies] tauri = { workspace = true } -reqwest = { workspace = true, features = ["gzip"] } -thiserror = { workspace = true } -serde = { workspace = true, features = ["derive"] } regex = "1.11.0" -yaak-common = { workspace = true } diff --git a/crates-tauri/yaak-tauri-utils/src/api_client.rs b/crates-tauri/yaak-tauri-utils/src/api_client.rs deleted file mode 100644 index cc308126..00000000 --- a/crates-tauri/yaak-tauri-utils/src/api_client.rs +++ /dev/null @@ -1,24 +0,0 @@ -use crate::error::Result; -use reqwest::Client; -use std::time::Duration; -use tauri::http::{HeaderMap, HeaderValue}; -use tauri::{AppHandle, Runtime}; -use yaak_common::platform::{get_ua_arch, get_ua_platform}; - -pub fn yaak_api_client(app_handle: &AppHandle) -> Result { - let platform = get_ua_platform(); - let version = app_handle.package_info().version.clone(); - let arch = get_ua_arch(); - let ua = format!("Yaak/{version} ({platform}; {arch})"); - let mut default_headers = HeaderMap::new(); - default_headers.insert("Accept", HeaderValue::from_str("application/json").unwrap()); - - let client = reqwest::ClientBuilder::new() - .timeout(Duration::from_secs(20)) - .default_headers(default_headers) - .gzip(true) - .user_agent(ua) - .build()?; - - Ok(client) -} diff --git a/crates-tauri/yaak-tauri-utils/src/error.rs b/crates-tauri/yaak-tauri-utils/src/error.rs deleted file mode 100644 index 46a9c103..00000000 --- a/crates-tauri/yaak-tauri-utils/src/error.rs +++ /dev/null @@ -1,19 +0,0 @@ -use serde::{Serialize, Serializer}; -use thiserror::Error; - -#[derive(Error, Debug)] -pub enum Error { - #[error(transparent)] - ReqwestError(#[from] reqwest::Error), -} - -impl Serialize for Error { - fn serialize(&self, serializer: S) -> std::result::Result - where - S: Serializer, - { - serializer.serialize_str(self.to_string().as_ref()) - } -} - -pub type Result = std::result::Result; diff --git a/crates-tauri/yaak-tauri-utils/src/lib.rs b/crates-tauri/yaak-tauri-utils/src/lib.rs index 719ee7f0..61b63f17 100644 --- a/crates-tauri/yaak-tauri-utils/src/lib.rs +++ b/crates-tauri/yaak-tauri-utils/src/lib.rs @@ -1,3 +1 @@ -pub mod api_client; -pub mod error; pub mod window; diff --git a/crates/yaak-api/Cargo.toml b/crates/yaak-api/Cargo.toml new file mode 100644 index 00000000..024ae852 --- /dev/null +++ b/crates/yaak-api/Cargo.toml @@ -0,0 +1,12 @@ +[package] +name = "yaak-api" +version = "0.1.0" +edition = "2024" +publish = false + +[dependencies] +log = { workspace = true } +reqwest = { workspace = true, features = ["gzip"] } +sysproxy = "0.3" +thiserror = { workspace = true } +yaak-common = { workspace = true } diff --git a/crates/yaak-api/src/error.rs b/crates/yaak-api/src/error.rs new file mode 100644 index 00000000..2cdc6a11 --- /dev/null +++ b/crates/yaak-api/src/error.rs @@ -0,0 +1,9 @@ +use thiserror::Error; + +#[derive(Error, Debug)] +pub enum Error { + #[error(transparent)] + ReqwestError(#[from] reqwest::Error), +} + +pub type Result = std::result::Result; diff --git a/crates/yaak-api/src/lib.rs b/crates/yaak-api/src/lib.rs new file mode 100644 index 00000000..6e18de19 --- /dev/null +++ b/crates/yaak-api/src/lib.rs @@ -0,0 +1,70 @@ +mod error; + +pub use error::{Error, Result}; + +use log::{debug, warn}; +use reqwest::Client; +use reqwest::header::{HeaderMap, HeaderValue}; +use std::time::Duration; +use yaak_common::platform::{get_ua_arch, get_ua_platform}; + +/// Build a reqwest Client configured for Yaak's own API calls. +/// +/// Includes a custom User-Agent, JSON accept header, 20s timeout, gzip, +/// and automatic OS-level proxy detection via sysproxy. +pub fn yaak_api_client(version: &str) -> Result { + let platform = get_ua_platform(); + let arch = get_ua_arch(); + let ua = format!("Yaak/{version} ({platform}; {arch})"); + + let mut default_headers = HeaderMap::new(); + default_headers.insert("Accept", HeaderValue::from_str("application/json").unwrap()); + + let mut builder = reqwest::ClientBuilder::new() + .timeout(Duration::from_secs(20)) + .default_headers(default_headers) + .gzip(true) + .user_agent(ua); + + if let Some(sys) = get_enabled_system_proxy() { + let proxy_url = format!("http://{}:{}", sys.host, sys.port); + match reqwest::Proxy::all(&proxy_url) { + Ok(p) => { + let p = if !sys.bypass.is_empty() { + p.no_proxy(reqwest::NoProxy::from_string(&sys.bypass)) + } else { + p + }; + builder = builder.proxy(p); + } + Err(e) => { + warn!("Failed to configure system proxy: {e}"); + } + } + } + + Ok(builder.build()?) +} + +/// Returns the system proxy URL if one is enabled, e.g. `http://host:port`. +pub fn get_system_proxy_url() -> Option { + let sys = get_enabled_system_proxy()?; + Some(format!("http://{}:{}", sys.host, sys.port)) +} + +fn get_enabled_system_proxy() -> Option { + match sysproxy::Sysproxy::get_system_proxy() { + Ok(sys) if sys.enable => { + debug!("Detected system proxy: http://{}:{}", sys.host, sys.port); + Some(sys) + } + Ok(_) => { + debug!("System proxy detected but not enabled"); + None + } + Err(e) => { + debug!("Could not detect system proxy: {e}"); + None + } + } +} diff --git a/crates/yaak-git/index.ts b/crates/yaak-git/index.ts index b90fa99b..b08d838b 100644 --- a/crates/yaak-git/index.ts +++ b/crates/yaak-git/index.ts @@ -32,22 +32,30 @@ export interface GitCallbacks { const onSuccess = () => queryClient.invalidateQueries({ queryKey: ['git'] }); -export function useGit(dir: string, callbacks: GitCallbacks) { +export function useGit(dir: string, callbacks: GitCallbacks, refreshKey?: string) { const mutations = useMemo(() => gitMutations(dir, callbacks), [dir, callbacks]); + const fetchAll = useQuery({ + queryKey: ['git', 'fetch_all', dir, refreshKey], + queryFn: () => invoke('cmd_git_fetch_all', { dir }), + refetchInterval: 10 * 60_000, + }); return [ { remotes: useQuery({ - queryKey: ['git', 'remotes', dir], + queryKey: ['git', 'remotes', dir, refreshKey], queryFn: () => getRemotes(dir), + placeholderData: (prev) => prev, }), log: useQuery({ - queryKey: ['git', 'log', dir], + queryKey: ['git', 'log', dir, refreshKey], queryFn: () => invoke('cmd_git_log', { dir }), + placeholderData: (prev) => prev, }), status: useQuery({ refetchOnMount: true, - queryKey: ['git', 'status', dir], + queryKey: ['git', 'status', dir, refreshKey, fetchAll.dataUpdatedAt], queryFn: () => invoke('cmd_git_status', { dir }), + placeholderData: (prev) => prev, }), }, mutations, @@ -152,10 +160,7 @@ export const gitMutations = (dir: string, callbacks: GitCallbacks) => { }, onSuccess, }), - fetchAll: createFastMutation({ - mutationKey: ['git', 'fetch_all', dir], - mutationFn: () => invoke('cmd_git_fetch_all', { dir }), - }), + push: createFastMutation({ mutationKey: ['git', 'push', dir], mutationFn: push, diff --git a/crates/yaak-git/src/pull.rs b/crates/yaak-git/src/pull.rs index 0bf75474..4185350e 100644 --- a/crates/yaak-git/src/pull.rs +++ b/crates/yaak-git/src/pull.rs @@ -44,43 +44,65 @@ pub async fn git_pull(dir: &Path) -> Result { (branch_name, remote_name, remote_url) }; - let out = new_binary_command(dir) + // Step 1: fetch the specific branch + // NOTE: We use fetch + merge instead of `git pull` to avoid conflicts with + // global git config (e.g. pull.ff=only) and the background fetch --all. + let fetch_out = new_binary_command(dir) .await? - .args(["pull", &remote_name, &branch_name]) + .args(["fetch", &remote_name, &branch_name]) .env("GIT_TERMINAL_PROMPT", "0") .output() .await - .map_err(|e| GenericError(format!("failed to run git pull: {e}")))?; + .map_err(|e| GenericError(format!("failed to run git fetch: {e}")))?; - let stdout = String::from_utf8_lossy(&out.stdout); - let stderr = String::from_utf8_lossy(&out.stderr); - let combined = stdout + stderr; + let fetch_stdout = String::from_utf8_lossy(&fetch_out.stdout); + let fetch_stderr = String::from_utf8_lossy(&fetch_out.stderr); + let fetch_combined = format!("{fetch_stdout}{fetch_stderr}"); - info!("Pulled status={} {combined}", out.status); + info!("Fetched status={} {fetch_combined}", fetch_out.status); - if combined.to_lowercase().contains("could not read") { + if fetch_combined.to_lowercase().contains("could not read") { return Ok(PullResult::NeedsCredentials { url: remote_url.to_string(), error: None }); } - if combined.to_lowercase().contains("unable to access") { + if fetch_combined.to_lowercase().contains("unable to access") { return Ok(PullResult::NeedsCredentials { url: remote_url.to_string(), - error: Some(combined.to_string()), + error: Some(fetch_combined.to_string()), }); } - if !out.status.success() { - let combined_lower = combined.to_lowercase(); - if combined_lower.contains("cannot fast-forward") - || combined_lower.contains("not possible to fast-forward") - || combined_lower.contains("diverged") + if !fetch_out.status.success() { + return Err(GenericError(format!("Failed to fetch: {fetch_combined}"))); + } + + // Step 2: merge the fetched branch + let ref_name = format!("{}/{}", remote_name, branch_name); + let merge_out = new_binary_command(dir) + .await? + .args(["merge", "--ff-only", &ref_name]) + .output() + .await + .map_err(|e| GenericError(format!("failed to run git merge: {e}")))?; + + let merge_stdout = String::from_utf8_lossy(&merge_out.stdout); + let merge_stderr = String::from_utf8_lossy(&merge_out.stderr); + let merge_combined = format!("{merge_stdout}{merge_stderr}"); + + info!("Merged status={} {merge_combined}", merge_out.status); + + if !merge_out.status.success() { + let merge_lower = merge_combined.to_lowercase(); + if merge_lower.contains("cannot fast-forward") + || merge_lower.contains("not possible to fast-forward") + || merge_lower.contains("diverged") { return Ok(PullResult::Diverged { remote: remote_name, branch: branch_name }); } - return Err(GenericError(format!("Failed to pull {combined}"))); + return Err(GenericError(format!("Failed to merge: {merge_combined}"))); } - if combined.to_lowercase().contains("up to date") { + if merge_combined.to_lowercase().contains("up to date") { return Ok(PullResult::UpToDate); } diff --git a/crates/yaak-http/Cargo.toml b/crates/yaak-http/Cargo.toml index 1df3b31e..20183503 100644 --- a/crates/yaak-http/Cargo.toml +++ b/crates/yaak-http/Cargo.toml @@ -12,6 +12,7 @@ bytes = "1.11.1" cookie = "0.18.1" flate2 = "1" futures-util = "0.3" +http-body = "1" url = "2" zstd = "0.13" hyper-util = { version = "0.1.17", default-features = false, features = ["client-legacy"] } diff --git a/crates/yaak-http/src/sender.rs b/crates/yaak-http/src/sender.rs index 940d0f31..911f2338 100644 --- a/crates/yaak-http/src/sender.rs +++ b/crates/yaak-http/src/sender.rs @@ -2,7 +2,9 @@ use crate::decompress::{ContentEncoding, streaming_decoder}; use crate::error::{Error, Result}; use crate::types::{SendableBody, SendableHttpRequest}; use async_trait::async_trait; +use bytes::Bytes; use futures_util::StreamExt; +use http_body::{Body as HttpBody, Frame, SizeHint}; use reqwest::{Client, Method, Version}; use std::fmt::Display; use std::pin::Pin; @@ -413,10 +415,16 @@ impl HttpSender for ReqwestSender { Some(SendableBody::Bytes(bytes)) => { req_builder = req_builder.body(bytes); } - Some(SendableBody::Stream(stream)) => { - // Convert AsyncRead stream to reqwest Body - let stream = tokio_util::io::ReaderStream::new(stream); - let body = reqwest::Body::wrap_stream(stream); + Some(SendableBody::Stream { data, content_length }) => { + // Convert AsyncRead stream to reqwest Body. If content length is + // known, wrap with a SizedBody so hyper can set Content-Length + // automatically (for both HTTP/1.1 and HTTP/2). + let stream = tokio_util::io::ReaderStream::new(data); + let body = if let Some(len) = content_length { + reqwest::Body::wrap(SizedBody::new(stream, len)) + } else { + reqwest::Body::wrap_stream(stream) + }; req_builder = req_builder.body(body); } } @@ -520,6 +528,51 @@ impl HttpSender for ReqwestSender { } } +/// A wrapper around a byte stream that reports a known content length via +/// `size_hint()`. This lets hyper set the `Content-Length` header +/// automatically based on the body size, without us having to add it as an +/// explicit header — which can cause duplicate `Content-Length` headers and +/// break HTTP/2. +struct SizedBody { + stream: std::sync::Mutex, + remaining: u64, +} + +impl SizedBody { + fn new(stream: S, content_length: u64) -> Self { + Self { stream: std::sync::Mutex::new(stream), remaining: content_length } + } +} + +impl HttpBody for SizedBody +where + S: futures_util::Stream> + Send + Unpin + 'static, +{ + type Data = Bytes; + type Error = std::io::Error; + + fn poll_frame( + self: Pin<&mut Self>, + cx: &mut Context<'_>, + ) -> Poll, Self::Error>>> { + let this = self.get_mut(); + let mut stream = this.stream.lock().unwrap(); + match stream.poll_next_unpin(cx) { + Poll::Ready(Some(Ok(chunk))) => { + this.remaining = this.remaining.saturating_sub(chunk.len() as u64); + Poll::Ready(Some(Ok(Frame::data(chunk)))) + } + Poll::Ready(Some(Err(e))) => Poll::Ready(Some(Err(e))), + Poll::Ready(None) => Poll::Ready(None), + Poll::Pending => Poll::Pending, + } + } + + fn size_hint(&self) -> SizeHint { + SizeHint::with_exact(self.remaining) + } +} + fn version_to_str(version: &Version) -> String { match *version { Version::HTTP_09 => "HTTP/0.9".to_string(), diff --git a/crates/yaak-http/src/types.rs b/crates/yaak-http/src/types.rs index 135ce8bb..aee41313 100644 --- a/crates/yaak-http/src/types.rs +++ b/crates/yaak-http/src/types.rs @@ -16,7 +16,13 @@ pub(crate) const MULTIPART_BOUNDARY: &str = "------YaakFormBoundary"; pub enum SendableBody { Bytes(Bytes), - Stream(Pin>), + Stream { + data: Pin>, + /// Known content length for the stream, if available. This is used by + /// the sender to set the body size hint so that hyper can set + /// Content-Length automatically for both HTTP/1.1 and HTTP/2. + content_length: Option, + }, } enum SendableBodyWithMeta { @@ -31,7 +37,10 @@ impl From for SendableBody { fn from(value: SendableBodyWithMeta) -> Self { match value { SendableBodyWithMeta::Bytes(b) => SendableBody::Bytes(b), - SendableBodyWithMeta::Stream { data, .. } => SendableBody::Stream(data), + SendableBodyWithMeta::Stream { data, content_length } => SendableBody::Stream { + data, + content_length: content_length.map(|l| l as u64), + }, } } } @@ -186,23 +195,11 @@ async fn build_body( } } - // Check if Transfer-Encoding: chunked is already set - let has_chunked_encoding = headers.iter().any(|h| { - h.0.to_lowercase() == "transfer-encoding" && h.1.to_lowercase().contains("chunked") - }); - - // Add a Content-Length header only if chunked encoding is not being used - if !has_chunked_encoding { - let content_length = match body { - Some(SendableBodyWithMeta::Bytes(ref bytes)) => Some(bytes.len()), - Some(SendableBodyWithMeta::Stream { content_length, .. }) => content_length, - None => None, - }; - - if let Some(cl) = content_length { - headers.push(("Content-Length".to_string(), cl.to_string())); - } - } + // NOTE: Content-Length is NOT set as an explicit header here. Instead, the + // body's content length is carried via SendableBody::Stream { content_length } + // and used by the sender to set the body size hint. This lets hyper handle + // Content-Length automatically for both HTTP/1.1 and HTTP/2, avoiding the + // duplicate Content-Length that breaks HTTP/2 servers. Ok((body.map(|b| b.into()), headers)) } @@ -928,7 +925,27 @@ mod tests { } #[tokio::test] - async fn test_no_content_length_with_chunked_encoding() -> Result<()> { + async fn test_no_content_length_header_added_by_build_body() -> Result<()> { + let mut body = BTreeMap::new(); + body.insert("text".to_string(), json!("Hello, World!")); + + let headers = vec![]; + + let (_, result_headers) = + build_body("POST", &Some("text/plain".to_string()), &body, headers).await?; + + // Content-Length should NOT be set as an explicit header. Instead, the + // sender uses the body's size_hint to let hyper set it automatically, + // which works correctly for both HTTP/1.1 and HTTP/2. + let has_content_length = + result_headers.iter().any(|h| h.0.to_lowercase() == "content-length"); + assert!(!has_content_length, "Content-Length should not be set as an explicit header"); + + Ok(()) + } + + #[tokio::test] + async fn test_chunked_encoding_header_preserved() -> Result<()> { let mut body = BTreeMap::new(); body.insert("text".to_string(), json!("Hello, World!")); @@ -938,11 +955,6 @@ mod tests { let (_, result_headers) = build_body("POST", &Some("text/plain".to_string()), &body, headers).await?; - // Verify that Content-Length is NOT present when Transfer-Encoding: chunked is set - let has_content_length = - result_headers.iter().any(|h| h.0.to_lowercase() == "content-length"); - assert!(!has_content_length, "Content-Length should not be present with chunked encoding"); - // Verify that the Transfer-Encoding header is still present let has_chunked = result_headers.iter().any(|h| { h.0.to_lowercase() == "transfer-encoding" && h.1.to_lowercase().contains("chunked") @@ -951,31 +963,4 @@ mod tests { Ok(()) } - - #[tokio::test] - async fn test_content_length_without_chunked_encoding() -> Result<()> { - let mut body = BTreeMap::new(); - body.insert("text".to_string(), json!("Hello, World!")); - - // Headers without Transfer-Encoding: chunked - let headers = vec![]; - - let (_, result_headers) = - build_body("POST", &Some("text/plain".to_string()), &body, headers).await?; - - // Verify that Content-Length IS present when Transfer-Encoding: chunked is NOT set - let content_length_header = - result_headers.iter().find(|h| h.0.to_lowercase() == "content-length"); - assert!( - content_length_header.is_some(), - "Content-Length should be present without chunked encoding" - ); - assert_eq!( - content_length_header.unwrap().1, - "13", - "Content-Length should match the body size" - ); - - Ok(()) - } } diff --git a/crates/yaak-templates/build-wasm.cjs b/crates/yaak-templates/build-wasm.cjs new file mode 100644 index 00000000..4f86941b --- /dev/null +++ b/crates/yaak-templates/build-wasm.cjs @@ -0,0 +1,8 @@ +const { execSync } = require('node:child_process'); + +if (process.env.SKIP_WASM_BUILD === '1') { + console.log('Skipping wasm-pack build (SKIP_WASM_BUILD=1)'); + return; +} + +execSync('wasm-pack build --target bundler', { stdio: 'inherit' }); diff --git a/crates/yaak-templates/package.json b/crates/yaak-templates/package.json index f4c75149..9826bfb6 100644 --- a/crates/yaak-templates/package.json +++ b/crates/yaak-templates/package.json @@ -6,7 +6,7 @@ "scripts": { "bootstrap": "npm run build", "build": "run-s build:*", - "build:pack": "wasm-pack build --target bundler", + "build:pack": "node build-wasm.cjs", "build:clean": "rimraf ./pkg/.gitignore" }, "devDependencies": { diff --git a/crates/yaak-templates/src/renderer.rs b/crates/yaak-templates/src/renderer.rs index 495e1120..42fd0029 100644 --- a/crates/yaak-templates/src/renderer.rs +++ b/crates/yaak-templates/src/renderer.rs @@ -81,6 +81,10 @@ impl RenderOptions { pub fn throw() -> Self { Self { error_behavior: RenderErrorBehavior::Throw } } + + pub fn return_empty() -> Self { + Self { error_behavior: RenderErrorBehavior::ReturnEmpty } + } } impl RenderErrorBehavior { diff --git a/crates/yaak-ws/src/render.rs b/crates/yaak-ws/src/render.rs index 1b9c8961..151b41fd 100644 --- a/crates/yaak-ws/src/render.rs +++ b/crates/yaak-ws/src/render.rs @@ -16,6 +16,9 @@ pub async fn render_websocket_request( let mut url_parameters = Vec::new(); for p in r.url_parameters.clone() { + if !p.enabled { + continue; + } url_parameters.push(HttpUrlParameter { enabled: p.enabled, name: parse_and_render(&p.name, vars, cb, opt).await?, @@ -26,6 +29,9 @@ pub async fn render_websocket_request( let mut headers = Vec::new(); for p in r.headers.clone() { + if !p.enabled { + continue; + } headers.push(HttpRequestHeader { enabled: p.enabled, name: parse_and_render(&p.name, vars, cb, opt).await?, diff --git a/flatpak/app.yaak.Yaak.metainfo.xml b/flatpak/app.yaak.Yaak.metainfo.xml new file mode 100644 index 00000000..87a9772c --- /dev/null +++ b/flatpak/app.yaak.Yaak.metainfo.xml @@ -0,0 +1,57 @@ + + + app.yaak.Yaak + + Yaak + An offline, Git friendly API Client + + + Yaak + + + MIT + MIT + + https://yaak.app + https://yaak.app/feedback + https://yaak.app/feedback + https://github.com/mountain-loop/yaak + + +

+ A fast, privacy-first API client for REST, GraphQL, SSE, WebSocket, + and gRPC — built with Tauri, Rust, and React. +

+

Features include:

+
    +
  • REST, GraphQL, SSE, WebSocket, and gRPC support
  • +
  • Local-only data, secrets encryption, and zero telemetry
  • +
  • Git-friendly plain-text project storage
  • +
  • Environment variables and template functions
  • +
  • Request chaining and dynamic values
  • +
  • OAuth 2.0, Bearer, Basic, API Key, AWS, JWT, and NTLM authentication
  • +
  • Import from cURL, Postman, Insomnia, and OpenAPI
  • +
  • Extensible plugin system
  • +
+
+ + app.yaak.Yaak.desktop + + + #8b32ff + #c293ff + + + + + + + Crafting an API request + https://assets.yaak.app/uploads/screenshot-BLG1w_2310x1326.png + + + + + + +
diff --git a/flatpak/fix-lockfile.mjs b/flatpak/fix-lockfile.mjs new file mode 100644 index 00000000..e8adc89c --- /dev/null +++ b/flatpak/fix-lockfile.mjs @@ -0,0 +1,75 @@ +#!/usr/bin/env node + +// Adds missing `resolved` and `integrity` fields to npm package-lock.json. +// +// npm sometimes omits these fields for nested dependencies inside workspace +// packages. This breaks offline installs and tools like flatpak-node-generator +// that need explicit tarball URLs for every package. +// +// Based on https://github.com/grant-dennison/npm-package-lock-add-resolved +// (MIT License, Copyright (c) 2024 Grant Dennison) + +import { readFile, writeFile } from "node:fs/promises"; +import { get } from "node:https"; + +const lockfilePath = process.argv[2] || "package-lock.json"; + +function fetchJson(url) { + return new Promise((resolve, reject) => { + get(url, (res) => { + let data = ""; + res.on("data", (chunk) => { + data += chunk; + }); + res.on("end", () => { + if (res.statusCode === 200) { + resolve(JSON.parse(data)); + } else { + reject(`${url} returned ${res.statusCode} ${res.statusMessage}`); + } + }); + res.on("error", reject); + }).on("error", reject); + }); +} + +async function fillResolved(name, p) { + const version = p.version.replace(/^.*@/, ""); + console.log(`Retrieving metadata for ${name}@${version}`); + const metadataUrl = `https://registry.npmjs.com/${name}/${version}`; + const metadata = await fetchJson(metadataUrl); + p.resolved = metadata.dist.tarball; + p.integrity = metadata.dist.integrity; +} + +let changesMade = false; + +async function fillAllResolved(packages) { + for (const packagePath in packages) { + if (packagePath === "") continue; + if (!packagePath.includes("node_modules/")) continue; + const p = packages[packagePath]; + if (p.link) continue; + if (!p.inBundle && !p.bundled && (!p.resolved || !p.integrity)) { + const packageName = + p.name || + /^npm:(.+?)@.+$/.exec(p.version)?.[1] || + packagePath.replace(/^.*node_modules\/(?=.+?$)/, ""); + await fillResolved(packageName, p); + changesMade = true; + } + } +} + +const oldContents = await readFile(lockfilePath, "utf-8"); +const packageLock = JSON.parse(oldContents); + +await fillAllResolved(packageLock.packages ?? []); + +if (changesMade) { + const newContents = JSON.stringify(packageLock, null, 2) + "\n"; + await writeFile(lockfilePath, newContents); + console.log(`Updated ${lockfilePath}`); +} else { + console.log("No changes needed."); +} diff --git a/flatpak/generate-sources.sh b/flatpak/generate-sources.sh new file mode 100755 index 00000000..216d0a4d --- /dev/null +++ b/flatpak/generate-sources.sh @@ -0,0 +1,48 @@ +#!/usr/bin/env bash +# +# Generate offline dependency source files for Flatpak builds. +# +# Prerequisites: +# pip install flatpak-node-generator tomlkit aiohttp +# Clone https://github.com/flatpak/flatpak-builder-tools (for cargo generator) +# +# Usage: +# ./flatpak/generate-sources.sh +# ./flatpak/generate-sources.sh ../flathub-repo + +set -euo pipefail + +SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" +REPO_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)" + +if [ $# -lt 1 ]; then + echo "Usage: $0 " + echo "Example: $0 ../flathub-repo" + exit 1 +fi + +FLATHUB_REPO="$(cd "$1" && pwd)" + +python3 "$SCRIPT_DIR/flatpak-builder-tools/cargo/flatpak-cargo-generator.py" \ + -o "$FLATHUB_REPO/cargo-sources.json" "$REPO_ROOT/Cargo.lock" + +TMPDIR=$(mktemp -d) +trap 'rm -rf "$TMPDIR"' EXIT + +cp "$REPO_ROOT/package-lock.json" "$TMPDIR/package-lock.json" +cp "$REPO_ROOT/package.json" "$TMPDIR/package.json" + +node "$SCRIPT_DIR/fix-lockfile.mjs" "$TMPDIR/package-lock.json" + +node -e " + const fs = require('fs'); + const p = process.argv[1]; + const d = JSON.parse(fs.readFileSync(p, 'utf-8')); + for (const [name, info] of Object.entries(d.packages || {})) { + if (name && (info.link || !info.resolved)) delete d.packages[name]; + } + fs.writeFileSync(p, JSON.stringify(d, null, 2)); +" "$TMPDIR/package-lock.json" + +flatpak-node-generator --no-requests-cache \ + -o "$FLATHUB_REPO/node-sources.json" npm "$TMPDIR/package-lock.json" diff --git a/flatpak/update-manifest.sh b/flatpak/update-manifest.sh new file mode 100755 index 00000000..8ad59f70 --- /dev/null +++ b/flatpak/update-manifest.sh @@ -0,0 +1,86 @@ +#!/usr/bin/env bash +# +# Update the Flathub repo for a new release. +# +# Usage: +# ./flatpak/update-manifest.sh +# ./flatpak/update-manifest.sh v2026.2.0 ../flathub-repo + +set -euo pipefail + +SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" +REPO_ROOT="$(cd "$SCRIPT_DIR/.." && pwd)" + +if [ $# -lt 2 ]; then + echo "Usage: $0 " + echo "Example: $0 v2026.2.0 ../flathub-repo" + exit 1 +fi + +VERSION_TAG="$1" +VERSION="${VERSION_TAG#v}" +FLATHUB_REPO="$(cd "$2" && pwd)" +MANIFEST="$FLATHUB_REPO/app.yaak.Yaak.yml" +METAINFO="$SCRIPT_DIR/app.yaak.Yaak.metainfo.xml" + +if [[ "$VERSION" == *-* ]]; then + echo "Skipping pre-release version '$VERSION_TAG' (only stable releases are published to Flathub)" + exit 0 +fi + +REPO="mountain-loop/yaak" +COMMIT=$(git ls-remote "https://github.com/$REPO.git" "refs/tags/$VERSION_TAG" | cut -f1) + +if [ -z "$COMMIT" ]; then + echo "Error: Could not resolve commit for tag $VERSION_TAG" + exit 1 +fi + +echo "Tag: $VERSION_TAG" +echo "Commit: $COMMIT" + +# Update git tag and commit in the manifest +sed -i "s|tag: v.*|tag: $VERSION_TAG|" "$MANIFEST" +sed -i "s|commit: .*|commit: $COMMIT|" "$MANIFEST" +echo "Updated manifest tag and commit." + +# Regenerate offline dependency sources from the tagged lockfiles +TMPDIR=$(mktemp -d) +trap 'rm -rf "$TMPDIR"' EXIT + +echo "Fetching lockfiles from $VERSION_TAG..." +curl -fsSL "https://raw.githubusercontent.com/$REPO/$VERSION_TAG/Cargo.lock" -o "$TMPDIR/Cargo.lock" +curl -fsSL "https://raw.githubusercontent.com/$REPO/$VERSION_TAG/package-lock.json" -o "$TMPDIR/package-lock.json" +curl -fsSL "https://raw.githubusercontent.com/$REPO/$VERSION_TAG/package.json" -o "$TMPDIR/package.json" + +echo "Generating cargo-sources.json..." +python3 "$SCRIPT_DIR/flatpak-builder-tools/cargo/flatpak-cargo-generator.py" \ + -o "$FLATHUB_REPO/cargo-sources.json" "$TMPDIR/Cargo.lock" + +echo "Generating node-sources.json..." +node "$SCRIPT_DIR/fix-lockfile.mjs" "$TMPDIR/package-lock.json" + +node -e " + const fs = require('fs'); + const p = process.argv[1]; + const d = JSON.parse(fs.readFileSync(p, 'utf-8')); + for (const [name, info] of Object.entries(d.packages || {})) { + if (name && (info.link || !info.resolved)) delete d.packages[name]; + } + fs.writeFileSync(p, JSON.stringify(d, null, 2)); +" "$TMPDIR/package-lock.json" + +flatpak-node-generator --no-requests-cache \ + -o "$FLATHUB_REPO/node-sources.json" npm "$TMPDIR/package-lock.json" + +# Update metainfo with new release +TODAY=$(date +%Y-%m-%d) +sed -i "s| | \n |" "$METAINFO" +echo "Updated metainfo with release $VERSION." + +echo "" +echo "Done! Review the changes:" +echo " $MANIFEST" +echo " $METAINFO" +echo " $FLATHUB_REPO/cargo-sources.json" +echo " $FLATHUB_REPO/node-sources.json" diff --git a/package-lock.json b/package-lock.json index 0ad5040d..a6112490 100644 --- a/package-lock.json +++ b/package-lock.json @@ -12,7 +12,7 @@ "packages/plugin-runtime", "packages/plugin-runtime-types", "plugins-external/mcp-server", - "plugins-external/template-function-faker", + "plugins-external/faker", "plugins-external/httpsnippet", "plugins/action-copy-curl", "plugins/action-copy-grpcurl", @@ -3922,13 +3922,6 @@ "@types/react": "*" } }, - "node_modules/@types/shell-quote": { - "version": "1.7.5", - "resolved": "https://registry.npmjs.org/@types/shell-quote/-/shell-quote-1.7.5.tgz", - "integrity": "sha512-+UE8GAGRPbJVQDdxi16dgadcBfQ+KG2vgZhV1+3A1XmHbmwcdwhCUwIdy+d3pAGrbvgRoVSjeI9vOWyq376Yzw==", - "dev": true, - "license": "MIT" - }, "node_modules/@types/unist": { "version": "3.0.3", "resolved": "https://registry.npmjs.org/@types/unist/-/unist-3.0.3.tgz", @@ -4160,6 +4153,10 @@ "resolved": "plugins/auth-oauth2", "link": true }, + "node_modules/@yaak/faker": { + "resolved": "plugins-external/faker", + "link": true + }, "node_modules/@yaak/filter-jsonpath": { "resolved": "plugins/filter-jsonpath", "link": true @@ -13405,6 +13402,7 @@ "version": "1.8.3", "resolved": "https://registry.npmjs.org/shell-quote/-/shell-quote-1.8.3.tgz", "integrity": "sha512-ObmnIF4hXNg1BqhnHmgbDETF8dLPCggZWBjkQfhZpbszZnYur5DUljTcCHii5LC3J5E0yeO/1LIMyH+UvHQgyw==", + "dev": true, "license": "MIT", "engines": { "node": ">= 0.4" @@ -13413,6 +13411,12 @@ "url": "https://github.com/sponsors/ljharb" } }, + "node_modules/shlex": { + "version": "3.0.0", + "resolved": "https://registry.npmjs.org/shlex/-/shlex-3.0.0.tgz", + "integrity": "sha512-jHPXQQk9d/QXCvJuLPYMOYWez3c43sORAgcIEoV7bFv5AJSJRAOyw5lQO12PMfd385qiLRCaDt7OtEzgrIGZUA==", + "license": "MIT" + }, "node_modules/should": { "version": "13.2.3", "resolved": "https://registry.npmjs.org/should/-/should-13.2.3.tgz", @@ -15953,9 +15957,36 @@ "undici-types": "~7.16.0" } }, + "plugins-external/faker": { + "name": "@yaak/faker", + "version": "1.1.1", + "dependencies": { + "@faker-js/faker": "^10.1.0" + }, + "devDependencies": { + "@types/node": "^25.0.3", + "typescript": "^5.9.3" + } + }, + "plugins-external/faker/node_modules/@faker-js/faker": { + "version": "10.3.0", + "resolved": "https://registry.npmjs.org/@faker-js/faker/-/faker-10.3.0.tgz", + "integrity": "sha512-It0Sne6P3szg7JIi6CgKbvTZoMjxBZhcv91ZrqrNuaZQfB5WoqYYbzCUOq89YR+VY8juY9M1vDWmDDa2TzfXCw==", + "funding": [ + { + "type": "opencollective", + "url": "https://opencollective.com/fakerjs" + } + ], + "license": "MIT", + "engines": { + "node": "^20.19.0 || ^22.13.0 || ^23.5.0 || >=24.0.0", + "npm": ">=10" + } + }, "plugins-external/httpsnippet": { "name": "@yaak/httpsnippet", - "version": "1.0.0", + "version": "1.0.3", "dependencies": { "@readme/httpsnippet": "^11.0.0" }, @@ -15983,7 +16014,7 @@ }, "plugins-external/mcp-server": { "name": "@yaak/mcp-server", - "version": "0.1.7", + "version": "0.2.1", "dependencies": { "@hono/mcp": "^0.2.3", "@hono/node-server": "^1.19.7", @@ -16080,10 +16111,7 @@ "name": "@yaak/importer-curl", "version": "0.1.0", "dependencies": { - "shell-quote": "^1.8.1" - }, - "devDependencies": { - "@types/shell-quote": "^1.7.5" + "shlex": "^3.0.0" } }, "plugins/importer-insomnia": { diff --git a/package.json b/package.json index 2501b08a..2f03a786 100644 --- a/package.json +++ b/package.json @@ -11,7 +11,7 @@ "packages/plugin-runtime", "packages/plugin-runtime-types", "plugins-external/mcp-server", - "plugins-external/template-function-faker", + "plugins-external/faker", "plugins-external/httpsnippet", "plugins/action-copy-curl", "plugins/action-copy-grpcurl", diff --git a/plugins-external/faker/tests/__snapshots__/init.test.ts.snap b/plugins-external/faker/tests/__snapshots__/init.test.ts.snap new file mode 100644 index 00000000..adc26a67 --- /dev/null +++ b/plugins-external/faker/tests/__snapshots__/init.test.ts.snap @@ -0,0 +1,233 @@ +// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html + +exports[`template-function-faker > exports all expected template functions 1`] = ` +[ + "faker.airline.aircraftType", + "faker.airline.airline", + "faker.airline.airplane", + "faker.airline.airport", + "faker.airline.flightNumber", + "faker.airline.recordLocator", + "faker.airline.seat", + "faker.animal.bear", + "faker.animal.bird", + "faker.animal.cat", + "faker.animal.cetacean", + "faker.animal.cow", + "faker.animal.crocodilia", + "faker.animal.dog", + "faker.animal.fish", + "faker.animal.horse", + "faker.animal.insect", + "faker.animal.lion", + "faker.animal.petName", + "faker.animal.rabbit", + "faker.animal.rodent", + "faker.animal.snake", + "faker.animal.type", + "faker.color.cmyk", + "faker.color.colorByCSSColorSpace", + "faker.color.cssSupportedFunction", + "faker.color.cssSupportedSpace", + "faker.color.hsl", + "faker.color.human", + "faker.color.hwb", + "faker.color.lab", + "faker.color.lch", + "faker.color.rgb", + "faker.color.space", + "faker.commerce.department", + "faker.commerce.isbn", + "faker.commerce.price", + "faker.commerce.product", + "faker.commerce.productAdjective", + "faker.commerce.productDescription", + "faker.commerce.productMaterial", + "faker.commerce.productName", + "faker.commerce.upc", + "faker.company.buzzAdjective", + "faker.company.buzzNoun", + "faker.company.buzzPhrase", + "faker.company.buzzVerb", + "faker.company.catchPhrase", + "faker.company.catchPhraseAdjective", + "faker.company.catchPhraseDescriptor", + "faker.company.catchPhraseNoun", + "faker.company.name", + "faker.database.collation", + "faker.database.column", + "faker.database.engine", + "faker.database.mongodbObjectId", + "faker.database.type", + "faker.date.anytime", + "faker.date.between", + "faker.date.betweens", + "faker.date.birthdate", + "faker.date.future", + "faker.date.month", + "faker.date.past", + "faker.date.recent", + "faker.date.soon", + "faker.date.timeZone", + "faker.date.weekday", + "faker.finance.accountName", + "faker.finance.accountNumber", + "faker.finance.amount", + "faker.finance.bic", + "faker.finance.bitcoinAddress", + "faker.finance.creditCardCVV", + "faker.finance.creditCardIssuer", + "faker.finance.creditCardNumber", + "faker.finance.currency", + "faker.finance.currencyCode", + "faker.finance.currencyName", + "faker.finance.currencyNumericCode", + "faker.finance.currencySymbol", + "faker.finance.ethereumAddress", + "faker.finance.iban", + "faker.finance.litecoinAddress", + "faker.finance.pin", + "faker.finance.routingNumber", + "faker.finance.transactionDescription", + "faker.finance.transactionType", + "faker.git.branch", + "faker.git.commitDate", + "faker.git.commitEntry", + "faker.git.commitMessage", + "faker.git.commitSha", + "faker.hacker.abbreviation", + "faker.hacker.adjective", + "faker.hacker.ingverb", + "faker.hacker.noun", + "faker.hacker.phrase", + "faker.hacker.verb", + "faker.image.avatar", + "faker.image.avatarGitHub", + "faker.image.dataUri", + "faker.image.personPortrait", + "faker.image.url", + "faker.image.urlLoremFlickr", + "faker.image.urlPicsumPhotos", + "faker.internet.displayName", + "faker.internet.domainName", + "faker.internet.domainSuffix", + "faker.internet.domainWord", + "faker.internet.email", + "faker.internet.emoji", + "faker.internet.exampleEmail", + "faker.internet.httpMethod", + "faker.internet.httpStatusCode", + "faker.internet.ip", + "faker.internet.ipv4", + "faker.internet.ipv6", + "faker.internet.jwt", + "faker.internet.jwtAlgorithm", + "faker.internet.mac", + "faker.internet.password", + "faker.internet.port", + "faker.internet.protocol", + "faker.internet.url", + "faker.internet.userAgent", + "faker.internet.username", + "faker.location.buildingNumber", + "faker.location.cardinalDirection", + "faker.location.city", + "faker.location.continent", + "faker.location.country", + "faker.location.countryCode", + "faker.location.county", + "faker.location.direction", + "faker.location.language", + "faker.location.latitude", + "faker.location.longitude", + "faker.location.nearbyGPSCoordinate", + "faker.location.ordinalDirection", + "faker.location.secondaryAddress", + "faker.location.state", + "faker.location.street", + "faker.location.streetAddress", + "faker.location.timeZone", + "faker.location.zipCode", + "faker.lorem.lines", + "faker.lorem.paragraph", + "faker.lorem.paragraphs", + "faker.lorem.sentence", + "faker.lorem.sentences", + "faker.lorem.slug", + "faker.lorem.text", + "faker.lorem.word", + "faker.lorem.words", + "faker.music.album", + "faker.music.artist", + "faker.music.genre", + "faker.music.songName", + "faker.number.bigInt", + "faker.number.binary", + "faker.number.float", + "faker.number.hex", + "faker.number.int", + "faker.number.octal", + "faker.number.romanNumeral", + "faker.person.bio", + "faker.person.firstName", + "faker.person.fullName", + "faker.person.gender", + "faker.person.jobArea", + "faker.person.jobDescriptor", + "faker.person.jobTitle", + "faker.person.jobType", + "faker.person.lastName", + "faker.person.middleName", + "faker.person.prefix", + "faker.person.sex", + "faker.person.sexType", + "faker.person.suffix", + "faker.person.zodiacSign", + "faker.phone.imei", + "faker.phone.number", + "faker.science.chemicalElement", + "faker.science.unit", + "faker.string.alpha", + "faker.string.alphanumeric", + "faker.string.binary", + "faker.string.fromCharacters", + "faker.string.hexadecimal", + "faker.string.nanoid", + "faker.string.numeric", + "faker.string.octal", + "faker.string.sample", + "faker.string.symbol", + "faker.string.ulid", + "faker.string.uuid", + "faker.system.commonFileExt", + "faker.system.commonFileName", + "faker.system.commonFileType", + "faker.system.cron", + "faker.system.directoryPath", + "faker.system.fileExt", + "faker.system.fileName", + "faker.system.filePath", + "faker.system.fileType", + "faker.system.mimeType", + "faker.system.networkInterface", + "faker.system.semver", + "faker.vehicle.bicycle", + "faker.vehicle.color", + "faker.vehicle.fuel", + "faker.vehicle.manufacturer", + "faker.vehicle.model", + "faker.vehicle.type", + "faker.vehicle.vehicle", + "faker.vehicle.vin", + "faker.vehicle.vrm", + "faker.word.adjective", + "faker.word.adverb", + "faker.word.conjunction", + "faker.word.interjection", + "faker.word.noun", + "faker.word.preposition", + "faker.word.sample", + "faker.word.verb", + "faker.word.words", +] +`; diff --git a/plugins-external/faker/tests/init.test.ts b/plugins-external/faker/tests/init.test.ts index e16b5bd1..e344e5ae 100644 --- a/plugins-external/faker/tests/init.test.ts +++ b/plugins-external/faker/tests/init.test.ts @@ -1,9 +1,12 @@ import { describe, expect, it } from 'vitest'; -describe('formatDatetime', () => { - it('returns formatted current date', async () => { - // Ensure the plugin imports properly - const faker = await import('../src/index'); - expect(faker.plugin.templateFunctions?.length).toBe(226); +describe('template-function-faker', () => { + it('exports all expected template functions', async () => { + const { plugin } = await import('../src/index'); + const names = plugin.templateFunctions?.map((fn) => fn.name).sort() ?? []; + + // Snapshot the full list of exported function names so we catch any + // accidental additions, removals, or renames across faker upgrades. + expect(names).toMatchSnapshot(); }); }); diff --git a/plugins/auth-oauth2/package.json b/plugins/auth-oauth2/package.json index faffe67e..55b69350 100644 --- a/plugins/auth-oauth2/package.json +++ b/plugins/auth-oauth2/package.json @@ -13,5 +13,11 @@ "build": "yaakcli build", "dev": "yaakcli dev", "test": "vitest --run tests" + }, + "dependencies": { + "jsonwebtoken": "^9.0.2" + }, + "devDependencies": { + "@types/jsonwebtoken": "^9.0.7" } } diff --git a/plugins/auth-oauth2/src/fetchAccessToken.ts b/plugins/auth-oauth2/src/fetchAccessToken.ts index 3c5f4761..56e0335f 100644 --- a/plugins/auth-oauth2/src/fetchAccessToken.ts +++ b/plugins/auth-oauth2/src/fetchAccessToken.ts @@ -4,26 +4,16 @@ import type { AccessTokenRawResponse } from './store'; export async function fetchAccessToken( ctx: Context, - { - accessTokenUrl, - scope, - audience, - params, - grantType, - credentialsInBody, - clientId, - clientSecret, - }: { + args: { clientId: string; - clientSecret: string; grantType: string; accessTokenUrl: string; scope: string | null; audience: string | null; - credentialsInBody: boolean; params: HttpUrlParameter[]; - }, + } & ({ clientAssertion: string } | { clientSecret: string; credentialsInBody: boolean }), ): Promise { + const { clientId, grantType, accessTokenUrl, scope, audience, params } = args; console.log('[oauth2] Getting access token', accessTokenUrl); const httpRequest: Partial = { method: 'POST', @@ -34,7 +24,10 @@ export async function fetchAccessToken( }, headers: [ { name: 'User-Agent', value: 'yaak' }, - { name: 'Accept', value: 'application/x-www-form-urlencoded, application/json' }, + { + name: 'Accept', + value: 'application/x-www-form-urlencoded, application/json', + }, { name: 'Content-Type', value: 'application/x-www-form-urlencoded' }, ], }; @@ -42,11 +35,24 @@ export async function fetchAccessToken( if (scope) httpRequest.body?.form.push({ name: 'scope', value: scope }); if (audience) httpRequest.body?.form.push({ name: 'audience', value: audience }); - if (credentialsInBody) { + if ('clientAssertion' in args) { httpRequest.body?.form.push({ name: 'client_id', value: clientId }); - httpRequest.body?.form.push({ name: 'client_secret', value: clientSecret }); + httpRequest.body?.form.push({ + name: 'client_assertion_type', + value: 'urn:ietf:params:oauth:client-assertion-type:jwt-bearer', + }); + httpRequest.body?.form.push({ + name: 'client_assertion', + value: args.clientAssertion, + }); + } else if (args.credentialsInBody) { + httpRequest.body?.form.push({ name: 'client_id', value: clientId }); + httpRequest.body?.form.push({ + name: 'client_secret', + value: args.clientSecret, + }); } else { - const value = `Basic ${Buffer.from(`${clientId}:${clientSecret}`).toString('base64')}`; + const value = `Basic ${Buffer.from(`${clientId}:${args.clientSecret}`).toString('base64')}`; httpRequest.headers?.push({ name: 'Authorization', value }); } diff --git a/plugins/auth-oauth2/src/grants/clientCredentials.ts b/plugins/auth-oauth2/src/grants/clientCredentials.ts index 290dbb80..3658a04c 100644 --- a/plugins/auth-oauth2/src/grants/clientCredentials.ts +++ b/plugins/auth-oauth2/src/grants/clientCredentials.ts @@ -1,9 +1,99 @@ +import { createPrivateKey, randomUUID } from 'node:crypto'; import type { Context } from '@yaakapp/api'; +import jwt, { type Algorithm } from 'jsonwebtoken'; import { fetchAccessToken } from '../fetchAccessToken'; import type { TokenStoreArgs } from '../store'; import { getToken, storeToken } from '../store'; import { isTokenExpired } from '../util'; +export const jwtAlgorithms = [ + 'HS256', + 'HS384', + 'HS512', + 'RS256', + 'RS384', + 'RS512', + 'PS256', + 'PS384', + 'PS512', + 'ES256', + 'ES384', + 'ES512', + 'none', +] as const; + +export const defaultJwtAlgorithm = jwtAlgorithms[0]; + +/** + * Build a signed JWT for the client_assertion parameter (RFC 7523). + * + * The `secret` value is auto-detected as one of: + * - **JWK** – a JSON string containing a private-key object (has a `kty` field). + * - **PEM** – a string whose trimmed form starts with `-----`. + * - **HMAC secret** – anything else, used as-is for HS* algorithms. + */ +function buildClientAssertionJwt(params: { + clientId: string; + accessTokenUrl: string; + secret: string; + algorithm: Algorithm; +}): string { + const { clientId, accessTokenUrl, secret, algorithm } = params; + + const isHmac = algorithm.startsWith('HS') || algorithm === 'none'; + + // Resolve the signing key depending on format + let signingKey: jwt.Secret; + let kid: string | undefined; + + const trimmed = secret.trim(); + + if (isHmac) { + // HMAC algorithms use the raw secret (string or Buffer) + signingKey = secret; + } else if (trimmed.startsWith('{')) { + // Looks like JSON - treat as JWK. There is surely a better way to detect JWK vs a raw secret, but this should work in most cases. + let jwk: any; + try { + jwk = JSON.parse(trimmed); + } catch { + throw new Error('Client Assertion secret looks like JSON but is not valid'); + } + + kid = jwk?.kid; + signingKey = createPrivateKey({ key: jwk, format: 'jwk' }); + } else if (trimmed.startsWith('-----')) { + // PEM-encoded key + signingKey = createPrivateKey({ key: trimmed, format: 'pem' }); + } else { + throw new Error( + 'Client Assertion secret must be a JWK JSON object, a PEM-encoded key ' + + '(starting with -----), or a raw secret for HMAC algorithms.', + ); + } + + const now = Math.floor(Date.now() / 1000); + const payload = { + iss: clientId, + sub: clientId, + aud: accessTokenUrl, + iat: now, + exp: now + 300, // 5 minutes + jti: randomUUID(), + }; + + // Build the JWT header; include "kid" when available + const header: jwt.JwtHeader = { alg: algorithm, typ: 'JWT' }; + if (kid) { + header.kid = kid; + } + + return jwt.sign(JSON.stringify(payload), signingKey, { + algorithm: algorithm as jwt.Algorithm, + header, + }); +} + export async function getClientCredentials( ctx: Context, contextId: string, @@ -14,6 +104,10 @@ export async function getClientCredentials( scope, audience, credentialsInBody, + clientAssertionSecret, + clientAssertionSecretBase64, + clientCredentialsMethod, + clientAssertionAlgorithm, }: { accessTokenUrl: string; clientId: string; @@ -21,6 +115,10 @@ export async function getClientCredentials( scope: string | null; audience: string | null; credentialsInBody: boolean; + clientAssertionSecret: string; + clientAssertionSecretBase64: boolean; + clientCredentialsMethod: string; + clientAssertionAlgorithm: string; }, ) { const tokenArgs: TokenStoreArgs = { @@ -34,16 +132,38 @@ export async function getClientCredentials( return token; } - const response = await fetchAccessToken(ctx, { + const common: Omit< + Parameters[1], + 'clientAssertion' | 'clientSecret' | 'credentialsInBody' + > = { grantType: 'client_credentials', accessTokenUrl, audience, clientId, - clientSecret, scope, - credentialsInBody, params: [], - }); + }; + + const fetchParams: Parameters[1] = + clientCredentialsMethod === 'client_assertion' + ? { + ...common, + clientAssertion: buildClientAssertionJwt({ + clientId, + algorithm: clientAssertionAlgorithm as Algorithm, + accessTokenUrl, + secret: clientAssertionSecretBase64 + ? Buffer.from(clientAssertionSecret, 'base64').toString('utf-8') + : clientAssertionSecret, + }), + } + : { + ...common, + clientSecret, + credentialsInBody, + }; + + const response = await fetchAccessToken(ctx, fetchParams); return storeToken(ctx, tokenArgs, response); } diff --git a/plugins/auth-oauth2/src/index.ts b/plugins/auth-oauth2/src/index.ts index 8b337b8c..6dd05c90 100644 --- a/plugins/auth-oauth2/src/index.ts +++ b/plugins/auth-oauth2/src/index.ts @@ -5,6 +5,7 @@ import type { JsonPrimitive, PluginDefinition, } from '@yaakapp/api'; +import type { Algorithm } from 'jsonwebtoken'; import { DEFAULT_LOCALHOST_PORT, HOSTED_CALLBACK_URL, stopActiveServer } from './callbackServer'; import { type CallbackType, @@ -14,7 +15,11 @@ import { PKCE_PLAIN, PKCE_SHA256, } from './grants/authorizationCode'; -import { getClientCredentials } from './grants/clientCredentials'; +import { + defaultJwtAlgorithm, + getClientCredentials, + jwtAlgorithms, +} from './grants/clientCredentials'; import { getImplicit } from './grants/implicit'; import { getPassword } from './grants/password'; import type { AccessToken, TokenStoreArgs } from './store'; @@ -97,7 +102,10 @@ export const plugin: PluginDefinition = { }; const token = await getToken(ctx, tokenArgs); if (token == null) { - await ctx.toast.show({ message: 'No token to copy', color: 'warning' }); + await ctx.toast.show({ + message: 'No token to copy', + color: 'warning', + }); } else { await ctx.clipboard.copyText(token.response.access_token); await ctx.toast.show({ @@ -118,9 +126,15 @@ export const plugin: PluginDefinition = { clientId: stringArg(values, 'clientId'), }; if (await deleteToken(ctx, tokenArgs)) { - await ctx.toast.show({ message: 'Token deleted', color: 'success' }); + await ctx.toast.show({ + message: 'Token deleted', + color: 'success', + }); } else { - await ctx.toast.show({ message: 'No token to delete', color: 'warning' }); + await ctx.toast.show({ + message: 'No token to delete', + color: 'warning', + }); } }, }, @@ -139,6 +153,19 @@ export const plugin: PluginDefinition = { defaultValue: defaultGrantType, options: grantTypes, }, + { + type: 'select', + name: 'clientCredentialsMethod', + label: 'Authentication Method', + description: + '"Client Secret" sends client_secret. \n' + '"Client Assertion" sends a signed JWT.', + defaultValue: 'client_secret', + options: [ + { label: 'Client Secret', value: 'client_secret' }, + { label: 'Client Assertion', value: 'client_assertion' }, + ], + dynamic: hiddenIfNot(['client_credentials']), + }, { type: 'text', name: 'clientId', @@ -151,7 +178,47 @@ export const plugin: PluginDefinition = { label: 'Client Secret', optional: true, password: true, - dynamic: hiddenIfNot(['authorization_code', 'password', 'client_credentials']), + dynamic: hiddenIfNot( + ['authorization_code', 'password', 'client_credentials'], + (values) => values.clientCredentialsMethod === 'client_secret', + ), + }, + { + type: 'select', + name: 'clientAssertionAlgorithm', + label: 'JWT Algorithm', + defaultValue: defaultJwtAlgorithm, + options: jwtAlgorithms.map((value) => ({ + label: value === 'none' ? 'None' : value, + value, + })), + dynamic: hiddenIfNot( + ['client_credentials'], + ({ clientCredentialsMethod }) => clientCredentialsMethod === 'client_assertion', + ), + }, + { + type: 'text', + name: 'clientAssertionSecret', + label: 'JWT Secret', + description: + 'Can be HMAC, PEM or JWK. Make sure you pick the correct algorithm type above.', + password: true, + optional: true, + multiLine: true, + dynamic: hiddenIfNot( + ['client_credentials'], + ({ clientCredentialsMethod }) => clientCredentialsMethod === 'client_assertion', + ), + }, + { + type: 'checkbox', + name: 'clientAssertionSecretBase64', + label: 'JWT secret is base64 encoded', + dynamic: hiddenIfNot( + ['client_credentials'], + ({ clientCredentialsMethod }) => clientCredentialsMethod === 'client_assertion', + ), }, { type: 'text', @@ -160,7 +227,10 @@ export const plugin: PluginDefinition = { label: 'Authorization URL', dynamic: hiddenIfNot(['authorization_code', 'implicit']), placeholder: authorizationUrls[0], - completionOptions: authorizationUrls.map((url) => ({ label: url, value: url })), + completionOptions: authorizationUrls.map((url) => ({ + label: url, + value: url, + })), }, { type: 'text', @@ -169,7 +239,10 @@ export const plugin: PluginDefinition = { label: 'Access Token URL', placeholder: accessTokenUrls[0], dynamic: hiddenIfNot(['authorization_code', 'password', 'client_credentials']), - completionOptions: accessTokenUrls.map((url) => ({ label: url, value: url })), + completionOptions: accessTokenUrls.map((url) => ({ + label: url, + value: url, + })), }, { type: 'banner', @@ -186,7 +259,8 @@ export const plugin: PluginDefinition = { { type: 'text', name: 'redirectUri', - label: 'Redirect URI', + label: 'Redirect URI (can be any valid URL)', + placeholder: 'https://mysite.example.com/oauth/callback', description: 'URI the OAuth provider redirects to after authorization. Yaak intercepts this automatically in its embedded browser so any valid URI will work.', optional: true, @@ -383,6 +457,11 @@ export const plugin: PluginDefinition = { { label: 'In Request Body', value: 'body' }, { label: 'As Basic Authentication', value: 'basic' }, ], + dynamic: (_ctx: Context, { values }: GetHttpAuthenticationConfigRequest) => ({ + hidden: + values.grantType === 'client_credentials' && + values.clientCredentialsMethod === 'client_assertion', + }), }, ], }, @@ -484,7 +563,11 @@ export const plugin: PluginDefinition = { ? accessTokenUrl : `https://${accessTokenUrl}`, clientId: stringArg(values, 'clientId'), + clientAssertionAlgorithm: stringArg(values, 'clientAssertionAlgorithm') as Algorithm, clientSecret: stringArg(values, 'clientSecret'), + clientCredentialsMethod: stringArg(values, 'clientCredentialsMethod'), + clientAssertionSecret: stringArg(values, 'clientAssertionSecret'), + clientAssertionSecretBase64: !!values.clientAssertionSecretBase64, scope: stringArgOrNull(values, 'scope'), audience: stringArgOrNull(values, 'audience'), credentialsInBody, diff --git a/plugins/importer-curl/package.json b/plugins/importer-curl/package.json index abb89b97..645204ad 100644 --- a/plugins/importer-curl/package.json +++ b/plugins/importer-curl/package.json @@ -10,9 +10,6 @@ "test": "vitest --run tests" }, "dependencies": { - "shell-quote": "^1.8.1" - }, - "devDependencies": { - "@types/shell-quote": "^1.7.5" + "shlex": "^3.0.0" } } diff --git a/plugins/importer-curl/src/index.ts b/plugins/importer-curl/src/index.ts index f8b0606e..23542c1e 100644 --- a/plugins/importer-curl/src/index.ts +++ b/plugins/importer-curl/src/index.ts @@ -7,8 +7,7 @@ import type { PluginDefinition, Workspace, } from '@yaakapp/api'; -import type { ControlOperator, ParseEntry } from 'shell-quote'; -import { parse } from 'shell-quote'; +import { split } from 'shlex'; type AtLeast = Partial & Pick; @@ -56,31 +55,89 @@ export const plugin: PluginDefinition = { }; /** - * Decodes escape sequences in shell $'...' strings - * Handles Unicode escape sequences (\uXXXX) and common escape codes + * Splits raw input into individual shell command strings. + * Handles line continuations, semicolons, and newline-separated curl commands. */ -function decodeShellString(str: string): string { - return str - .replace(/\\u([0-9a-fA-F]{4})/g, (_, hex) => String.fromCharCode(parseInt(hex, 16))) - .replace(/\\x([0-9a-fA-F]{2})/g, (_, hex) => String.fromCharCode(parseInt(hex, 16))) - .replace(/\\n/g, '\n') - .replace(/\\r/g, '\r') - .replace(/\\t/g, '\t') - .replace(/\\'/g, "'") - .replace(/\\"/g, '"') - .replace(/\\\\/g, '\\'); -} +function splitCommands(rawData: string): string[] { + // Join line continuations (backslash-newline, and backslash-CRLF for Windows) + const joined = rawData.replace(/\\\r?\n/g, ' '); -/** - * Checks if a string might contain escape sequences that need decoding - * If so, decodes them; otherwise returns the string as-is - */ -function maybeDecodeEscapeSequences(str: string): string { - // Check if the string contains escape sequences that shell-quote might not handle - if (str.includes('\\u') || str.includes('\\x')) { - return decodeShellString(str); + // Count consecutive backslashes immediately before position i. + // An even count means the quote at i is NOT escaped; odd means it IS escaped. + function isEscaped(i: number): boolean { + let backslashes = 0; + let j = i - 1; + while (j >= 0 && joined[j] === '\\') { + backslashes++; + j--; + } + return backslashes % 2 !== 0; } - return str; + + // Split on semicolons and newlines to separate commands + const commands: string[] = []; + let current = ''; + let inSingleQuote = false; + let inDoubleQuote = false; + let inDollarQuote = false; + + for (let i = 0; i < joined.length; i++) { + const ch = joined[i]!; + const next = joined[i + 1]; + + // Track quoting state to avoid splitting inside quoted strings + if (!inDoubleQuote && !inDollarQuote && ch === "'" && !inSingleQuote) { + inSingleQuote = true; + current += ch; + continue; + } + if (inSingleQuote && ch === "'") { + inSingleQuote = false; + current += ch; + continue; + } + if (!inSingleQuote && !inDollarQuote && ch === '"' && !inDoubleQuote) { + inDoubleQuote = true; + current += ch; + continue; + } + if (inDoubleQuote && ch === '"' && !isEscaped(i)) { + inDoubleQuote = false; + current += ch; + continue; + } + if (!inSingleQuote && !inDoubleQuote && !inDollarQuote && ch === '$' && next === "'") { + inDollarQuote = true; + current += ch + next; + i++; // Skip the opening quote + continue; + } + if (inDollarQuote && ch === "'" && !isEscaped(i)) { + inDollarQuote = false; + current += ch; + continue; + } + + const inQuote = inSingleQuote || inDoubleQuote || inDollarQuote; + + // Split on ;, newline, or CRLF when not inside quotes and not escaped + if (!inQuote && !isEscaped(i) && (ch === ';' || ch === '\n' || (ch === '\r' && next === '\n'))) { + if (ch === '\r') i++; // Skip the \n in \r\n + if (current.trim()) { + commands.push(current.trim()); + } + current = ''; + continue; + } + + current += ch; + } + + if (current.trim()) { + commands.push(current.trim()); + } + + return commands; } export function convertCurl(rawData: string) { @@ -88,68 +145,17 @@ export function convertCurl(rawData: string) { return null; } - const commands: ParseEntry[][] = []; + const commands: string[][] = splitCommands(rawData).map((cmd) => { + const tokens = split(cmd); - // Replace non-escaped newlines with semicolons to make parsing easier - // NOTE: This is really slow in debug build but fast in release mode - const normalizedData = rawData.replace(/\ncurl/g, '; curl'); - - let currentCommand: ParseEntry[] = []; - - const parsed = parse(normalizedData); - - // Break up `-XPOST` into `-X POST` - const normalizedParseEntries = parsed.flatMap((entry) => { - if ( - typeof entry === 'string' && - entry.startsWith('-') && - !entry.startsWith('--') && - entry.length > 2 - ) { - return [entry.slice(0, 2), entry.slice(2)]; - } - return entry; - }); - - for (const parseEntry of normalizedParseEntries) { - if (typeof parseEntry === 'string') { - if (parseEntry.startsWith('$')) { - // Handle $'...' strings from shell-quote - decode escape sequences - currentCommand.push(decodeShellString(parseEntry.slice(1))); - } else { - // Decode escape sequences that shell-quote might not handle - currentCommand.push(maybeDecodeEscapeSequences(parseEntry)); + // Break up squished arguments like `-XPOST` into `-X POST` + return tokens.flatMap((token) => { + if (token.startsWith('-') && !token.startsWith('--') && token.length > 2) { + return [token.slice(0, 2), token.slice(2)]; } - continue; - } - - if ('comment' in parseEntry) { - continue; - } - - const { op } = parseEntry as { op: 'glob'; pattern: string } | { op: ControlOperator }; - - // `;` separates commands - if (op === ';') { - commands.push(currentCommand); - currentCommand = []; - continue; - } - - if (op?.startsWith('$')) { - // Handle the case where literal like -H $'Header: \'Some Quoted Thing\'' - const str = decodeShellString(op.slice(2, op.length - 1)); - - currentCommand.push(str); - continue; - } - - if (op === 'glob') { - currentCommand.push((parseEntry as { op: 'glob'; pattern: string }).pattern); - } - } - - commands.push(currentCommand); + return token; + }); + }); const workspace: ExportResources['workspaces'][0] = { model: 'workspace', @@ -169,12 +175,12 @@ export function convertCurl(rawData: string) { }; } -function importCommand(parseEntries: ParseEntry[], workspaceId: string) { +function importCommand(parseEntries: string[], workspaceId: string) { // ~~~~~~~~~~~~~~~~~~~~~ // // Collect all the flags // // ~~~~~~~~~~~~~~~~~~~~~ // const flagsByName: FlagsByName = {}; - const singletons: ParseEntry[] = []; + const singletons: string[] = []; // Start at 1 so we can skip the ^curl part for (let i = 1; i < parseEntries.length; i++) { diff --git a/plugins/importer-curl/tests/index.test.ts b/plugins/importer-curl/tests/index.test.ts index 6f75b8e4..3c986817 100644 --- a/plugins/importer-curl/tests/index.test.ts +++ b/plugins/importer-curl/tests/index.test.ts @@ -112,9 +112,28 @@ describe('importer-curl', () => { }); }); + test('Imports with Windows CRLF line endings', () => { + expect( + convertCurl('curl \\\r\n -X POST \\\r\n https://yaak.app'), + ).toEqual({ + resources: { + workspaces: [baseWorkspace()], + httpRequests: [ + baseRequest({ url: 'https://yaak.app', method: 'POST' }), + ], + }, + }); + }); + + test('Throws on malformed quotes', () => { + expect(() => + convertCurl('curl -X POST -F "a=aaa" -F b=bbb" https://yaak.app'), + ).toThrow(); + }); + test('Imports form data', () => { expect( - convertCurl('curl -X POST -F "a=aaa" -F b=bbb" -F f=@filepath https://yaak.app'), + convertCurl('curl -X POST -F "a=aaa" -F b=bbb -F f=@filepath https://yaak.app'), ).toEqual({ resources: { workspaces: [baseWorkspace()], @@ -476,6 +495,130 @@ describe('importer-curl', () => { }); }); + test('Imports JSON body with newlines in $quotes', () => { + expect( + convertCurl( + `curl 'https://yaak.app' -H 'Content-Type: application/json' --data-raw $'{\\n "foo": "bar",\\n "baz": "qux"\\n}' -X POST`, + ), + ).toEqual({ + resources: { + workspaces: [baseWorkspace()], + httpRequests: [ + baseRequest({ + url: 'https://yaak.app', + method: 'POST', + headers: [{ name: 'Content-Type', value: 'application/json', enabled: true }], + bodyType: 'application/json', + body: { text: '{\n "foo": "bar",\n "baz": "qux"\n}' }, + }), + ], + }, + }); + }); + + test('Handles double-quoted string ending with even backslashes before semicolon', () => { + // "C:\\" has two backslashes which escape each other, so the closing " is real. + // The ; after should split into a second command. + expect( + convertCurl( + 'curl -d "C:\\\\" https://yaak.app;curl https://example.com', + ), + ).toEqual({ + resources: { + workspaces: [baseWorkspace()], + httpRequests: [ + baseRequest({ + url: 'https://yaak.app', + method: 'POST', + bodyType: 'application/x-www-form-urlencoded', + body: { + form: [{ name: 'C:\\', value: '', enabled: true }], + }, + headers: [ + { + name: 'Content-Type', + value: 'application/x-www-form-urlencoded', + enabled: true, + }, + ], + }), + baseRequest({ url: 'https://example.com' }), + ], + }, + }); + }); + + test('Handles $quoted string ending with a literal backslash before semicolon', () => { + // $'C:\\\\' has two backslashes which become one literal backslash. + // The closing ' must not be misinterpreted as escaped. + // The ; after should split into a second command. + expect( + convertCurl( + "curl -d $'C:\\\\' https://yaak.app;curl https://example.com", + ), + ).toEqual({ + resources: { + workspaces: [baseWorkspace()], + httpRequests: [ + baseRequest({ + url: 'https://yaak.app', + method: 'POST', + bodyType: 'application/x-www-form-urlencoded', + body: { + form: [{ name: 'C:\\', value: '', enabled: true }], + }, + headers: [ + { + name: 'Content-Type', + value: 'application/x-www-form-urlencoded', + enabled: true, + }, + ], + }), + baseRequest({ url: 'https://example.com' }), + ], + }, + }); + }); + + test('Imports $quoted header with escaped single quotes', () => { + expect( + convertCurl( + `curl https://yaak.app -H $'X-Custom: it\\'s a test'`, + ), + ).toEqual({ + resources: { + workspaces: [baseWorkspace()], + httpRequests: [ + baseRequest({ + url: 'https://yaak.app', + headers: [{ name: 'X-Custom', value: "it's a test", enabled: true }], + }), + ], + }, + }); + }); + + test('Does not split on escaped semicolon outside quotes', () => { + // In shell, \; is a literal semicolon and should not split commands. + // This should be treated as a single curl command with the URL "https://yaak.app?a=1;b=2" + expect( + convertCurl('curl https://yaak.app?a=1\\;b=2'), + ).toEqual({ + resources: { + workspaces: [baseWorkspace()], + httpRequests: [ + baseRequest({ + url: 'https://yaak.app', + urlParameters: [ + { name: 'a', value: '1;b=2', enabled: true }, + ], + }), + ], + }, + }); + }); + test('Imports multipart form data with text-only fields from --data-raw', () => { const curlCommand = `curl 'http://example.com/api' \ -H 'Content-Type: multipart/form-data; boundary=----FormBoundary123' \ diff --git a/scripts/vendor-node.cjs b/scripts/vendor-node.cjs index 1dd29cf0..92160b3a 100644 --- a/scripts/vendor-node.cjs +++ b/scripts/vendor-node.cjs @@ -1,4 +1,6 @@ const path = require('node:path'); +const crypto = require('node:crypto'); +const fs = require('node:fs'); const decompress = require('decompress'); const Downloader = require('nodejs-file-downloader'); const { rmSync, cpSync, mkdirSync, existsSync } = require('node:fs'); @@ -41,6 +43,15 @@ const DST_BIN_MAP = { [WIN_ARM]: 'yaaknode.exe', }; +const SHA256_MAP = { + [MAC_ARM]: 'b05aa3a66efe680023f930bd5af3fdbbd542794da5644ca2ad711d68cbd4dc35', + [MAC_X64]: '096081b6d6fcdd3f5ba0f5f1d44a47e83037ad2e78eada26671c252fe64dd111', + [LNX_ARM]: '0dc93ec5c798b0d347f068db6d205d03dea9a71765e6a53922b682b91265d71f', + [LNX_X64]: '58a5ff5cc8f2200e458bea22e329d5c1994aa1b111d499ca46ec2411d58239ca', + [WIN_X64]: '5355ae6d7c49eddcfde7d34ac3486820600a831bf81dc3bdca5c8db6a9bb0e76', + [WIN_ARM]: 'ce9ee4e547ebdff355beb48e309b166c24df6be0291c9eaf103ce15f3de9e5b4', +}; + const key = `${process.platform}_${process.env.YAAK_TARGET_ARCH ?? process.arch}`; const destDir = path.join(__dirname, `..`, 'crates-tauri', 'yaak-app', 'vendored', 'node'); @@ -68,6 +79,15 @@ rmSync(tmpDir, { recursive: true, force: true }); timeout: 1000 * 60 * 2, }).download(); + // Verify SHA256 + const expectedHash = SHA256_MAP[key]; + const fileBuffer = fs.readFileSync(filePath); + const actualHash = crypto.createHash('sha256').update(fileBuffer).digest('hex'); + if (actualHash !== expectedHash) { + throw new Error(`SHA256 mismatch for ${path.basename(filePath)}\n expected: ${expectedHash}\n actual: ${actualHash}`); + } + console.log('SHA256 verified:', actualHash); + // Decompress to the same directory await decompress(filePath, tmpDir, {}); diff --git a/scripts/vendor-protoc.cjs b/scripts/vendor-protoc.cjs index 48a867ee..439bb10c 100644 --- a/scripts/vendor-protoc.cjs +++ b/scripts/vendor-protoc.cjs @@ -1,3 +1,5 @@ +const crypto = require('node:crypto'); +const fs = require('node:fs'); const decompress = require('decompress'); const Downloader = require('nodejs-file-downloader'); const path = require('node:path'); @@ -41,6 +43,15 @@ const DST_BIN_MAP = { [WIN_ARM]: 'yaakprotoc.exe', }; +const SHA256_MAP = { + [MAC_ARM]: 'db7e66ff7f9080614d0f5505a6b0ac488cf89a15621b6a361672d1332ec2e14e', + [MAC_X64]: 'e20b5f930e886da85e7402776a4959efb1ed60c57e72794bcade765e67abaa82', + [LNX_ARM]: '6018147740548e0e0f764408c87f4cd040e6e1c1203e13aeacaf811892b604f3', + [LNX_X64]: 'f3340e28a83d1c637d8bafdeed92b9f7db6a384c26bca880a6e5217b40a4328b', + [WIN_X64]: 'd7a207fb6eec0e4b1b6613be3b7d11905375b6fd1147a071116eb8e9f24ac53b', + [WIN_ARM]: 'd7a207fb6eec0e4b1b6613be3b7d11905375b6fd1147a071116eb8e9f24ac53b', +}; + const dstDir = path.join(__dirname, `..`, 'crates-tauri', 'yaak-app', 'vendored', 'protoc'); const key = `${process.platform}_${process.env.YAAK_TARGET_ARCH ?? process.arch}`; console.log(`Vendoring protoc ${VERSION} for ${key}`); @@ -63,6 +74,15 @@ mkdirSync(dstDir, { recursive: true }); // Download GitHub release artifact const { filePath } = await new Downloader({ url, directory: tmpDir }).download(); + // Verify SHA256 + const expectedHash = SHA256_MAP[key]; + const fileBuffer = fs.readFileSync(filePath); + const actualHash = crypto.createHash('sha256').update(fileBuffer).digest('hex'); + if (actualHash !== expectedHash) { + throw new Error(`SHA256 mismatch for ${path.basename(filePath)}\n expected: ${expectedHash}\n actual: ${actualHash}`); + } + console.log('SHA256 verified:', actualHash); + // Decompress to the same directory await decompress(filePath, tmpDir, {}); diff --git a/src-web/components/DynamicForm.tsx b/src-web/components/DynamicForm.tsx index ca8bcad1..00e79300 100644 --- a/src-web/components/DynamicForm.tsx +++ b/src-web/components/DynamicForm.tsx @@ -616,5 +616,16 @@ function KeyValueArg({ function hasVisibleInputs(inputs: FormInput[] | undefined): boolean { if (!inputs) return false; - return inputs.some((i) => !i.hidden); + + for (const input of inputs) { + if ('inputs' in input && !hasVisibleInputs(input.inputs)) { + // Has children, but none are visible + return false; + } + if (!input.hidden) { + return true; + } + } + + return false; } diff --git a/src-web/components/core/Editor/Editor.css b/src-web/components/core/Editor/Editor.css index 34679684..b7183b10 100644 --- a/src-web/components/core/Editor/Editor.css +++ b/src-web/components/core/Editor/Editor.css @@ -434,11 +434,23 @@ input { @apply bg-surface border-border-subtle focus:border-border-focus; - @apply border outline-none cursor-text; + @apply border outline-none; } - label { - @apply focus-within:text-text; + input.cm-textfield { + @apply cursor-text; + } + + .cm-search label { + @apply inline-flex items-center h-6 px-1.5 rounded-sm border border-border-subtle cursor-default text-text-subtle text-xs; + + input[type="checkbox"] { + @apply hidden; + } + + &:has(:checked) { + @apply text-primary border-border; + } } /* Hide the "All" button */ @@ -446,4 +458,31 @@ button[name="select"] { @apply hidden; } + + /* Replace next/prev button text with chevron icons */ + + .cm-search button[name="next"], + .cm-search button[name="prev"] { + @apply text-[0px] w-7 h-6 inline-flex items-center justify-center border border-border-subtle mr-1; + } + + .cm-search button[name="prev"]::after, + .cm-search button[name="next"]::after { + @apply block w-3.5 h-3.5 bg-text; + content: ""; + } + + .cm-search button[name="prev"]::after { + -webkit-mask-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='currentColor' stroke-width='2.5' stroke-linecap='round' stroke-linejoin='round'%3E%3Cpath d='M15 18l-6-6 6-6'/%3E%3C/svg%3E"); + mask-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='currentColor' stroke-width='2.5' stroke-linecap='round' stroke-linejoin='round'%3E%3Cpath d='M15 18l-6-6 6-6'/%3E%3C/svg%3E"); + } + + .cm-search button[name="next"]::after { + -webkit-mask-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='currentColor' stroke-width='2.5' stroke-linecap='round' stroke-linejoin='round'%3E%3Cpath d='M9 18l6-6-6-6'/%3E%3C/svg%3E"); + mask-image: url("data:image/svg+xml,%3Csvg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24' fill='none' stroke='currentColor' stroke-width='2.5' stroke-linecap='round' stroke-linejoin='round'%3E%3Cpath d='M9 18l6-6-6-6'/%3E%3C/svg%3E"); + } + + .cm-search-match-count { + @apply text-text-subtle text-xs font-mono whitespace-nowrap px-1.5 py-0.5 self-center; + } } diff --git a/src-web/components/core/Editor/extensions.ts b/src-web/components/core/Editor/extensions.ts index 6919fe2e..1ec1eb07 100644 --- a/src-web/components/core/Editor/extensions.ts +++ b/src-web/components/core/Editor/extensions.ts @@ -67,6 +67,7 @@ import type { TwigCompletionOption } from './twig/completion'; import { twig } from './twig/extension'; import { pathParametersPlugin } from './twig/pathParameters'; import { url } from './url/extension'; +import { searchMatchCount } from './searchMatchCount'; export const syntaxHighlightStyle = HighlightStyle.define([ { @@ -256,6 +257,7 @@ export const readonlyExtensions = [ export const multiLineExtensions = ({ hideGutter }: { hideGutter?: boolean }) => [ search({ top: true }), + searchMatchCount(), hideGutter ? [] : [ diff --git a/src-web/components/core/Editor/searchMatchCount.ts b/src-web/components/core/Editor/searchMatchCount.ts new file mode 100644 index 00000000..79b0937a --- /dev/null +++ b/src-web/components/core/Editor/searchMatchCount.ts @@ -0,0 +1,116 @@ +import { getSearchQuery, searchPanelOpen } from '@codemirror/search'; +import type { Extension } from '@codemirror/state'; +import { type EditorView, ViewPlugin, type ViewUpdate } from '@codemirror/view'; + +/** + * A CodeMirror extension that displays the total number of search matches + * inside the built-in search panel. + */ +export function searchMatchCount(): Extension { + return ViewPlugin.fromClass( + class { + private countEl: HTMLElement | null = null; + + constructor(private view: EditorView) { + this.updateCount(); + } + + update(update: ViewUpdate) { + // Recompute when doc changes, search state changes, or selection moves + const query = getSearchQuery(update.state); + const prevQuery = getSearchQuery(update.startState); + const open = searchPanelOpen(update.state); + const prevOpen = searchPanelOpen(update.startState); + + if (update.docChanged || update.selectionSet || !query.eq(prevQuery) || open !== prevOpen) { + this.updateCount(); + } + } + + private updateCount() { + const state = this.view.state; + const open = searchPanelOpen(state); + const query = getSearchQuery(state); + + if (!open) { + this.removeCountEl(); + return; + } + + this.ensureCountEl(); + + if (!query.search) { + if (this.countEl) { + this.countEl.textContent = '0/0'; + } + return; + } + + const selection = state.selection.main; + let count = 0; + let currentIndex = 0; + const MAX_COUNT = 9999; + const cursor = query.getCursor(state); + for (let result = cursor.next(); !result.done; result = cursor.next()) { + count++; + const match = result.value; + if (match.from <= selection.from && match.to >= selection.to) { + currentIndex = count; + } + if (count > MAX_COUNT) break; + } + + if (this.countEl) { + if (count > MAX_COUNT) { + this.countEl.textContent = `${MAX_COUNT}+`; + } else if (count === 0) { + this.countEl.textContent = '0/0'; + } else if (currentIndex > 0) { + this.countEl.textContent = `${currentIndex}/${count}`; + } else { + this.countEl.textContent = `0/${count}`; + } + } + } + + private ensureCountEl() { + // Find the search panel in the editor DOM + const panel = this.view.dom.querySelector('.cm-search'); + if (!panel) { + this.countEl = null; + return; + } + + if (this.countEl && this.countEl.parentElement === panel) { + return; // Already attached + } + + this.countEl = document.createElement('span'); + this.countEl.className = 'cm-search-match-count'; + + // Reorder: insert prev button, then next button, then count after the search input + const searchInput = panel.querySelector('input'); + const prevBtn = panel.querySelector('button[name="prev"]'); + const nextBtn = panel.querySelector('button[name="next"]'); + if (searchInput && searchInput.parentElement === panel) { + searchInput.after(this.countEl); + if (prevBtn) this.countEl.after(prevBtn); + if (nextBtn && prevBtn) prevBtn.after(nextBtn); + } else { + panel.prepend(this.countEl); + } + } + + private removeCountEl() { + if (this.countEl) { + this.countEl.remove(); + this.countEl = null; + } + } + + destroy() { + this.removeCountEl(); + } + }, + ); +} diff --git a/src-web/components/git/GitCommitDialog.tsx b/src-web/components/git/GitCommitDialog.tsx index 7435f3b3..7de28a23 100644 --- a/src-web/components/git/GitCommitDialog.tsx +++ b/src-web/components/git/GitCommitDialog.tsx @@ -176,7 +176,11 @@ export function GitCommitDialog({ syncDir, onDone, workspace }: Props) { } if (!hasAnythingToAdd) { - return No changes since last commit; + return ( +
+ No changes since last commit +
+ ); } return ( @@ -230,14 +234,14 @@ export function GitCommitDialog({ syncDir, onDone, workspace }: Props) { hideLabel /> {commitError && {commitError}} - + {status.data?.headRefShorthand}