From 32d7af94a58d0d43bd7c5c481190404dc6707251 Mon Sep 17 00:00:00 2001
From: Gregory Schier <gschier1990@gmail.com>
Date: Fri, 20 Sep 2024 05:36:56 -0700
Subject: [PATCH] Fix environment dialog hotkey

---
 .../components/EnvironmentActionsDropdown.tsx | 20 +++----------------
 1 file changed, 3 insertions(+), 17 deletions(-)

diff --git a/src-web/components/EnvironmentActionsDropdown.tsx b/src-web/components/EnvironmentActionsDropdown.tsx
index da4858e0..98a3446b 100644
--- a/src-web/components/EnvironmentActionsDropdown.tsx
+++ b/src-web/components/EnvironmentActionsDropdown.tsx
@@ -68,23 +68,6 @@ export const EnvironmentActionsDropdown = memo(function EnvironmentActionsDropdo
   const hasWorkspaceVars =
     (activeWorkspace?.variables ?? []).filter((v) => v.enabled && (v.name || v.value)).length > 0;
 
-  if (environments.length === 0) {
-    return (
-      <Button
-        size="sm"
-        className={classNames(
-          className,
-          'text !px-2 truncate',
-          !hasWorkspaceVars && 'text-text-subtlest italic',
-        )}
-        onClick={showEnvironmentDialog}
-        {...buttonProps}
-      >
-        Environment
-      </Button>
-    );
-  }
-
   return (
     <Dropdown items={items}>
       <Button
@@ -94,6 +77,9 @@ export const EnvironmentActionsDropdown = memo(function EnvironmentActionsDropdo
           'text !px-2 truncate',
           !activeEnvironment && !hasWorkspaceVars && 'text-text-subtlest italic',
         )}
+        // If no environments, the button simply opens the dialog.
+        // NOTE: We don't create a new button because we want to reuse the hotkey from the menu items
+        onClick={environments.length === 0 ? showEnvironmentDialog : undefined}
         {...buttonProps}
       >
         {activeEnvironment?.name ?? (hasWorkspaceVars ? 'Environment' : 'No Environment')}