starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-14 07:43:25 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #113] [MERGED] Make settings menu a regular window #49

New Issue
Closed
opened 2025-12-29 08:31:10 +01:00 by adam · 0 comments
adam commented 2025-12-29 08:31:10 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/113
Author: @gschier
Created: 9/25/2024
Status: ✅ Merged
Merged: 9/25/2024
Merged by: @gschier

Base: master ← Head: regular-settings-window

📝 Commits (2)

  • 7fad761 Make settings menu a regular window
  • c6ee43a Better child window support

📊 Changes

13 files changed (+200 additions, -110 deletions)

View changed files

📝 src-tauri/.gitignore (+1 -1)
📝 src-tauri/capabilities/capabilities.json (+2 -2)
📝 src-tauri/gen/schemas/capabilities.json (+1 -1)
📝 src-tauri/src/lib.rs (+139 -69)
📝 src-tauri/src/tauri_plugin_mac_window.rs (+6 -2)
📝 src-web/components/CommandPalette.tsx (+5 -14)
📝 src-web/components/GlobalHooks.tsx (+1 -2)
📝 src-web/components/SettingsDropdown.tsx (+4 -16)
➕ src-web/font-size.ts (+15 -0)
➕ src-web/hooks/useOpenSettings.ts (+22 -0)
📝 src-web/hooks/useOpenWorkspace.ts (+1 -1)
📝 src-web/index.html (+1 -0)
📝 src-web/lib/tauri.ts (+2 -2)

📄 Description

macOS has some weirdness around child windows (they're really only meant for menus and things) so this PR changes the Yaak Settings window to a regular window.

Fixes #87

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/113 **Author:** [@gschier](https://github.com/gschier) **Created:** 9/25/2024 **Status:** ✅ Merged **Merged:** 9/25/2024 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `regular-settings-window` --- ### 📝 Commits (2) - [`7fad761`](https://github.com/mountain-loop/yaak/commit/7fad7615bac2c41ca40e5954f1852b4879793874) Make settings menu a regular window - [`c6ee43a`](https://github.com/mountain-loop/yaak/commit/c6ee43ae1780d9749d41af374e348790dd572600) Better child window support ### 📊 Changes **13 files changed** (+200 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/.gitignore` (+1 -1) 📝 `src-tauri/capabilities/capabilities.json` (+2 -2) 📝 `src-tauri/gen/schemas/capabilities.json` (+1 -1) 📝 `src-tauri/src/lib.rs` (+139 -69) 📝 `src-tauri/src/tauri_plugin_mac_window.rs` (+6 -2) 📝 `src-web/components/CommandPalette.tsx` (+5 -14) 📝 `src-web/components/GlobalHooks.tsx` (+1 -2) 📝 `src-web/components/SettingsDropdown.tsx` (+4 -16) ➕ `src-web/font-size.ts` (+15 -0) ➕ `src-web/hooks/useOpenSettings.ts` (+22 -0) 📝 `src-web/hooks/useOpenWorkspace.ts` (+1 -1) 📝 `src-web/index.html` (+1 -0) 📝 `src-web/lib/tauri.ts` (+2 -2) </details> ### 📄 Description macOS has some weirdness around child windows (they're really only meant for menus and things) so this PR changes the Yaak Settings window to a regular window. Fixes #87 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 08:31:10 +01:00
adam closed this issue 2025-12-29 08:31:10 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak-mountain-loop#49
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?