starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-14 07:43:25 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #258] [MERGED] License and updater Cargo features #182

New Issue
Closed
opened 2025-12-29 08:31:54 +01:00 by adam · 0 comments
adam commented 2025-12-29 08:31:54 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/258
Author: @gschier
Created: 9/30/2025
Status: ✅ Merged
Merged: 9/30/2025
Merged by: @gschier

Base: main ← Head: build-time-features

📝 Commits (2)

  • e2bccc1 Only enable license and updater features on official Yaak builds
  • eacb12d Fix release.yml

📊 Changes

11 files changed (+124 additions, -52 deletions)

View changed files

📝 .github/workflows/release.yml (+1 -1)
📝 src-tauri/Cargo.toml (+4 -1)
📝 src-tauri/src/lib.rs (+23 -13)
➕ src-web/components/CargoFeature.tsx (+20 -0)
📝 src-web/components/LicenseBadge.tsx (+9 -0)
📝 src-web/components/Settings/Settings.tsx (+14 -6)
📝 src-web/components/Settings/SettingsGeneral.tsx (+34 -31)
📝 src-web/components/Settings/SettingsLicense.tsx (+9 -0)
📝 src-web/components/SettingsDropdown.tsx (+1 -0)
📝 src-web/components/core/Tabs/Tabs.tsx (+5 -0)
📝 src-web/lib/appInfo.ts (+4 -0)

📄 Description

Since the commercial-use license doesn't apply to running the OSS code yourself, this (finally) makes that experience nicer.

In short, running Yaak locally and building it yourself won't have any UI or functionality to run the updater or licensing features.

The "Release" GitHub Action now adds --features "updater license" to enable these for official releases.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/258 **Author:** [@gschier](https://github.com/gschier) **Created:** 9/30/2025 **Status:** ✅ Merged **Merged:** 9/30/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `main` ← **Head:** `build-time-features` --- ### 📝 Commits (2) - [`e2bccc1`](https://github.com/mountain-loop/yaak/commit/e2bccc1cc3eda6a4319514ab18eeeca15be69be2) Only enable license and updater features on official Yaak builds - [`eacb12d`](https://github.com/mountain-loop/yaak/commit/eacb12d61164e4f38ef5f4afcf088c46588a629c) Fix release.yml ### 📊 Changes **11 files changed** (+124 additions, -52 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/release.yml` (+1 -1) 📝 `src-tauri/Cargo.toml` (+4 -1) 📝 `src-tauri/src/lib.rs` (+23 -13) ➕ `src-web/components/CargoFeature.tsx` (+20 -0) 📝 `src-web/components/LicenseBadge.tsx` (+9 -0) 📝 `src-web/components/Settings/Settings.tsx` (+14 -6) 📝 `src-web/components/Settings/SettingsGeneral.tsx` (+34 -31) 📝 `src-web/components/Settings/SettingsLicense.tsx` (+9 -0) 📝 `src-web/components/SettingsDropdown.tsx` (+1 -0) 📝 `src-web/components/core/Tabs/Tabs.tsx` (+5 -0) 📝 `src-web/lib/appInfo.ts` (+4 -0) </details> ### 📄 Description Since the commercial-use license doesn't apply to running the OSS code yourself, this (finally) makes that experience nicer. In short, running Yaak locally and building it yourself won't have any UI or functionality to run the updater or licensing features. The "Release" GitHub Action now adds `--features "updater license"` to enable these for official releases. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 08:31:54 +01:00
adam closed this issue 2025-12-29 08:31:54 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak-mountain-loop#182
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?