starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-11 22:40:26 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #238] [MERGED] Improve <details> component #161

New Issue
Closed
opened 2025-12-29 08:31:48 +01:00 by adam · 0 comments
adam commented 2025-12-29 08:31:48 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/238
Author: @subframe7536
Created: 7/17/2025
Status: ✅ Merged
Merged: 7/18/2025
Merged by: @gschier

Base: master ← Head: remove-summary-arrow

📝 Commits (2)

📊 Changes

6 files changed (+95 additions, -65 deletions)

View changed files

📝 src-web/components/DynamicForm.tsx (+18 -16)
📝 src-web/components/ExportDataDialog.tsx (+9 -14)
📝 src-web/components/HeadersEditor.tsx (+31 -30)
📝 src-web/components/RouteError.tsx (+3 -3)
📝 src-web/components/core/Banner.tsx (+3 -2)
➕ src-web/components/core/DetailsBanner.tsx (+31 -0)

📄 Description

Remove the <summary /> 's default arrow in <HeadersEditor />. Especially, on Windows, the arrow itself occupies one line, and the Inherited is in next line, so I think it would better to hide it.

PixPin_2025-07-17_22-22-59

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/238 **Author:** [@subframe7536](https://github.com/subframe7536) **Created:** 7/17/2025 **Status:** ✅ Merged **Merged:** 7/18/2025 **Merged by:** [@gschier](https://github.com/gschier) **Base:** `master` ← **Head:** `remove-summary-arrow` --- ### 📝 Commits (2) - [`f2124cd`](https://github.com/mountain-loop/yaak/commit/f2124cd41acc576bfc02f463e525679d3536ac98) remove left arrow in summary - [`857ccd7`](https://github.com/mountain-loop/yaak/commit/857ccd767eb46710a3ea8f30b852734b84618654) Add <DetailsBanner/> and use everywhere ### 📊 Changes **6 files changed** (+95 additions, -65 deletions) <details> <summary>View changed files</summary> 📝 `src-web/components/DynamicForm.tsx` (+18 -16) 📝 `src-web/components/ExportDataDialog.tsx` (+9 -14) 📝 `src-web/components/HeadersEditor.tsx` (+31 -30) 📝 `src-web/components/RouteError.tsx` (+3 -3) 📝 `src-web/components/core/Banner.tsx` (+3 -2) ➕ `src-web/components/core/DetailsBanner.tsx` (+31 -0) </details> ### 📄 Description Remove the `<summary />` 's default arrow in `<HeadersEditor />`. Especially, on Windows, the arrow itself occupies one line, and the `Inherited` is in next line, so I think it would better to hide it. <img width="858" height="318" alt="PixPin_2025-07-17_22-22-59" src="https://github.com/user-attachments/assets/c9779db5-eabe-4981-89f3-229231426913" /> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 08:31:48 +01:00
adam closed this issue 2025-12-29 08:31:48 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak-mountain-loop#161
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?