starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-01-14 07:43:25 +01:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

[PR #210] [CLOSED] Fix automatic theme not following system light/dark mode on Linux #134

New Issue
Closed
opened 2025-12-29 08:31:39 +01:00 by adam · 0 comments
adam commented 2025-12-29 08:31:39 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/mountain-loop/yaak/pull/210
Author: @yohannestakata
Created: 5/17/2025
Status: ❌ Closed

Base: main ← Head: linux-theme

📝 Commits (2)

  • d495eea Fix automatic theme not following system light/dark mode on Linux
  • 7f8b569 Merge branch 'master' into linux-theme

📊 Changes

2 files changed (+109 additions, -0 deletions)

View changed files

📝 src-tauri/src/lib.rs (+71 -0)
📝 src-web/lib/theme/appearance.ts (+38 -0)

📄 Description

Fix automatic theme not following system light/dark mode on Linux

Issue

The automatic theme setting doesn't properly follow the system's light/dark mode preference on Linux (specifically tested on Fedora 42).

Solution

  • Added Linux-specific theme detection using gsettings
  • Implemented theme change monitoring
  • Integrated with existing theme system

Testing

  • Verified initial theme detection works
  • Confirmed theme changes are detected and applied
  • Tested on Fedora 42

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/mountain-loop/yaak/pull/210 **Author:** [@yohannestakata](https://github.com/yohannestakata) **Created:** 5/17/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `linux-theme` --- ### 📝 Commits (2) - [`d495eea`](https://github.com/mountain-loop/yaak/commit/d495eea1c8ce1b3978fc429cf5a0e31fd5eade1b) Fix automatic theme not following system light/dark mode on Linux - [`7f8b569`](https://github.com/mountain-loop/yaak/commit/7f8b569fd6e333c10bbc4d828e99621103ee973d) Merge branch 'master' into linux-theme ### 📊 Changes **2 files changed** (+109 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src-tauri/src/lib.rs` (+71 -0) 📝 `src-web/lib/theme/appearance.ts` (+38 -0) </details> ### 📄 Description Fix automatic theme not following system light/dark mode on Linux ## Issue The automatic theme setting doesn't properly follow the system's light/dark mode preference on Linux (specifically tested on Fedora 42). ## Solution - Added Linux-specific theme detection using `gsettings` - Implemented theme change monitoring - Integrated with existing theme system ## Testing - Verified initial theme detection works - Confirmed theme changes are detected and applied - Tested on Fedora 42 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-29 08:31:39 +01:00
adam closed this issue 2025-12-29 08:31:39 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/yaak-mountain-loop#134
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?