starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-07-01 18:41:36 +02:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

Refine contribution policy labels

Browse Source
This commit is contained in:
Gregory Schier
2026-06-30 14:20:13 -07:00
parent 83c8371e94
commit f32e9f7704
1 changed files with 21 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/scripts/check-contribution-policy.js
+21 -20
View File
@@ -35,15 +35,18 @@ const LABELS = {
color: "B60205", color: "B60205",
description: "Community PR needs an approved feedback item before review.", description: "Community PR needs an approved feedback item before review.",
}, },
largeDiff: { needsScopeReview: {
name: "contribution: large diff", name: "contribution: needs scope review",
color: "FBCA04", color: "FBCA04",
description: description:
"Community PR has a larger-than-usual diff for a small-scope contribution.", "Community PR may be broader than Yaak's small-scope contribution policy.",
}, },
}; };
const LEGACY_MANAGED_LABEL_NAMES = ["contribution: accepted"]; const LEGACY_MANAGED_LABEL_NAMES = [
"contribution: accepted",
"contribution: large diff",
];
const MANAGED_LABEL_NAMES = [ const MANAGED_LABEL_NAMES = [
...new Set([ ...new Set([
...Object.values(LABELS).map((label) => label.name), ...Object.values(LABELS).map((label) => label.name),
@@ -170,16 +173,10 @@ function analyzePullRequest(pr) {
} }
if (labelNames.has(LABELS.inScope.name)) { if (labelNames.has(LABELS.inScope.name)) {
const desiredLabels = [LABELS.inScope.name];
if (largeDiff) {
desiredLabels.push(LABELS.largeDiff.name);
}
return { return {
blockers: [], blockers: [],
changedFiles, changedFiles,
desiredLabels, desiredLabels: [LABELS.inScope.name],
largeDiff, largeDiff,
status: "in_scope", status: "in_scope",
templateUsed, templateUsed,
@@ -249,18 +246,22 @@ function analyzePullRequest(pr) {
} }
} }
const desiredLabels = new Set(blockers.map((blocker) => blocker.label)); const desiredLabels = new Set();
if (blockers.length === 0) { if (blockers.length === 0) {
desiredLabels.add( desiredLabels.add(
states.approvedFeedback largeDiff
? LABELS.approvedFeedback.name ? LABELS.needsScopeReview.name
: LABELS.inScope.name, : states.approvedFeedback
? LABELS.approvedFeedback.name
: LABELS.inScope.name,
); );
} } else if (
blockers.some((blocker) => blocker.label === LABELS.needsTemplate.name)
if (largeDiff) { ) {
desiredLabels.add(LABELS.largeDiff.name); desiredLabels.add(LABELS.needsTemplate.name);
} else {
desiredLabels.add(blockers[0].label);
} }
return { return {
@@ -287,7 +288,7 @@ function buildBlockingComment(analysis) {
if (analysis.largeDiff) { if (analysis.largeDiff) {
lines.push( lines.push(
"", "",
`This PR also changes ${analysis.changedFiles} files and ${analysis.totalChangedLines} lines, so it has been labeled as a large diff. That label is advisory, but maintainers may ask for the scope to be reduced.`, `This PR also changes ${analysis.changedFiles} files and ${analysis.totalChangedLines} lines, so it has been labeled as needing scope review. That label is advisory, but maintainers may ask for the scope to be reduced.`,
); );
} }