starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-03-31 14:33:18 +02:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

Limit CLI plugin runtime startup and harden shutdown watcher

Browse Source
This commit is contained in:
Gregory Schier
2026-02-16 09:31:46 -08:00
parent f6c20283f0
commit ea0b083d25
4 changed files with 56 additions and 32 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
crates/yaak-plugins/src/nodejs.rs
View File

@@ -68,7 +68,9 @@ pub async fn start_nodejs_plugin_runtime(
// Handle kill signal
let mut kill_rx = kill_rx.clone();
tokio::spawn(async move {
kill_rx.wait_for(|b| *b == true).await.expect("Kill channel errored");
if kill_rx.wait_for(|b| *b == true).await.is_err() {
warn!("Kill channel closed before explicit shutdown; terminating plugin runtime");
}
info!("Killing plugin runtime");
if let Err(e) = child.kill().await {
warn!("Failed to kill plugin runtime: {e}");