From a221b05cc66c6e1a634b1a0764405a03b97f41cd Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Fri, 17 Jan 2025 15:55:21 -0800 Subject: [PATCH] Even better --- src-web/components/DynamicForm.tsx | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/src-web/components/DynamicForm.tsx b/src-web/components/DynamicForm.tsx index 37aae1bc..1e3a7e20 100644 --- a/src-web/components/DynamicForm.tsx +++ b/src-web/components/DynamicForm.tsx @@ -58,7 +58,9 @@ export function DynamicForm>({ key={i + stateKey} arg={a} onChange={(v) => setDataAttr(a.name, v)} - value={data[a.name] ? String(data[a.name]) : DYNAMIC_FORM_NULL_ARG} + value={ + data[a.name] ? String(data[a.name]) : (a.defaultValue ?? DYNAMIC_FORM_NULL_ARG) + } /> ); case 'text': @@ -70,7 +72,7 @@ export function DynamicForm>({ useTemplating={useTemplating || false} autocompleteVariables={autocompleteVariables || false} onChange={(v) => setDataAttr(a.name, v)} - value={data[a.name] ? String(data[a.name]) : DYNAMIC_FORM_NULL_ARG} + value={data[a.name] ? String(data[a.name]) : (a.defaultValue ?? '')} /> ); case 'editor': @@ -82,7 +84,7 @@ export function DynamicForm>({ useTemplating={useTemplating || false} autocompleteVariables={autocompleteVariables || false} onChange={(v) => setDataAttr(a.name, v)} - value={data[a.name] ? String(data[a.name]) : DYNAMIC_FORM_NULL_ARG} + value={data[a.name] ? String(data[a.name]) : (a.defaultValue ?? '')} /> ); case 'checkbox': @@ -100,7 +102,7 @@ export function DynamicForm>({ key={i + stateKey} arg={a} onChange={(v) => setDataAttr(a.name, v)} - value={data[a.name] ? String(data[a.name]) : '__ERROR__'} + value={data[a.name] ? String(data[a.name]) : DYNAMIC_FORM_NULL_ARG} /> ); case 'file': @@ -109,7 +111,7 @@ export function DynamicForm>({ key={i + stateKey} arg={a} onChange={(v) => setDataAttr(a.name, v)} - filePath={data[a.name] ? String(data[a.name]) : '__ERROR__'} + filePath={data[a.name] ? String(data[a.name]) : DYNAMIC_FORM_NULL_ARG} /> ); } @@ -233,7 +235,7 @@ function SelectArg({ options={[ ...arg.options.map((a) => ({ label: a.name, - value: a.value === arg.defaultValue ? DYNAMIC_FORM_NULL_ARG : a.value, + value: a.value, })), ]} />