PR feedback

src-tauri/src/lib.rs

@@ -118,7 +118,7 @@ async fn cmd_render_template<R: Runtime>(
     workspace_id: &str,
     environment_id: Option<&str>,
     purpose: Option<RenderPurpose>,
-    ignore_error: bool,
+    ignore_error: Option<bool>,
 ) -> YaakResult<String> {
     let environment_chain =
         app_handle.db().resolve_environments(workspace_id, None, environment_id)?;
@@ -131,10 +131,9 @@ async fn cmd_render_template<R: Runtime>(
             purpose.unwrap_or(RenderPurpose::Preview),
         ),
         &RenderOptions {
-            error_behavior: if ignore_error {
+            error_behavior: match ignore_error {
-                RenderErrorBehavior::ReturnEmpty
+                Some(true) => RenderErrorBehavior::ReturnEmpty,
-            } else {
+                _ => RenderErrorBehavior::Throw,
-                RenderErrorBehavior::Throw
             },
         },
     )

src-web/components/HttpAuthenticationEditor.tsx

@@ -1,4 +1,10 @@
-import type { Folder, GrpcRequest, HttpRequest, WebsocketRequest, Workspace } from '@yaakapp-internal/models';
+import type {
+  Folder,
+  GrpcRequest,
+  HttpRequest,
+  WebsocketRequest,
+  Workspace,
+} from '@yaakapp-internal/models';
 import { patchModel } from '@yaakapp-internal/models';
 import { useCallback } from 'react';
 import { openFolderSettings } from '../commands/openFolderSettings';
@@ -121,7 +127,6 @@ export function HttpAuthenticationEditor({ model }: Props) {
               } else {
                 disabled = '';
               }
-              console.log('SETTING DISABLED', disabled);
               await handleChange({ ...model.authentication, disabled });
             }}
           />
@@ -178,7 +183,6 @@ function AuthenticationDisabledInput({
     template: value,
     enabled: true,
     purpose: 'preview',
-    ignoreError: true,
     refreshKey: value,
   });
 

src-web/components/core/SegmentedControl.tsx

@@ -81,6 +81,7 @@ export function SegmentedControl<T extends string>({
             return (
               <Button
                 key={o.label}
+                aria-checked={isActive}
                 size={size}
                 variant="solid"
                 color={isActive ? 'secondary' : undefined}
@@ -99,6 +100,7 @@ export function SegmentedControl<T extends string>({
             return (
               <IconButton
                 key={o.label}
+                aria-checked={isActive}
                 size={size}
                 variant="solid"
                 color={isActive ? 'secondary' : undefined}