From 469d12fedec24907b88c22ec4ce84ae34f3a4d74 Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Tue, 13 May 2025 10:11:24 -0700 Subject: [PATCH] Don't query KeyValue.id == NULL --- src-tauri/yaak-models/src/queries/key_values.rs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src-tauri/yaak-models/src/queries/key_values.rs b/src-tauri/yaak-models/src/queries/key_values.rs index b7ee6f4a..bfbb05c0 100644 --- a/src-tauri/yaak-models/src/queries/key_values.rs +++ b/src-tauri/yaak-models/src/queries/key_values.rs @@ -11,6 +11,11 @@ impl<'a> DbContext<'a> { let (sql, params) = Query::select() .from(KeyValueIden::Table) .column(Asterisk) + // Temporary clause to prevent bug when reverting to the previous version, before the + // ID column was added. A previous version will not know about ID and will create + // key/value entries that don't have one. This clause ensures they are not queried + // TODO: Add migration to delete key/values with NULL IDs later on, then remove this + .cond_where(Expr::col(KeyValueIden::Id).is_not_null()) .build_rusqlite(SqliteQueryBuilder); let mut stmt = self.conn.prepare(sql.as_str())?; let items = stmt.query_map(&*params.as_params(), KeyValue::from_row)?;