Env dropdown becomes button when no sub envs

This commit is contained in:
Gregory Schier
2024-09-19 13:01:22 -07:00
parent ed368cd251
commit 3ee9ed8bf4

View File

@@ -1,6 +1,7 @@
import classNames from 'classnames'; import classNames from 'classnames';
import { memo, useCallback, useMemo } from 'react'; import { memo, useCallback, useMemo } from 'react';
import { useActiveEnvironment } from '../hooks/useActiveEnvironment'; import { useActiveEnvironment } from '../hooks/useActiveEnvironment';
import { useActiveWorkspace } from '../hooks/useActiveWorkspace';
import { useEnvironments } from '../hooks/useEnvironments'; import { useEnvironments } from '../hooks/useEnvironments';
import type { ButtonProps } from './core/Button'; import type { ButtonProps } from './core/Button';
import { Button } from './core/Button'; import { Button } from './core/Button';
@@ -19,6 +20,7 @@ export const EnvironmentActionsDropdown = memo(function EnvironmentActionsDropdo
...buttonProps ...buttonProps
}: Props) { }: Props) {
const environments = useEnvironments(); const environments = useEnvironments();
const activeWorkspace = useActiveWorkspace();
const [activeEnvironment, setActiveEnvironmentId] = useActiveEnvironment(); const [activeEnvironment, setActiveEnvironmentId] = useActiveEnvironment();
const dialog = useDialog(); const dialog = useDialog();
@@ -63,6 +65,26 @@ export const EnvironmentActionsDropdown = memo(function EnvironmentActionsDropdo
[activeEnvironment?.id, environments, setActiveEnvironmentId, showEnvironmentDialog], [activeEnvironment?.id, environments, setActiveEnvironmentId, showEnvironmentDialog],
); );
const hasWorkspaceVars =
(activeWorkspace?.variables ?? []).filter((v) => v.enabled && (v.name || v.value)).length > 0;
if (environments.length === 0) {
return (
<Button
size="sm"
className={classNames(
className,
'text !px-2 truncate',
!hasWorkspaceVars && 'text-text-subtlest italic',
)}
onClick={showEnvironmentDialog}
{...buttonProps}
>
Environment
</Button>
);
}
return ( return (
<Dropdown items={items}> <Dropdown items={items}>
<Button <Button
@@ -70,11 +92,11 @@ export const EnvironmentActionsDropdown = memo(function EnvironmentActionsDropdo
className={classNames( className={classNames(
className, className,
'text !px-2 truncate', 'text !px-2 truncate',
activeEnvironment == null && 'text-text-subtlest italic', !activeEnvironment && !hasWorkspaceVars && 'text-text-subtlest italic',
)} )}
{...buttonProps} {...buttonProps}
> >
{activeEnvironment?.name ?? 'Environment'} {activeEnvironment?.name ?? (hasWorkspaceVars ? 'Environment' : 'No Environment')}
</Button> </Button>
</Dropdown> </Dropdown>
); );