starred/yaak-mountain-loop
1
0
Fork 0
mirror of https://github.com/mountain-loop/yaak.git synced 2026-04-18 06:49:50 +02:00
Code Issues 8 Packages Projects Releases 10 Wiki Activity

Prevent infinite recursion in response tag

Browse Source 
Closes yaakapp/app#90
This commit is contained in:
Gregory Schier
2024-09-16 06:37:48 -07:00
parent 75df5f8094
commit 29d2d0ec62
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/template-function-response/src/index.ts
View File

@@ -39,7 +39,6 @@ export const plugin: Plugin = {
if (httpRequest == null) { if (httpRequest == null) {
return null; return null;
} }
const renderedHttpRequest = await ctx.httpRequest.render({ httpRequest, purpose: args.purpose });
const responses = await ctx.httpResponse.find({ requestId: httpRequest.id, limit: 1 }); const responses = await ctx.httpResponse.find({ requestId: httpRequest.id, limit: 1 });
@@ -57,6 +56,8 @@ export const plugin: Plugin = {
// Send if no responses and "smart," or "always" // Send if no responses and "smart," or "always"
if ((behavior === 'smart' && response == null) || behavior === 'always') { if ((behavior === 'smart' && response == null) || behavior === 'always') {
// NOTE: Render inside this conditional, or we'll get infinite recursion (render->render->...)
const renderedHttpRequest = await ctx.httpRequest.render({ httpRequest, purpose: args.purpose });
response = await ctx.httpRequest.send({ httpRequest: renderedHttpRequest }); response = await ctx.httpRequest.send({ httpRequest: renderedHttpRequest });
} }