From 11872dd35ebc3b6a2cc0c1b0301cef49c38764fd Mon Sep 17 00:00:00 2001 From: Gregory Schier Date: Wed, 11 Feb 2026 11:50:47 -0800 Subject: [PATCH] Fix auth tab crash when template rendering fails Use ReturnEmpty instead of Throw for render errors in cmd_get_http_authentication_config, since this is a preview path. Invalid templates in auth fields (e.g. OAuth 2) will now render as empty strings instead of crashing the auth config panel. Co-Authored-By: Claude Opus 4.6 --- crates-tauri/yaak-app/src/lib.rs | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/crates-tauri/yaak-app/src/lib.rs b/crates-tauri/yaak-app/src/lib.rs index 2b1710cf..961304f3 100644 --- a/crates-tauri/yaak-app/src/lib.rs +++ b/crates-tauri/yaak-app/src/lib.rs @@ -1095,8 +1095,13 @@ async fn cmd_get_http_authentication_config( // Convert HashMap to serde_json::Value for rendering let values_json: serde_json::Value = serde_json::to_value(&values)?; - let rendered_json = - render_json_value(values_json, environment_chain, &cb, &RenderOptions::throw()).await?; + let rendered_json = render_json_value( + values_json, + environment_chain, + &cb, + &RenderOptions { error_behavior: RenderErrorBehavior::ReturnEmpty }, + ) + .await?; // Convert back to HashMap let rendered_values: HashMap = serde_json::from_value(rendered_json)?;