Better plugin error handling

packages/plugin-runtime/src/PluginHandle.ts

@@ -1,5 +1,5 @@
-import type { PluginContext } from '@yaakapp-internal/plugins';
 import type { BootRequest, InternalEvent } from '@yaakapp/api';
+import type { PluginContext } from '@yaakapp-internal/plugins';
 import type { EventChannel } from './EventChannel';
 import { PluginInstance, type PluginWorkerData } from './PluginInstance';
 

packages/plugin-runtime/src/PluginInstance.ts

@@ -69,15 +69,25 @@ export class PluginInstance {
     const fileChangeCallback = async () => {
       await this.#mod?.dispose?.();
       this.#importModule();
-      await this.#mod?.init?.(this.#newCtx(workerData.context));
-      return this.#sendPayload(
-        workerData.context,
-        {
-          type: 'reload_response',
-          silent: false,
-        },
-        null,
-      );
+      const ctx = this.#newCtx(workerData.context);
+      try {
+        await this.#mod?.init?.(ctx);
+        this.#sendPayload(
+          workerData.context,
+          {
+            type: 'reload_response',
+            silent: false,
+          },
+          null,
+        );
+      } catch (err: unknown) {
+        ctx.toast.show({
+          message: `Failed to initialize plugin ${this.#workerData.bootRequest.dir.split('/').pop()}: ${err}`,
+          color: 'notice',
+          icon: 'alert_triangle',
+          timeout: 30000,
+        });
+      }
     };
 
     if (this.#workerData.bootRequest.watch) {

src-tauri/yaak-plugins/src/manager.rs

@@ -8,14 +8,15 @@ use crate::events::{
     CallHttpAuthenticationActionArgs, CallHttpAuthenticationActionRequest,
     CallHttpAuthenticationRequest, CallHttpAuthenticationResponse, CallHttpRequestActionRequest,
     CallTemplateFunctionArgs, CallTemplateFunctionRequest, CallTemplateFunctionResponse,
-    CallWebsocketRequestActionRequest, CallWorkspaceActionRequest, EmptyPayload, ErrorResponse,
-    FilterRequest, FilterResponse, GetFolderActionsResponse, GetGrpcRequestActionsResponse,
-    GetHttpAuthenticationConfigRequest, GetHttpAuthenticationConfigResponse,
-    GetHttpAuthenticationSummaryResponse, GetHttpRequestActionsResponse,
-    GetTemplateFunctionConfigRequest, GetTemplateFunctionConfigResponse,
-    GetTemplateFunctionSummaryResponse, GetThemesRequest, GetThemesResponse,
-    GetWebsocketRequestActionsResponse, GetWorkspaceActionsResponse, ImportRequest, ImportResponse,
-    InternalEvent, InternalEventPayload, JsonPrimitive, PluginContext, RenderPurpose,
+    CallWebsocketRequestActionRequest, CallWorkspaceActionRequest, Color, EmptyPayload,
+    ErrorResponse, FilterRequest, FilterResponse, GetFolderActionsResponse,
+    GetGrpcRequestActionsResponse, GetHttpAuthenticationConfigRequest,
+    GetHttpAuthenticationConfigResponse, GetHttpAuthenticationSummaryResponse,
+    GetHttpRequestActionsResponse, GetTemplateFunctionConfigRequest,
+    GetTemplateFunctionConfigResponse, GetTemplateFunctionSummaryResponse, GetThemesRequest,
+    GetThemesResponse, GetWebsocketRequestActionsResponse, GetWorkspaceActionsResponse, Icon,
+    ImportRequest, ImportResponse, InternalEvent, InternalEventPayload, JsonPrimitive,
+    PluginContext, RenderPurpose, ShowToastRequest,
 };
 use crate::native_template_functions::{template_function_keyring, template_function_secure};
 use crate::nodejs::start_nodejs_plugin_runtime;
@@ -30,7 +31,7 @@ use std::path::{Path, PathBuf};
 use std::sync::Arc;
 use std::time::Duration;
 use tauri::path::BaseDirectory;
-use tauri::{AppHandle, Manager, Runtime, WebviewWindow, is_dev};
+use tauri::{AppHandle, Emitter, Manager, Runtime, WebviewWindow, is_dev};
 use tokio::fs::read_dir;
 use tokio::net::TcpListener;
 use tokio::sync::mpsc::error::TrySendError;
@@ -286,6 +287,21 @@ impl PluginManager {
             }
             if let Err(e) = self.add_plugin(plugin_context, &plugin).await {
                 warn!("Failed to add plugin {} {e:?}", plugin.directory);
+
+                // Extract a user-friendly plugin name from the directory path
+                let plugin_name = plugin.directory.split('/').last().unwrap_or(&plugin.directory);
+
+                // Show a toast for all plugin failures
+                let toast = ShowToastRequest {
+                    message: format!("Failed to start plugin '{}': {}", plugin_name, e),
+                    color: Some(Color::Danger),
+                    icon: Some(Icon::AlertTriangle),
+                    timeout: Some(10000),
+                };
+
+                if let Err(emit_err) = app_handle.emit("show_toast", toast) {
+                    error!("Failed to emit toast for plugin error: {emit_err:?}");
+                }
             }
         }