[PR #1271] [MERGED] Normalize mutli-line string indentation #984

New Issue

adam · 2025-12-30T01:28:07+01:00

adam commented

2025-12-30 01:28:07 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1271
Author: @HT154
Created: 10/30/2025
Status: ✅ Merged
Merged: 10/30/2025
Merged by: @HT154

Base: main ← Head: formatter-multi-line-string-mixed-indentation

📝 Commits (1)

1f996a3 Normalize mutli-line string indentation

📊 Changes

3 files changed (+46 additions, -9 deletions)

View changed files

📝 pkl-formatter/src/main/kotlin/org/pkl/formatter/Generator.kt (+6 -9)
📝 pkl-formatter/src/test/files/FormatterSnippetTests/input/multi-line-strings.pkl (+20 -0)
📝 pkl-formatter/src/test/files/FormatterSnippetTests/output/multi-line-strings.pkl (+20 -0)

📄 Description

The formatter previously assumed all indentation was spaces and failed to normalize leading indentation in multi-line strings to be spaces only.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1271 **Author:** [@HT154](https://github.com/HT154) **Created:** 10/30/2025 **Status:** ✅ Merged **Merged:** 10/30/2025 **Merged by:** [@HT154](https://github.com/HT154) **Base:** `main` ← **Head:** `formatter-multi-line-string-mixed-indentation` --- ### 📝 Commits (1) - [`1f996a3`](https://github.com/apple/pkl/commit/1f996a3658f401466ff53c21e5bf9e114ef8384f) Normalize mutli-line string indentation ### 📊 Changes **3 files changed** (+46 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `pkl-formatter/src/main/kotlin/org/pkl/formatter/Generator.kt` (+6 -9) 📝 `pkl-formatter/src/test/files/FormatterSnippetTests/input/multi-line-strings.pkl` (+20 -0) 📝 `pkl-formatter/src/test/files/FormatterSnippetTests/output/multi-line-strings.pkl` (+20 -0) </details> ### 📄 Description The formatter previously assumed all indentation was spaces and failed to normalize leading indentation in multi-line strings to be spaces only. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:28:07 +01:00

adam closed this issue

2025-12-30 01:28:07 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#984