starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-13 15:13:38 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1267] [MERGED] Correctly handle trailing commas in function type literals in the generic parser #983

New Issue
Closed
opened 2025-12-30 01:28:06 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:28:06 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1267
Author: @HT154
Created: 10/29/2025
Status: ✅ Merged
Merged: 10/29/2025
Merged by: @HT154

Base: main ← Head: generic-parser-function-literal-trailing-comma

📝 Commits (1)

  • 4bbbd56 Correctly handle trailing commas in function type literals in the generic parser

📊 Changes

3 files changed (+13 additions, -1 deletions)

View changed files

📝 pkl-formatter/src/test/files/FormatterSnippetTests/input/comma-termination.pkl (+2 -0)
📝 pkl-formatter/src/test/files/FormatterSnippetTests/output/comma-termination.pkl (+6 -0)
📝 pkl-parser/src/main/java/org/pkl/parser/GenericParser.java (+5 -1)

📄 Description

No description provided

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1267 **Author:** [@HT154](https://github.com/HT154) **Created:** 10/29/2025 **Status:** ✅ Merged **Merged:** 10/29/2025 **Merged by:** [@HT154](https://github.com/HT154) **Base:** `main` ← **Head:** `generic-parser-function-literal-trailing-comma` --- ### 📝 Commits (1) - [`4bbbd56`](https://github.com/apple/pkl/commit/4bbbd56e071b47202a7bba9ebd62217a18433c7c) Correctly handle trailing commas in function type literals in the generic parser ### 📊 Changes **3 files changed** (+13 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `pkl-formatter/src/test/files/FormatterSnippetTests/input/comma-termination.pkl` (+2 -0) 📝 `pkl-formatter/src/test/files/FormatterSnippetTests/output/comma-termination.pkl` (+6 -0) 📝 `pkl-parser/src/main/java/org/pkl/parser/GenericParser.java` (+5 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:28:06 +01:00
adam closed this issue 2025-12-30 01:28:06 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#983
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?