[PR #1258] [MERGED] Wrap comments in base.pkl to 100 chars #974

New Issue

Closed

opened 2025-12-30 01:28:03 +01:00 by adam · 0 comments

adam commented 2025-12-30 01:28:03 +01:00

Owner

Copy Link

Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1258
Author: @bioball
Created: 10/27/2025
Status: ✅ Merged
Merged: 10/28/2025
Merged by: @bioball

Base: main ← Head: base-pkl-line-endings

---

📝 Commits (1)

• 4b0506c Wrap comments in base.pkl to 100 chars

📊 Changes

212 files changed (+2020 additions, -1383 deletions)

View changed files

📝 pkl-core/src/test/files/LanguageSnippetTests/output/api/reflectedDeclaration.pcf (+626 -579)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/errors/invalidOutput3.err (+2 -2)
📝 pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt (+16 -4)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/Module Containing Spaces/index.html (+10 -6)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/baseModule/BaseClass.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/baseModule/index.html (+10 -6)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classAnnotations/AnnotatedClass.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classAnnotations/AnnotatedClss.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classAnnotations/AnnotatedClssWithExpandableComment.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classAnnotations/index.html (+10 -6)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments1.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments2.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments3.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments4.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments5.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments6.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments7.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments8.html (+2 -1)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/index.html (+10 -6)
📝 pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classInheritance/MyClass1.html (+2 -1)

...and 80 more files

📄 Description

Also, strip line numbers from reflectedDeclaration.pcf to reduce churn whenever base.pkl is modified.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1258 **Author:** [@bioball](https://github.com/bioball) **Created:** 10/27/2025 **Status:** ✅ Merged **Merged:** 10/28/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `base-pkl-line-endings` --- ### 📝 Commits (1) - [`4b0506c`](https://github.com/apple/pkl/commit/4b0506c51154adb34768406b96dc908526932db0) Wrap comments in base.pkl to 100 chars ### 📊 Changes **212 files changed** (+2020 additions, -1383 deletions) <details> <summary>View changed files</summary> 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/api/reflectedDeclaration.pcf` (+626 -579) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/errors/invalidOutput3.err` (+2 -2) 📝 `pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt` (+16 -4) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/Module Containing Spaces/index.html` (+10 -6) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/baseModule/BaseClass.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/baseModule/index.html` (+10 -6) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classAnnotations/AnnotatedClass.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classAnnotations/AnnotatedClss.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classAnnotations/AnnotatedClssWithExpandableComment.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classAnnotations/index.html` (+10 -6) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments1.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments2.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments3.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments4.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments5.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments6.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments7.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/Comments8.html` (+2 -1) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classComments/index.html` (+10 -6) 📝 `pkl-doc/src/test/files/DocGeneratorTest/output/run-1/com.package1/1.2.3/classInheritance/MyClass1.html` (+2 -1) _...and 80 more files_ </details> ### 📄 Description Also, strip line numbers from reflectedDeclaration.pcf to reduce churn whenever `base.pkl` is modified. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

adam added the pull-request label 2025-12-30 01:28:03 +01:00

adam closed this issue 2025-12-30 01:28:03 +01:00

Sign in to join this conversation.

No Branch/Tag Specified

Branches Tags

main

dependabot/github_actions/gradle/actions/dependency-submission-6.2.0

release/0.32

dependabot/gradle/com.squareup-kotlinpoet-2.3.0

truffle-object-model-clean

release/0.31

release/0.30

release/0.29

release/0.28

release/0.27

release/0.26

release/0.25

0.32.1

0.32.0

0.31.1

0.31.0

0.30.2

0.30.1

0.30.0

0.29.1

0.29.0

0.28.2

0.28.1

0.28.0

0.27.2

0.27.1

0.27.0

0.26.3

0.26.2

0.26.1

0.26.0

0.25.3

0.25.2

0.25.1

0.25.0

Labels

Clear labels

bug

duplicate

enhancement

good first issue

help wanted

pull-request

Mirrored from GitHub Pull Request

No labels pull-request

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

adam (Adam Melkus)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#974