[PR #1245] [CLOSED] Let expression formatting changes #963

New Issue

adam · 2025-12-30T01:27:59+01:00

adam commented

2025-12-30 01:27:59 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1245
Author: @bioball
Created: 10/19/2025
Status: ❌ Closed

Base: main ← Head: let-expr-formatting-fixes

📝 Commits (1)

163cb5a Let expression formatting changes

📊 Changes

4 files changed (+28 additions, -6 deletions)

View changed files

📝 pkl-formatter/src/main/kotlin/org/pkl/formatter/Builder.kt (+4 -4)
➕ pkl-formatter/src/test/files/FormatterSnippetTests/input/expr-let-if.pkl (+9 -0)
➕ pkl-formatter/src/test/files/FormatterSnippetTests/output/expr-let-if.pkl (+11 -0)
📝 pkl-formatter/src/test/files/FormatterSnippetTests/output/expr-let.pkl (+4 -2)

📄 Description

This add a newline after opening ( in a let expression when multilined. As a side-effect, this also fixes an issue where let expressions are incorrectly doubly indented.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1245 **Author:** [@bioball](https://github.com/bioball) **Created:** 10/19/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `let-expr-formatting-fixes` --- ### 📝 Commits (1) - [`163cb5a`](https://github.com/apple/pkl/commit/163cb5aec294960d66b7afec92c998ec6aa4b16d) Let expression formatting changes ### 📊 Changes **4 files changed** (+28 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `pkl-formatter/src/main/kotlin/org/pkl/formatter/Builder.kt` (+4 -4) ➕ `pkl-formatter/src/test/files/FormatterSnippetTests/input/expr-let-if.pkl` (+9 -0) ➕ `pkl-formatter/src/test/files/FormatterSnippetTests/output/expr-let-if.pkl` (+11 -0) 📝 `pkl-formatter/src/test/files/FormatterSnippetTests/output/expr-let.pkl` (+4 -2) </details> ### 📄 Description This add a newline after opening `(` in a let expression when multilined. As a side-effect, this also fixes an issue where let expressions are incorrectly doubly indented. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:59 +01:00

adam closed this issue

2025-12-30 01:27:59 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#963