starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-09-03 05:07:19 +02:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1228] [MERGED] Bump Gradle to 9.1.0 #953

New Issue
Closed
opened 2025-12-30 01:27:56 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:56 +01:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1228
Author: @bioball
Created: 10/8/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @bioball

Base: main ← Head: bump-gradle

📝 Commits (3)

📊 Changes

7 files changed (+8 additions, -69 deletions)

View changed files

📝 buildSrc/src/main/kotlin/MergeSourcesJars.kt (+2 -2)
📝 buildSrc/src/main/kotlin/pklAllProjects.gradle.kts (+1 -1)
📝 gradle/wrapper/gradle-wrapper.properties (+2 -2)
📝 pkl-gradle/pkl-gradle.gradle.kts (+1 -1)
📝 pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java (+0 -61)
📝 pkl-gradle/src/test/kotlin/org/pkl/gradle/KotlinCodeGeneratorsTest.kt (+1 -1)
📝 settings.gradle.kts (+1 -1)

📄 Description

Also, remove support for kotlin gradle plugin less than 1.8.x, because:

  • Class org.gradle.api.plugins.Convention is no longer available in the classpath in Gradle
  • Continued support for legacy plugin would require heavy reflection, which is brittle and hard to verify
  • Kotlin 1.7 is 3 years old and no longer updated

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1228 **Author:** [@bioball](https://github.com/bioball) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `bump-gradle` --- ### 📝 Commits (3) - [`235a14a`](https://github.com/apple/pkl/commit/235a14a2e493d644b9d8cc779c4d831c87a6f0eb) Bump Gradle to 9.1.0 - [`8737040`](https://github.com/apple/pkl/commit/8737040573013a9e5a585040aac6835509b88c04) Bump foojay resolver to 1.0.0 - [`5372071`](https://github.com/apple/pkl/commit/53720718d222f5451813cb065550fd7a270cfff9) Fix build logic on windows ### 📊 Changes **7 files changed** (+8 additions, -69 deletions) <details> <summary>View changed files</summary> 📝 `buildSrc/src/main/kotlin/MergeSourcesJars.kt` (+2 -2) 📝 `buildSrc/src/main/kotlin/pklAllProjects.gradle.kts` (+1 -1) 📝 `gradle/wrapper/gradle-wrapper.properties` (+2 -2) 📝 `pkl-gradle/pkl-gradle.gradle.kts` (+1 -1) 📝 `pkl-gradle/src/main/java/org/pkl/gradle/PklPlugin.java` (+0 -61) 📝 `pkl-gradle/src/test/kotlin/org/pkl/gradle/KotlinCodeGeneratorsTest.kt` (+1 -1) 📝 `settings.gradle.kts` (+1 -1) </details> ### 📄 Description Also, remove support for kotlin gradle plugin less than 1.8.x, because: * Class `org.gradle.api.plugins.Convention` is no longer available in the classpath in Gradle * Continued support for legacy plugin would require heavy reflection, which is brittle and hard to verify * Kotlin 1.7 is 3 years old and no longer updated --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:56 +01:00
adam closed this issue 2025-12-30 01:27:56 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
adam (Adam Melkus)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#953