starred/pkl
1
0
Fork 0
mirror of https://github.com/apple/pkl.git synced 2026-01-11 22:30:54 +01:00
Code Issues 198 Packages Projects Releases 10 Wiki Activity

[PR #1227] [MERGED] Follow up for trace pretty printing #951

New Issue
Closed
opened 2025-12-30 01:27:55 +01:00 by adam · 0 comments
adam commented 2025-12-30 01:27:55 +01:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1227
Author: @HT154
Created: 10/7/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @HT154

Base: main ← Head: trace-mode-followup

📝 Commits (1)

  • 025b916 Follow up for trace pretty printing

📊 Changes

29 files changed (+180 additions, -113 deletions)

View changed files

📝 bench/src/jmh/java/org/pkl/core/ListSort.java (+2 -1)
📝 docs/src/test/kotlin/DocSnippetTests.kt (+2 -1)
📝 pkl-cli/src/main/kotlin/org/pkl/cli/CliRepl.kt (+2 -1)
📝 pkl-cli/src/test/kotlin/org/pkl/cli/repl/ReplMessagesTest.kt (+2 -1)
📝 pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt (+3 -4)
📝 pkl-core/src/main/java/org/pkl/core/Analyzer.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/EvaluatorBuilder.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/EvaluatorImpl.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/Loggers.java (+9 -2)
📝 pkl-core/src/main/java/org/pkl/core/ast/expression/unary/TraceNode.java (+19 -25)
📝 pkl-core/src/main/java/org/pkl/core/evaluatorSettings/TraceMode.java (+1 -3)
📝 pkl-core/src/main/java/org/pkl/core/repl/ReplServer.java (+1 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/StdLibModule.java (+2 -1)
📝 pkl-core/src/main/java/org/pkl/core/runtime/VmContext.java (+2 -2)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/compactTraceMode/PklProject (+1 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/compactTraceMode/compactTraceMode.pkl (+0 -0)
➖ pkl-core/src/test/files/LanguageSnippetTests/input/projects/hiddenTraceMode/PklProject (+0 -5)
➖ pkl-core/src/test/files/LanguageSnippetTests/input/projects/hiddenTraceMode/hiddenTraceMode.pkl (+0 -18)
📝 pkl-core/src/test/files/LanguageSnippetTests/input/projects/prettyTraceMode/prettyTraceMode.pkl (+45 -1)
📝 pkl-core/src/test/files/LanguageSnippetTests/output/projects/compactTraceMode/compactTraceMode.err (+1 -1)

...and 9 more files

📄 Description

This PR addresses @stackoverflow's feedback in #1100, removes the hidden trace mode, and renames the default mode to `compact.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1227 **Author:** [@HT154](https://github.com/HT154) **Created:** 10/7/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@HT154](https://github.com/HT154) **Base:** `main` ← **Head:** `trace-mode-followup` --- ### 📝 Commits (1) - [`025b916`](https://github.com/apple/pkl/commit/025b91649dc6c148f00cb47fce5831e885f1b188) Follow up for trace pretty printing ### 📊 Changes **29 files changed** (+180 additions, -113 deletions) <details> <summary>View changed files</summary> 📝 `bench/src/jmh/java/org/pkl/core/ListSort.java` (+2 -1) 📝 `docs/src/test/kotlin/DocSnippetTests.kt` (+2 -1) 📝 `pkl-cli/src/main/kotlin/org/pkl/cli/CliRepl.kt` (+2 -1) 📝 `pkl-cli/src/test/kotlin/org/pkl/cli/repl/ReplMessagesTest.kt` (+2 -1) 📝 `pkl-commons-cli/src/main/kotlin/org/pkl/commons/cli/commands/BaseOptions.kt` (+3 -4) 📝 `pkl-core/src/main/java/org/pkl/core/Analyzer.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/EvaluatorBuilder.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/EvaluatorImpl.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/Loggers.java` (+9 -2) 📝 `pkl-core/src/main/java/org/pkl/core/ast/expression/unary/TraceNode.java` (+19 -25) 📝 `pkl-core/src/main/java/org/pkl/core/evaluatorSettings/TraceMode.java` (+1 -3) 📝 `pkl-core/src/main/java/org/pkl/core/repl/ReplServer.java` (+1 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/StdLibModule.java` (+2 -1) 📝 `pkl-core/src/main/java/org/pkl/core/runtime/VmContext.java` (+2 -2) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/compactTraceMode/PklProject` (+1 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/compactTraceMode/compactTraceMode.pkl` (+0 -0) ➖ `pkl-core/src/test/files/LanguageSnippetTests/input/projects/hiddenTraceMode/PklProject` (+0 -5) ➖ `pkl-core/src/test/files/LanguageSnippetTests/input/projects/hiddenTraceMode/hiddenTraceMode.pkl` (+0 -18) 📝 `pkl-core/src/test/files/LanguageSnippetTests/input/projects/prettyTraceMode/prettyTraceMode.pkl` (+45 -1) 📝 `pkl-core/src/test/files/LanguageSnippetTests/output/projects/compactTraceMode/compactTraceMode.err` (+1 -1) _...and 9 more files_ </details> ### 📄 Description This PR addresses @stackoverflow's feedback in #1100, removes the `hidden` trace mode, and renames the `default` mode to `compact. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:55 +01:00
adam closed this issue 2025-12-30 01:27:55 +01:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
duplicate
enhancement
good first issue
help wanted
pull-request
Mirrored from GitHub Pull Request
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
adam
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#951
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?