[PR #1214] [CLOSED] Formatter Test Cases #943

Closed
opened 2025-12-30 01:27:53 +01:00 by adam · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1214
Author: @srueg
Created: 9/18/2025
Status: Closed

Base: mainHead: srueg/formatter-test-cases


📝 Commits (2)

  • 5d6ff1f Whitespace is added to empty file
  • 49e9117 Doc-comment only fails to parse

📊 Changes

4 files changed (+6 additions, -0 deletions)

View changed files

pkl-formatter/src/test/files/FormatterSnippetTests/input/empty-file.pkl (+0 -0)
pkl-formatter/src/test/files/FormatterSnippetTests/input/only-doc-comment.pkl (+3 -0)
pkl-formatter/src/test/files/FormatterSnippetTests/output/empty-file.pkl (+0 -0)
pkl-formatter/src/test/files/FormatterSnippetTests/output/only-doc-comment.pkl (+3 -0)

📄 Description

Showcasing some discovered issues with the current formatter.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1214 **Author:** [@srueg](https://github.com/srueg) **Created:** 9/18/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `srueg/formatter-test-cases` --- ### 📝 Commits (2) - [`5d6ff1f`](https://github.com/apple/pkl/commit/5d6ff1f72abb71a599cde36140a4f3f5fd33f3eb) Whitespace is added to empty file - [`49e9117`](https://github.com/apple/pkl/commit/49e9117b85704b7d9d7d0300dfe7df41b6d9d2cd) Doc-comment only fails to parse ### 📊 Changes **4 files changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `pkl-formatter/src/test/files/FormatterSnippetTests/input/empty-file.pkl` (+0 -0) ➕ `pkl-formatter/src/test/files/FormatterSnippetTests/input/only-doc-comment.pkl` (+3 -0) ➕ `pkl-formatter/src/test/files/FormatterSnippetTests/output/empty-file.pkl` (+0 -0) ➕ `pkl-formatter/src/test/files/FormatterSnippetTests/output/only-doc-comment.pkl` (+3 -0) </details> ### 📄 Description Showcasing some discovered issues with the current formatter. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
adam added the pull-request label 2025-12-30 01:27:53 +01:00
adam closed this issue 2025-12-30 01:27:53 +01:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: starred/pkl#943