[PR #1175] [MERGED] Fix missing resources in native pkldoc, and disable test mode #926

New Issue

adam · 2025-12-30T01:27:47+01:00

adam commented

2025-12-30 01:27:47 +01:00

📋 Pull Request Information

Original PR: https://github.com/apple/pkl/pull/1175
Author: @bioball
Created: 8/14/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @bioball

Base: main ← Head: pkldoc-fix

📝 Commits (1)

b628bb9 Fix missing resources in native pkldoc, and disable test mode

📊 Changes

13 files changed (+577 additions, -186 deletions)

View changed files

➕ pkl-commons-test/src/main/kotlin/org/pkl/commons/test/Executables.kt (+85 -0)
➖ pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PklExecutablePaths.kt (+0 -47)
📝 pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt (+7 -7)
📝 pkl-doc/pkl-doc.gradle.kts (+25 -0)
📝 pkl-doc/src/main/kotlin/org/pkl/doc/Main.kt (+4 -1)
📝 pkl-doc/src/test/kotlin/org/pkl/doc/CliDocGeneratorTest.kt (+20 -125)
➕ pkl-doc/src/test/kotlin/org/pkl/doc/DocGeneratorTestHelper.kt (+181 -0)
➕ pkl-doc/src/test/kotlin/org/pkl/doc/DocTestUtils.kt (+73 -0)
➕ pkl-doc/src/test/kotlin/org/pkl/doc/JavaExecutableTest.kt (+41 -0)
➕ pkl-doc/src/test/kotlin/org/pkl/doc/NativeExecutableTest.kt (+42 -0)
📝 pkl-doc/src/test/kotlin/org/pkl/doc/SearchTest.kt (+4 -4)
➕ pkl-doc/src/test/kotlin/org/pkl/doc/TestUtils.kt (+93 -0)
📝 pkl-server/src/test/kotlin/org/pkl/server/NativeServerTest.kt (+2 -2)

📄 Description

This fixes two issues:

Test mode is enabled in pkldoc without the ability to turn it off
Native pkldoc is missing required resources

This also adds tests for both jpkldoc and pkldoc, by running the same input/output tests of src/test/files/DocGeneratorTest.

Closes #1174
Closes #1176

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/apple/pkl/pull/1175 **Author:** [@bioball](https://github.com/bioball) **Created:** 8/14/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@bioball](https://github.com/bioball) **Base:** `main` ← **Head:** `pkldoc-fix` --- ### 📝 Commits (1) - [`b628bb9`](https://github.com/apple/pkl/commit/b628bb96e1b316396e78c2c79a0bcc922739b4b2) Fix missing resources in native pkldoc, and disable test mode ### 📊 Changes **13 files changed** (+577 additions, -186 deletions) <details> <summary>View changed files</summary> ➕ `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/Executables.kt` (+85 -0) ➖ `pkl-commons-test/src/main/kotlin/org/pkl/commons/test/PklExecutablePaths.kt` (+0 -47) 📝 `pkl-core/src/test/kotlin/org/pkl/core/LanguageSnippetTestsEngine.kt` (+7 -7) 📝 `pkl-doc/pkl-doc.gradle.kts` (+25 -0) 📝 `pkl-doc/src/main/kotlin/org/pkl/doc/Main.kt` (+4 -1) 📝 `pkl-doc/src/test/kotlin/org/pkl/doc/CliDocGeneratorTest.kt` (+20 -125) ➕ `pkl-doc/src/test/kotlin/org/pkl/doc/DocGeneratorTestHelper.kt` (+181 -0) ➕ `pkl-doc/src/test/kotlin/org/pkl/doc/DocTestUtils.kt` (+73 -0) ➕ `pkl-doc/src/test/kotlin/org/pkl/doc/JavaExecutableTest.kt` (+41 -0) ➕ `pkl-doc/src/test/kotlin/org/pkl/doc/NativeExecutableTest.kt` (+42 -0) 📝 `pkl-doc/src/test/kotlin/org/pkl/doc/SearchTest.kt` (+4 -4) ➕ `pkl-doc/src/test/kotlin/org/pkl/doc/TestUtils.kt` (+93 -0) 📝 `pkl-server/src/test/kotlin/org/pkl/server/NativeServerTest.kt` (+2 -2) </details> ### 📄 Description This fixes two issues: 1. Test mode is enabled in pkldoc without the ability to turn it off 2. Native pkldoc is missing required resources This also adds tests for both `jpkldoc` and `pkldoc`, by running the same input/output tests of `src/test/files/DocGeneratorTest`. Closes #1174 Closes #1176 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

adam added the pull-request label 2025-12-30 01:27:47 +01:00

adam closed this issue

2025-12-30 01:27:47 +01:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: starred/pkl#926